On Sat, 2 Dec 2023 00:32:30 GMT, Ioi Lam wrote:
>> src/hotspot/share/cds/cdsConfig.cpp line 34:
>>
>>> 32: #include "logging/log.hpp"
>>> 33: #include "runtime/arguments.hpp"
>>> 34: #include "runtime/java.hpp"
>>
>> I was able to build with your patch without including `java.hpp`.
>> The
On Sat, 2 Dec 2023 00:38:58 GMT, Ioi Lam wrote:
>> This is a simple clean up that moves the code for initializing the CDS
>> config states from arguments.cpp to cdsConfig.cpp
>>
>> I renamed a few functions, but otherwise the code is unchanged.
>>
>> - `get_default_shared_archive_path()` ->
On Tue, 28 Nov 2023 23:24:53 GMT, Ioi Lam wrote:
> This is a simple clean up that moves the code for initializing the CDS config
> states from arguments.cpp to cdsConfig.cpp
>
> I renamed a few functions, but otherwise the code is unchanged.
>
> - `get_default_shared_archive_path()` ->
On Thu, 19 Oct 2023 05:56:53 GMT, Ioi Lam wrote:
> This is the first step for [JDK-8318483 - Move CDS configuration management
> into cdsConfig.hpp](https://bugs.openjdk.org/browse/JDK-8318483)
>
> - Remove `Arguments::is_dumping_archive()` and `Arguments
> assert_is_dumping_archive()`
> -
On Thu, 21 Sep 2023 20:39:32 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java
> on all platforms. It's a new test and we already have 8 failure sightings in
> the JDK22 CI.
Looks good and trivial.
-
On Thu, 7 Sep 2023 19:17:42 GMT, Daniel D. Daugherty wrote:
> Trivial fixes to ProblemList some tests:
> - [JDK-8315877](https://bugs.openjdk.org/browse/JDK-8315877) ProblemList
> vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on
> macosx-aarch64
> -
On Tue, 14 Mar 2023 20:20:41 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
On Thu, 8 Sep 2022 16:19:15 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64.
> This time for sure Rocky! I've included the "#id1" sub-test identifier.
LGTM
-
Marked as reviewed by ccheung
On Tue, 28 Jun 2022 20:13:01 GMT, Ioi Lam wrote:
>> There are only two implementations of these classes (one for windows, and
>> one for posix):
>>
>> - PlatformEvent
>> - PlatformParker
>> - PlatformMutex
>> - PlatformMonitor
>> - ThreadCrashProtection
>>
>> Before this PR, these classes are
