Re: RFR: 8332111: [BACKOUT] A way to align already compiled methods with compiler directives

2024-05-14 Thread Dmitry Chuyko
On Mon, 13 May 2024 21:08:08 GMT, Evgeny Astigeevich wrote: >> Backout of [JDK-8309271](https://bugs.openjdk.org/browse/JDK-8309271) which >> has known bugs, possible bugs and performance issues. REDO work is tracked >> by [JDK-8331749](https://bugs.openjdk.org/browse/JDK-8331749). >> >>

Re: RFR: 8332111: [BACKOUT] A way to align already compiled methods with compiler directives

2024-05-13 Thread Dmitry Chuyko
On Mon, 13 May 2024 14:21:35 GMT, Evgeny Astigeevich wrote: > > Are there any high severity problems caused by the original PR? Especially > > not in the new functionality. Minor issues could be probably addressed > > without backing out the entire functionality. > > > > Yes, there are: >

Re: RFR: 8332111: [BACKOUT] A way to align already compiled methods with compiler directives

2024-05-13 Thread Dmitry Chuyko
On Mon, 13 May 2024 13:03:26 GMT, Evgeny Astigeevich wrote: > Backout of [JDK-8309271](https://bugs.openjdk.org/browse/JDK-8309271) which > has known bugs, possible bugs and performance issues. REDO work is tracked by > [JDK-8331749](https://bugs.openjdk.org/browse/JDK-8331749). > > Found

Integrated: 8309271: A way to align already compiled methods with compiler directives

2024-03-14 Thread Dmitry Chuyko
On Wed, 24 May 2023 00:38:27 GMT, Dmitry Chuyko wrote: > Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDi

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v32]

2024-03-14 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v31]

2024-03-14 Thread Dmitry Chuyko
On Wed, 13 Mar 2024 17:31:32 GMT, Dmitry Chuyko wrote: >> Compiler Control (https://openjdk.org/jeps/165) provides method-context >> dependent control of the JVM compilers (C1 and C2). The active directive >> stack is built from the dire

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v29]

2024-03-13 Thread Dmitry Chuyko
On Wed, 13 Mar 2024 07:48:35 GMT, Serguei Spitsyn wrote: >> Dmitry Chuyko has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 47 commits: >> >> - Resolved master conflicts >> - Merge branch 'openjdk:ma

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v31]

2024-03-13 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Compiler.r

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v30]

2024-03-13 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v29]

2024-03-13 Thread Dmitry Chuyko
On Wed, 13 Mar 2024 07:43:35 GMT, Serguei Spitsyn wrote: >> Dmitry Chuyko has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 47 commits: >> >> - Resolved master conflicts >> - Merge branch 'openjdk:ma

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v29]

2024-03-12 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v28]

2024-03-04 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v27]

2024-02-28 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v26]

2024-02-26 Thread Dmitry Chuyko
On Sat, 24 Feb 2024 11:22:17 GMT, Dmitry Chuyko wrote: >> Compiler Control (https://openjdk.org/jeps/165) provides method-context >> dependent control of the JVM compilers (C1 and C2). The active directive >> stack is built from the dire

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v26]

2024-02-24 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v25]

2024-02-13 Thread Dmitry Chuyko
On Wed, 31 Jan 2024 21:12:19 GMT, Dmitry Chuyko wrote: >> Compiler Control (https://openjdk.org/jeps/165) provides method-context >> dependent control of the JVM compilers (C1 and C2). The active directive >> stack is built from the dire

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v25]

2024-01-31 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v24]

2024-01-25 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v23]

2024-01-18 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v22]

2024-01-18 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v21]

2024-01-11 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v20]

2024-01-04 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v15]

2023-12-22 Thread Dmitry Chuyko
On Wed, 20 Dec 2023 02:57:29 GMT, Andrei Pangin wrote: >> Dmitry Chuyko has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'openjdk:master' into compiler-directives-force-u

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v19]

2023-12-22 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Compiler.r

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v15]

2023-12-22 Thread Dmitry Chuyko
On Wed, 20 Dec 2023 02:40:40 GMT, Andrei Pangin wrote: >> Dmitry Chuyko has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'openjdk:master' into compiler-directives-force-u

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v18]

2023-12-21 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v17]

2023-12-21 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v16]

2023-12-20 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v15]

2023-12-14 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v14]

2023-12-11 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v13]

2023-12-08 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v12]

2023-12-07 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v11]

2023-11-24 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v10]

2023-11-15 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v9]

2023-10-11 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v8]

2023-09-28 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v7]

2023-09-27 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v6]

2023-08-31 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v5]

2023-08-24 Thread Dmitry Chuyko
here are rules for inlining into some method, it will be > refreshed. On the other hand, if there are rules for a method and it was > inlined, top-level methods won't be refreshed, but this can be achieved by > having rules for them. > > In addition, a new diagnostic command `Com

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v5]

2023-08-24 Thread Dmitry Chuyko
On Mon, 12 Jun 2023 12:00:48 GMT, Andrei Pangin wrote: >> Dmitry Chuyko has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - jcheck >> - Unnecessary import >> - forc

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v4]

2023-07-25 Thread Dmitry Chuyko
it will be deoptimized. On the other hand, if > there are rules for a method and it was inlined, top-level methods won't be > deoptimized, but this can be achieved by having rules for them. > > In addition, a new diagnistic command `Compiler.replace_directives`, has been > add

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v3]

2023-07-25 Thread Dmitry Chuyko
it will be deoptimized. On the other hand, if > there are rules for a method and it was inlined, top-level methods won't be > deoptimized, but this can be achieved by having rules for them. > > In addition, a new diagnistic command `Compiler.replace_directives`, has been > added fo

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v2]

2023-07-25 Thread Dmitry Chuyko
it will be deoptimized. On the other hand, if > there are rules for a method and it was inlined, top-level methods won't be > deoptimized, but this can be achieved by having rules for them. > > In addition, a new diagnistic command `Compiler.replace_directives`, has been > add

RFR: 8309271: A way to align already compiled methods with compiler directives

2023-06-01 Thread Dmitry Chuyko
Compiler Control (https://openjdk.org/jeps/165) provides method-context dependent control of the JVM compilers (C1 and C2). The active directive stack is built from the directive files passed with the `-XX:CompilerDirectivesFile` diagnostic command-line option and the Compiler.add_directives