On Mon, 22 Sep 2025 15:00:41 GMT, Jorn Vernee wrote:
>> @mcimadamore Can you help us here? libsyslookup has a dependency to libdl,
>> but it is not used. Can we remove that from the linker command line, or
>> would it somehow break libsyslookup? (I have just a very fuzzy idea of the
>> point
On Fri, 19 Sep 2025 04:43:29 GMT, Phil Race wrote:
> I have started a verification job with tier1-5.
Job has completed. There were 2 failures, one had lots of recent history of
failing, so seems unrelated. The other was a crash that seemed unusual, but it
passed on a rerun. So I think we can s
On Thu, 18 Sep 2025 07:20:55 GMT, Matthias Baesken wrote:
> A couple of JDK native libs link to $(LIBDL) , but some do not use symbols
> from it.
I have started a verification job with tier1-5.
-
PR Comment: https://git.openjdk.org/jdk/pull/27358#issuecomment-3307387278
On Sat, 10 May 2025 20:20:32 GMT, Archie Cobbs wrote:
> This PR adds a new compiler warning for `@SuppressWarnings` annotations that
> don't actually suppress any warnings.
>
> Summary of code changes:
>
> * Add new warning and associated lint category `"suppression"`
> * Update `LintMapper` t
On Sat, 10 May 2025 20:20:32 GMT, Archie Cobbs wrote:
> This PR adds a new compiler warning for `@SuppressWarnings` annotations that
> don't actually suppress any warnings.
>
> Summary of code changes:
>
> * Add new warning and associated lint category `"suppression"`
> * Update `LintMapper` t
On Fri, 15 Aug 2025 15:05:02 GMT, Leonid Mesnik wrote:
>> The fix added JVMTI stress testing mode.
>>
>> This mode enables stress agent that could be executed with jtreg test and
>> help to ensure that jvmti functionality doesn't break the other JVM/JDK
>> functionality.
>>
>> I filed few iss
On Thu, 14 Aug 2025 19:44:59 GMT, Leonid Mesnik wrote:
>> The fix added JVMTI stress testing mode.
>>
>> This mode enables stress agent that could be executed with jtreg test and
>> help to ensure that jvmti functionality doesn't break the other JVM/JDK
>> functionality.
>>
>> I filed few iss
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote:
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing
On Thu, 7 Aug 2025 22:18:43 GMT, Leonid Mesnik wrote:
>> The fix added JVMTI stress testing mode.
>>
>> This mode enables stress agent that could be executed with jtreg test and
>> help to ensure that jvmti functionality doesn't break the other JVM/JDK
>> functionality.
>>
>> I filed few issu
On Thu, 17 Jul 2025 02:39:15 GMT, Leonid Mesnik wrote:
> The fix added JVMTI stress testing mode.
>
> This mode enables stress agent that could be executed with jtreg test and
> help to ensure that jvmti functionality doesn't break the other JVM/JDK
> functionality.
>
> I filed few issues and
On Mon, 28 Apr 2025 09:15:28 GMT, Igor Veresov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store me
On Mon, 10 Mar 2025 15:38:45 GMT, Matthias Baesken wrote:
> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
> are most likely not needed any more and could be removed.
make/modules/java.management/Lib.gmk line 33:
> 31: ## Build libmanagement
> 32:
> #
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Tue, 11 Mar 2025 19:22:34 GMT, snake66 wrote:
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
I think this looks ok, but please wait for Magnus to have a look too.
-
Marked as reviewed by e
On Tue, 11 Mar 2025 15:19:24 GMT, Matthias Baesken wrote:
> > Was this always redundant, and does removing it make no change to current
> > build options?
> > If so, great, let's remove the useless makefile lines.
>
> There was a bit of discussion before in the thread
> https://mail.openjdk.or
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Greg Lew
On Tue, 24 Dec 2024 03:26:23 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some source files.
>
> Qizheng Xing has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.
On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing wrote:
> This patch fixes unmatched brackets in some source files.
I can really only review the doc files and the Makefile.
doc/hotspot-unit-tests.md line 175:
> 173: there is no need to have them in error messages. Asserts print only
> 174: compa
On Mon, 28 Oct 2024 18:58:51 GMT, Aleksey Shipilev wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>> T
On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie wrote:
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This
On Mon, 21 Oct 2024 13:12:55 GMT, SendaoYan wrote:
>> Hi all,
>> In
>> [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208),
>> the keyword is 'TEST_THREAD_FACTORY'.
>>
>> So the below test command will print error:
>>
>> make test TEST=test/jdk/java/math/Big
On Sun, 20 Oct 2024 02:11:11 GMT, SendaoYan wrote:
> Hi all,
> In
> [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208),
> the keyword is 'TEST_THREAD_FACTORY'.
>
> So the below test command will print error:
>
> make test TEST=test/jdk/java/math/BigInteger/
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
On Fri, 30 Aug 2024 11:35:51 GMT, Magnus Ihse Bursie wrote:
>> Currently, we issue -Wno-unused for all files in clang, which is a rather
>> big sledgehammer to get rid of some warnings that proliferate in a few areas
>> of the build.
>>
>> We should instead leave -Wunused turned on (as done by
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
On Wed, 28 Aug 2024 15:17:52 GMT, Magnus Ihse Bursie wrote:
>> Currently, we issue -Wno-unused for all files in gcc, which is a rather big
>> sledgehammer to get rid of some warnings that proliferate in a few areas of
>> the build.
>>
>> We should instead leave -Wunused turned on (as done by -
On Mon, 26 Aug 2024 02:07:39 GMT, David Holmes wrote:
> I understand the cost overhead experienced by any individual Java run may be
> lost in the noise, but it still impacts every single Java run just to save
> some time/resources for the handful of builders of statically linked VMs. I
> am n
On Fri, 7 Jun 2024 12:37:48 GMT, Julian Waters wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete extra empty trailing blank line in
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile
>
> test/jdk/java/rmi
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revi
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19537#pull
On Thu, 30 May 2024 19:14:43 GMT, Magnus Ihse Bursie wrote:
> The original way of building static libraries in the JDK was to use the
> configure argument --enable-static-build, which set the value of the make
> variable STATIC_BUILD. (Note that this is not the same as the source code
> defini
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
> sp
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Thu, 15 Feb 2024 12:26:11 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Fri, 9 Feb 2024 13:42:02 GMT, Magnus Ihse Bursie wrote:
>> This is an attempt to finally implement the idea brought forward in
>> JDK-8295729: Properties files is essentially source code. It should have
>> the same whitespace checks as all other source code, so we don't get
>> spurious tra
On Tue, 2 Jan 2024 21:44:04 GMT, Mikael Vidstedt wrote:
> The libinstrument library is linked against libjava and libjvm, twice. This
> is mostly harmless but Xcode 15.x generates a warning:
>
> Creating support/modules_libs/java.instrument/libinstrument.dylib from 12
> file(s)
> ld: warning:
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in.
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in.
On Tue, 5 Sep 2023 23:12:51 GMT, Chris Plummer wrote:
> I wonder if this is the right thing to do for the hprof files. I believe they
> originated from some hprof tools that we no longer ship. 3rd parties might
> choose to integrate them into their own tools.
Do you think I should revert them?
There are a number of files in the `test` directory that have an incorrect
copyright header, which includes the "classpath" exception text. This patch
removes that text from all test files that I could find it in. I did this using
a combination of `sed` and `grep`. Reviewing this patch is probab
On Thu, 29 Jun 2023 07:41:11 GMT, David Holmes wrote:
> This seems to run contrary to the requirement that files end in a newline,
> which git will complain about if the newline is missing.
The patch is leaving exactly one newline at the end of the file.
-
PR Comment: https://git.
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Sat, 24 Jun 2023 06:47:48 GMT, Vladimir Sitnikov
wrote:
> I've posted the suggetion to add .editorconfig on ide-support-dev, however,
> the list does not seem to be active:
> https://mail.openjdk.org/pipermail/ide-support-dev/2023-June/000281.html
I think that sounds like a reasonable idea
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
The update to Java.gmk is good.
-
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.o
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a r
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote:
> Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc`
> and `PackageDesc` become obsolete after
> [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
> All references to `jdk.internal.classfile.java.lang.const
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Fri, 14 Apr 2023 14:31:31 GMT, Roger Riggs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed isPPC64().
>> Consolidated switch cases in ArchTest.
>> Moved mapping of build TARGET_OS and TARGET_CPU to the
On Wed, 5 Apr 2023 15:58:08 GMT, Roger Riggs wrote:
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, I
On Tue, 15 Nov 2022 10:42:58 GMT, Stefan Karlsson wrote:
>> One of the more prevalent issues is that files in src/hotspot/share/include
>> are not properly sorted. There has been some discussion that that was done
>> on purpose, but it just adds another exception to the include rules that
>> d
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 10:15:50 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in the
> serv
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
55 matches
Mail list logo
