On Thu, 26 Jun 2025 01:26:38 GMT, SendaoYan wrote:
> Should we should copy the dependent files such as libasan.so.8 to docker
> images when build it.
See:
https://bugs.openjdk.org/browse/JDK-8333144?focusedId=14792939&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comme
On Wed, 25 Jun 2025 14:09:42 GMT, Matthias Baesken wrote:
> When the address sanitizer ASAN is configured, we run into errors in the
> docker tests.
> Example hotspot/jtreg/containers/docker/DockerBasicTest.java :
>
> [STDOUT]
> /jdk/bin/java: error while loading shared libraries: libasan.so.8:
On Tue, 1 Apr 2025 14:59:37 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
On Tue, 1 Apr 2025 14:59:37 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated the
On Thu, 20 Feb 2025 14:22:20 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
On Sun, 2 Mar 2025 21:17:04 GMT, Sergey Chernyshev
wrote:
> > OK for me now. `test_cgroupSubsystem_linux.cpp` needs a copyright update as
> > well.
>
> Thanks for your review @jerboaa ! I cheched the
> test_cgroupSubsystem_linux.cpp, it's already updated to 2025 in the master
> branch.
OK!
On Fri, 28 Feb 2025 20:40:37 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Fri, 28 Feb 2025 12:19:53 GMT, Matthias Baesken wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated comment
>
> src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 2:
>
>> 1: /*
>> 2: * Copyright (c
On Wed, 26 Feb 2025 00:52:41 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Tue, 25 Feb 2025 16:31:05 GMT, Sergey Chernyshev
wrote:
>> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 42:
>>
>>> 40: * When runs in a container, the method handles the case
>>> 41: * when a process is moved between cgroups.
>>> 42: */
>>
>> This needs to explain exactly what i
On Mon, 24 Feb 2025 23:33:01 GMT, Sergey Chernyshev
wrote:
>> `CgroupV1Controller::set_subsystem_path` needs high level comment update to
>> describe the logic happening.
>>
>> Testing:
And after the patch this would become this, right?
```
/sys/fs/cgroup/cpu,cpuacct/system.slice/g
On Mon, 24 Feb 2025 21:20:49 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated the
On Thu, 12 Dec 2024 01:11:33 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Fri, 10 Jan 2025 14:57:09 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
On Fri, 10 Jan 2025 14:57:09 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated the
On Tue, 19 Nov 2024 13:37:25 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated th
On Wed, 11 Dec 2024 15:19:06 GMT, Sergey Chernyshev
wrote:
>> src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 322:
>>
>>> 320: } else {
>>> 321: log_warning(os, container)("Cgroup cpu/memory controller path
>>> includes '../', detected limits won't be accurate");
>>> 322: }
On Mon, 9 Dec 2024 13:00:20 GMT, Severin Gehwolf wrote:
> Since this is my second merged PR to the OpenJDK, could I become one?
If you want to be, the process for becoming OpenJDK author is described here:
https://openjdk.org/projects/#project-author
The relevant project is `jdk`:
ht
On Mon, 9 Dec 2024 12:27:21 GMT, Severin Gehwolf wrote:
>> @kevinjwalls Thanks! Apologies in advance if this is not the right process,
>> but could this be cherry-picked into JDK 21?
>
>> Apologies in advance if this is not the right process, but could this be
>>
On Mon, 9 Dec 2024 12:14:32 GMT, Fabian Meumertzheim wrote:
> Apologies in advance if this is not the right process, but could this be
> cherry-picked into JDK 21?
Please see
https://github.com/openjdk/jdk21u-dev?tab=readme-ov-file#welcome-to-openjdk-21-updates
for the process.
-
On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one
> additional commit
thname is relative to the mount point of the
>>hierarchy.
>>
>>
>> This explicitly states the "pathname is relative t...
>
> Sergey Chernyshev has updated the pull request with a new target base due to
> a merge or a rebase. The pull r
;
> - merge latest from master branch
> - remove changes to
> src/java.base/unix/classes/sun/security/provider/NativePRNG.java
> - remove unused import
> - replace remaining Paths.get() with Path.of() in the updated files
> - Update
> src/java.base/linux/classes/jdk
c/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
>
> Co-authored-by: Severin Gehwolf
cgroups changes look good. Haven't looked at the other bits.
src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
line 29:
> 27: packag
On Mon, 2 Dec 2024 14:03:10 GMT, Jaikiran Pai wrote:
>> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
>> line 70:
>>
>>> 68: String line = bufferedReader.readLine();
>>> 69: return line;
>>> 70: } catch (IOException e) {
>>
>>
On Mon, 2 Dec 2024 12:43:20 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in CgroupS
On Mon, 2 Dec 2024 13:39:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Sun, 1 Dec 2024 12:48:40 GMT, Sergey Chernyshev
wrote:
> In the Cloudflare case (cg v1 before patch), the path
> `/sys/fs/cgroup/cpu,cpuacct/system.slice/garden.service/garden/bad/2f57368b-0eda-4e52-64d8-af5c`
> will be adjusted as follows:
I assume that's the adjustment logic (pre-patch)
On Fri, 29 Nov 2024 14:47:13 GMT, Sergey Chernyshev
wrote:
> > Right. I'm still not convinced this extra reduction buys us much. The
> > adjust controller logic will handle it if kept as is in the Metrics version.
>
> The adjust controller logic won't handle it, because it reduces the path fro
On Wed, 27 Nov 2024 09:11:22 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Wed, 27 Nov 2024 10:56:57 GMT, Sergey Chernyshev
wrote:
>>> Version specific code can be had in `set_subsystem_path()` of the
>>> corresponding impl (like an earlier version of your patch). `lowest_limit`
>>> and `limit_cg_path` fixes are version agnostic and can and should be fixed
>>> in
On Tue, 19 Nov 2024 13:37:25 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
On Wed, 27 Nov 2024 09:11:22 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Fri, 22 Nov 2024 15:08:18 GMT, Sergey Chernyshev
wrote:
> > One thing to note is that the new test requires root privileges (AFAIK). We
> > should skip the test if we are being run as root.
>
> The test works just like other docker tests, root privileges are not
> required. In systems that
On Sat, 23 Nov 2024 10:28:42 GMT, Sergey Chernyshev
wrote:
>>> The added code in `CgroupUtil::adjust_controller` runs for cg v1 and cg v2
>>> when path adjustment is deemed needed. So I'm not clear why it's needed for
>>> cg v2
>>
>> It looks like there's no way to see at this point, if we ar
On Fri, 22 Nov 2024 13:00:14 GMT, Sergey Chernyshev
wrote:
>>> Here, `limit` at line 64 is not stored as a possible lowest limit, so if
>>> the inner group has lower limit than the outer group, it won't be detected
>>> (cg v2 is affected too).
>>
>> Good spot! How about this to fix it?
>>
>>
On Fri, 22 Nov 2024 09:54:39 GMT, Sergey Chernyshev
wrote:
> Here, `limit` at line 64 is not stored as a possible lowest limit, so if the
> inner group has lower limit than the outer group, it won't be detected (cg v2
> is affected too).
Good spot! How about this to fix it?
jlong limit = me
pathname is relative to the mount point of the
>>hierarchy.
>>
>>
>> This explicitly states the "pathname is relative t...
>
> Sergey Chernyshev has updated the pull request with a new target base due to
> a merge or a rebase. The incremen
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated the
On Tue, 12 Nov 2024 14:59:41 GMT, Sergey Chernyshev
wrote:
> > The JBS issue doesn't mention `NullPointerException`. It would be good to
> > list the observed NPE issue.
>
> Example for NPE:
>
> ```
> public class Test {
> public static void main(String[] args) {
> java.lang.manag
On Thu, 7 Nov 2024 22:31:21 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> system
On Tue, 12 Nov 2024 19:09:54 GMT, Sergey Chernyshev
wrote:
> > Edit: Yet, cg v2 will get into trouble since there, for example on rootless
> > podman on cg v2 you'd end up with this instead:
> > ```
> > [0.008s][trace][os,container] OSContainer::init: Initializing Container
> > Support
> > [0.
On Mon, 11 Nov 2024 18:28:11 GMT, Sergey Chernyshev
wrote:
> > So on cg v1 you start out and end with a `subsystem_path() == null` and on
> > cg v2 you start out and end with a `subsystem_path() ==
> > /../../../../../../test`. In both cases the memory limit of 400m won't be
> > detected.
>
On Thu, 7 Nov 2024 22:31:21 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> system
On Mon, 11 Nov 2024 10:20:02 GMT, Severin Gehwolf wrote:
> > In the above script, a containerized process (/bin/sh) is moved to cgroup
> > /test before /jdk/bin/java gets executed. Java inherits cgroup /test from
> > its parent process, its _root will be /docker/, cgroup
On Thu, 7 Nov 2024 13:28:29 GMT, Sergey Chernyshev
wrote:
> Create a new cgroup for memory
>
> ```
> sudo mkdir -p /sys/fs/cgroup/memory/test
> ```
>
> Run the following script
>
> ```
> docker run --tty=true --rm --volume=$JAVA_HOME:/jdk --memory 400m
> ubuntu:latest \
> sh -c "sleep 10
On Mon, 11 Nov 2024 10:06:11 GMT, Severin Gehwolf wrote:
> > I didn't check cg v2 because the issue (NPE) was observed in v1 hosts only.
>
> The JBS issue doesn't mention `NullPointerException`. It would be good to
> list the observed NPE issue.
I also wonder, the
On Fri, 8 Nov 2024 16:11:37 GMT, Sergey Chernyshev
wrote:
> I didn't check cg v2 because the issue (NPE) was observed in v1 hosts only.
The JBS issue doesn't mention `NullPointerException`. It would be good to list
the observed NPE issue.
-
PR Comment: https://git.openjdk.org/jdk
On Thu, 7 Nov 2024 22:31:21 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> system
On Fri, 1 Nov 2024 13:13:07 GMT, Sergey Chernyshev
wrote:
> As they're in fact mounting read-write, the logic picked up `rw` mount option
> and falsely detected "host mode". Also the `--privileged` creates `rw`
> mounts, so the entire approach needs correction.
Yes. See https://bugs.openjdk.o
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated the
On Thu, 31 Oct 2024 15:00:25 GMT, Sergey Chernyshev
wrote:
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
On Tue, 22 Oct 2024 14:18:50 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated the
On Tue, 15 Oct 2024 16:34:40 GMT, Severin Gehwolf wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) descr
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated the
On Thu, 10 Oct 2024 14:27:08 GMT, Ramkumar Sunderbabu
wrote:
>> The System property "docker.support" defined in VMProps gives a wrong
>> impression that it is tied to docker alone. The property is common for any
>> container runtime. Hence, it needs to be renamed as "container.support".
>>
>>
On Wed, 9 Oct 2024 14:50:30 GMT, Ramkumar Sunderbabu
wrote:
> The System property "docker.support" defined in VMProps gives a wrong
> impression that it is tied to docker alone. The property is common for any
> container runtime. Hence, it needs to be renamed as "container.support".
>
> Posit
On Tue, 1 Oct 2024 16:16:36 GMT, Severin Gehwolf wrote:
> The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) also
> increased test coverage. In particular, the `TestJcmdWithSideCar.java` test
> got enhanced to cover these cases (prior to
> [JDK-83
On Wed, 2 Oct 2024 18:46:07 GMT, Severin Gehwolf wrote:
>> The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114)
>> also increased test coverage. In particular, the `TestJcmdWithSideCar.java`
>> test got enhanced to cover these cases (prior to
>
On Thu, 3 Oct 2024 10:43:56 GMT, Kevin Walls wrote:
>> Severin Gehwolf has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Improve runtime of test"
>>
>>This reverts c
On Tue, 1 Oct 2024 16:56:11 GMT, Kevin Walls wrote:
> I can check our testing with this change...
@kevinjwalls Any update on this? Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/21289#issuecomment-2391044188
On Wed, 2 Oct 2024 21:15:11 GMT, Larry Cable wrote:
>> this is a fix to: https://bugs.openjdk.org/browse/JDK-8327114
>>
>> to resolve an issue detected in:
>>
>> https://bugs.openjdk.org/browse/JDK-8341246
>>
>> /proc/**/* file accesses should be performed as "privileged" actions to
>> avoi
On Thu, 3 Oct 2024 05:27:33 GMT, Sebastian Lövdahl wrote:
> > Filed https://bugs.openjdk.org/browse/JDK-8341436 to track this separate
> > issue.
>
> Do you intend to look into this yourself? If not, I would be happy to pick it
> up.
Please go ahead and have a go at this.
-
PR C
On Wed, 2 Oct 2024 19:59:31 GMT, Larry Cable wrote:
>> this is a fix to: https://bugs.openjdk.org/browse/JDK-8327114
>>
>> to resolve an issue detected in:
>>
>> https://bugs.openjdk.org/browse/JDK-8341246
>>
>> /proc/**/* file accesses should be performed as "privileged" actions to
>> avoi
On Wed, 2 Oct 2024 18:28:11 GMT, Severin Gehwolf wrote:
> > Right, this turned into a rabbit hole of its own.. đ
>
> Thanks. I'll remove this part from the patch as it's orthogonal to the actual
> issue and would just like to get the test passing again.
Filed https:
ghts? Could somebody please run this through Oracle's test system in
> order to see if this fixes the issue? Thank you!
Severin Gehwolf has updated the pull request incrementally with two additional
commits since the last revision:
- Revert "Improve runtime of test"
This r
On Wed, 2 Oct 2024 17:50:44 GMT, Sebastian Lövdahl wrote:
> Right, this turned into a rabbit hole of its own.. đ
Thanks. I'll remove this part from the patch as it's orthogonal to the actual
issue and would just like to get the test passing again.
-
PR Comment: https://git.openjdk
ld: 2.169 seconds
> compile: 2.157 seconds
> build: 4.964 seconds
> compile: 4.963 seconds
> driver: 22.928 seconds
> Test results: passed: 1
>
>
> The actual test skip of the 4th test case is:
> https://github.com/openjdk/jdk/commit/95a7cc05f00e94190af5
On Wed, 2 Oct 2024 12:05:36 GMT, Severin Gehwolf wrote:
> We'll have to do `docker rm -i /test-container-main` before we start a new
> one. I'll fix that later today.
Updated in
https://github.com/openjdk/jdk/pull/21289/commits/ef7abf249268c30f726bee19dde3337d92c6493d
If t
On Wed, 2 Oct 2024 10:23:05 GMT, Sebastian Lövdahl wrote:
> However, when I'm running the test with `docker` with the changes from this
> PR (`make test
> TEST="jtreg:test/hotspot/jtreg/containers/docker/TestJcmdWithSideCar.java"
> JTREG="JAVA_OPTIONS=-Djdk.test.container.command=docker"`) I g
On Tue, 1 Oct 2024 16:16:36 GMT, Severin Gehwolf wrote:
> The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) also
> increased test coverage. In particular, the `TestJcmdWithSideCar.java` test
> got enhanced to cover these cases (prior to
> [JDK-83
On Tue, 1 Oct 2024 16:16:36 GMT, Severin Gehwolf wrote:
> The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) also
> increased test coverage. In particular, the `TestJcmdWithSideCar.java` test
> got enhanced to cover these cases (prior to
> [JDK-83
The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) also
increased test coverage. In particular, the `TestJcmdWithSideCar.java` test got
enhanced to cover these cases (prior to
[JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) only case 1 was
tested):
1. Shared vo
On Tue, 1 Oct 2024 15:38:56 GMT, SendaoYan wrote:
>> Hi all,
>> Test `com/sun/tools/attach/PermissionTest.java` fails access denied after
>> [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114). This testcase
>> need the `readlink` permission of file `/proc/self/ns/mnt` after
>> [JDK-832
On Tue, 1 Oct 2024 07:33:16 GMT, David Holmes wrote:
> We are seeing a number of test failures after this was integrated. Failing
> tests:
>
> * containers/docker/TestJcmdWithSideCar.java
What's the failure?
> * com/sun/tools/attach/PermissionTest.java
>
> I will file bugs, but the p
On Tue, 1 Oct 2024 09:29:20 GMT, Sebastian Lövdahl wrote:
> Is this something that should have failed in GHA checks too?
No. Only tier1 tests run in GHA.
-
PR Comment: https://git.openjdk.org/jdk/pull/19055#issuecomment-2385367053
On Mon, 30 Sep 2024 16:11:27 GMT, SendaoYan wrote:
> Hi all,
> Test `com/sun/tools/attach/PermissionTest.java` fails access denied after
> [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114). This testcase
> need the `readlink` permission of file `/proc/self/ns/mnt` after
> [JDK-8327114
On Mon, 30 Sep 2024 12:03:14 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated
On Sun, 29 Sep 2024 06:23:34 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request with a new target base due to
> a merge or a rebase. The incremental webrev exclu
On Tue, 2 Jul 2024 11:07:56 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Clarify
On Wed, 28 Aug 2024 05:05:58 GMT, Sebastian Lövdahl wrote:
>> Sebastian Lövdahl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clarify PID 1 check with comment
>
> Still waiting for another reviewer.
@slovdahl Could you please merge in
On Tue, 2 Jul 2024 11:07:56 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Clarify
On Wed, 11 Sep 2024 17:52:44 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has upda
On Thu, 5 Sep 2024 13:25:17 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated
On Mon, 29 Jul 2024 14:18:24 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated t
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated
Please review this fix for cgroups-based metrics reporting in the
`jdk.internal.platform` package. This fix is supposed to address wrong
reporting of certain limits if the limits aren't set at the leaf nodes.
For example, on cg v2, the memory limit interface file is `memory.max`.
Consider a cgr
1 - 100 of 197 matches
Mail list logo
