On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this only
>> deals with fixing the placemen
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this only
>> deals with fixing the placemen
On Wed, 23 Nov 2022 07:12:13 GMT, Kim Barrett wrote:
> > I'm not sure why conditional includes (that don't rely on macros.hpp) need
> > to come at the end rather than in normal sort order? I don't care either
> > way but a rationale for this would be good if it is to be the preferred
> > style
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this only
>> deals with fixing the placemen
On Wed, 23 Nov 2022 04:47:11 GMT, David Holmes wrote:
> I'm not sure why conditional includes (that don't rely on macros.hpp) need to
> come at the end rather than in normal sort order? I don't care either way but
> a rationale for this would be good if it is to be the preferred style.
Because
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this only
>> deals with fixing the placemen
On Fri, 11 Nov 2022 21:01:31 GMT, Kim Barrett wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Cleanups
>> - Merge remote-tracking branch 'upstream/master' into
>> various_include
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> One of the more prevalent issues is that files in src/hotspot/share/include
>> are not properly sorted. There
On Mon, 14 Nov 2022 11:39:10 GMT, Kim Barrett wrote:
>> src/hotspot/os/windows/jvm_windows.cpp line 27:
>>
>>> 25: #include "precompiled.hpp"
>>> 26: #include "include/jvm.h"
>>> 27: #include "os_windows.hpp"
>>
>> os_windows should be at the end, included using `OS_HEADER("os")`.
>
> But shoul
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but i
10 matches
Mail list logo
