Re: RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved [v3]

2023-09-12 Thread Andrew Haley
> This PR fixes a specific problem caused by using r29/rfp to unwind Java code. > For some time we have treated r29 as a callee-saved scratch register, and it > is freely used by C2-generated code. Therefore, any code in SA that uses > getFP() in a compiled frame is very likely to come to

Re: RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved [v2]

2023-09-12 Thread Andrew Haley
On Tue, 12 Sep 2023 05:58:28 GMT, Fei Yang wrote: > Neither can I reproduce this issue on linux-riscv64 platform with jdk/jdk > tip. But it has the same settings for the x8/fp register and context, I guess > it also bears the same problem. Yes, I'm sure it does. - PR Comment:

Re: RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved [v2]

2023-09-12 Thread Fei Yang
On Fri, 8 Sep 2023 12:34:39 GMT, Andrew Haley wrote: >> This PR fixes a specific problem caused by using r29/rfp to unwind Java >> code. For some time we have treated r29 as a callee-saved scratch register, >> and it is freely used by C2-generated code. Therefore, any code in SA that >> uses

Re: RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved [v2]

2023-09-11 Thread Chris Plummer
On Thu, 7 Sep 2023 21:34:50 GMT, Chris Plummer wrote: > Overall the changes look good. Have you tested to see if this fixes > [JDK-8276210](https://bugs.openjdk.org/browse/JDK-8276210) and > [JDK-8248675](https://bugs.openjdk.org/browse/JDK-8248675)? You'll need to > remove them from the

Re: RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved [v2]

2023-09-11 Thread Chris Plummer
On Fri, 8 Sep 2023 12:34:39 GMT, Andrew Haley wrote: >> This PR fixes a specific problem caused by using r29/rfp to unwind Java >> code. For some time we have treated r29 as a callee-saved scratch register, >> and it is freely used by C2-generated code. Therefore, any code in SA that >> uses

Re: RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved [v2]

2023-09-08 Thread Andrew Haley
> This PR fixes a specific problem caused by using r29/rfp to unwind Java code. > For some time we have treated r29 as a callee-saved scratch register, and it > is freely used by C2-generated code. Therefore, any code in SA that uses > getFP() in a compiled frame is very likely to come to

Re: RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

2023-09-08 Thread Andrew Haley
On Thu, 7 Sep 2023 21:31:24 GMT, Chris Plummer wrote: >> This PR fixes a specific problem caused by using r29/rfp to unwind Java >> code. For some time we have treated r29 as a callee-saved scratch register, >> and it is freely used by C2-generated code. Therefore, any code in SA that >> uses

Re: RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

2023-09-07 Thread Chris Plummer
On Thu, 7 Sep 2023 16:58:38 GMT, Andrew Haley wrote: > … frame when invoking LambdaForms is involved Overall the changes look good. Have you tested to see if this fixes [JDK-8276210](https://bugs.openjdk.org/browse/JDK-8276210) and [JDK-8248675](https://bugs.openjdk.org/browse/JDK-8248675)?

RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

2023-09-07 Thread Andrew Haley
… frame when invoking LambdaForms is involved - Commit messages: - 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved Changes: https://git.openjdk.org/jdk/pull/15624/files Webrev: