On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 18 Sep 2024 11:42:47 GMT, David Holmes wrote:
> I can't file a bug at present but please attend to this ASAP.
I have filed https://bugs.openjdk.org/browse/JDK-8340368 to track this.
-
PR Comment: https://git.openjdk.org/jdk/pull/20597#issuecomment-2358266461
On Tue, 17 Sep 2024 14:26:00 GMT, Simon Tooke wrote:
>>> Sorry if I'm holding this up. The reasoning did get confusing to me.
>>>
>>> We are not always good at documenting these commands. But at some point,
>>> somebody among us will hopefully document them, or explain it to somebody
>>> who w
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Tue, 17 Sep 2024 09:24:12 GMT, Thomas Stuefe wrote:
>> Sorry if I'm holding this up. The reasoning did get confusing to me.
>>
>> We are not always good at documenting these commands. But at some point,
>> somebody among us will hopefully document them, or explain it to somebody
>> who wi
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Tue, 17 Sep 2024 13:17:49 GMT, Kevin Walls wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove trailing whitespace
>
> Thanks Thomas -
> It's understood what the info is, main question was when is it useful,
On Tue, 17 Sep 2024 09:24:12 GMT, Thomas Stuefe wrote:
>> Sorry if I'm holding this up. The reasoning did get confusing to me.
>>
>> We are not always good at documenting these commands. But at some point,
>> somebody among us will hopefully document them, or explain it to somebody
>> who wi
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Mon, 16 Sep 2024 20:36:11 GMT, Kevin Walls wrote:
> Sorry if I'm holding this up. The reasoning did get confusing to me.
>
> We are not always good at documenting these commands. But at some point,
> somebody among us will hopefully document them, or explain it to somebody who
> will. There
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 23:57:11 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes per review
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1196:
>
>> 1194: void SystemDumpMapDCmd::e
On Thu, 12 Sep 2024 16:01:52 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove calls to fatal(), remove segment lengt output
>> - use nullptr insted of NULL
>
> src/hotspot/os/wind
On Thu, 12 Sep 2024 19:43:53 GMT, Kevin Walls wrote:
>> Hello @kevinjwalls , and thank you for your review! I have attempted to
>> address your concerns with my use of 'fatal()' by replacing with a message
>> in the returned output and an assert().
>>
>> I have also adjusted the spacing of th
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Thu, 12 Sep 2024 15:34:47 GMT, Simon Tooke wrote:
> concerns with my use of 'fatal()' by replacing with a message in the returned
> output and an assert().
>
> I have also adjusted the spacing of the offset field in the output, but kept
> it for parity with the Linux version.
Thanks @stook
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Thu, 12 Sep 2024 14:04:54 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 14:57:08 GMT, Kevin Walls wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes per review
>
> Hi,
> Great to bring up a Windows version of this.
>
> Is the offset column useful?
> It tells us
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 14:49:50 GMT, Simon Tooke wrote:
>
> I agree, and will probably do this next week. If it looks good to you, could
> you please mark as reviewed? You're on the list of reviewers.
FYI, I filed [JDK-8339970](https://bugs.openjdk.org/browse/JDK-8339970) to
track this.
---
On Wed, 11 Sep 2024 17:26:15 GMT, Thomas Stuefe wrote:
>> I was thinking about this - my original intent was to be fatal only on a
>> debug build, not release. I have added a message in the output, and changed
>> these to warnings (for both release and debug)
>
> I would prefer an assert here.
On Wed, 11 Sep 2024 17:23:11 GMT, Simon Tooke wrote:
>> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>>
>>> 96: out.put('r');
>>> 97: } else {
>>> 98: fatal("Unknown Windows memory state value: 0x%x", mem_info.State);
>>
>> Are these really fatal? We don't want to
On Wed, 11 Sep 2024 14:59:52 GMT, Kevin Walls wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes per review
>
> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>
>> 96: out.put('r');
>> 97:
On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 14:12:48 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - prevent VM crash on invalid jcmd
>> - changes from review
>
> src/hotspot/share/services/diagnosticCommand.cpp line
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Wed, 11 Sep 2024 14:13:37 GMT, Sonia Zaldana Calles
wrote:
> Hi Simon,
>
> Thanks! Looks good.
>
> Just had a question about the empty filename issue. I don’t think there is a
> case where a filename parameter should accept an empty string (but I might be
> wrong).
>
> If that’s the case
On Wed, 11 Sep 2024 13:32:49 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 13:32:49 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Tue, 10 Sep 2024 15:09:03 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix overly restrictive test
>
> I am not a Reviewer but this looks mostly good to me.
@SoniaZaldana thank you
On Tue, 10 Sep 2024 15:03:41 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix overly restrictive test
>
> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>
>> 96: out.p
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Tue, 27 Aug 2024 22:58:52 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Tue, 27 Aug 2024 22:58:52 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Thu, 22 Aug 2024 16:28:19 GMT, Simon Tooke wrote:
>> src/hotspot/os/windows/memMapPrinter_windows.cpp line 162:
>>
>>> 160: outputStream* st = session.out();
>>> 161: os::print_os_info(st);
>>> 162: os::print_memory_info(st);
>>
>> The "danger" here is that both of these function
On Thu, 22 Aug 2024 16:30:56 GMT, Simon Tooke wrote:
>> But (here and in other places) raw-printing the unknown constant may not be
>> the best way. Chances are this code is executed rarely and most people will
>> just be perplexed at the weird printouts.
>>
>> We could assert here: After all,
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Thu, 22 Aug 2024 15:59:25 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Thu, 22 Aug 2024 16:26:12 GMT, Simon Tooke wrote:
>> I agree, and was surprised this wasn't originally implemented. I'll prepare
>> a second PR.
>
> I have filed issue [#8338851](https://bugs.openjdk.org/browse/JDK-8338851)
> "Hoist os::Posix::realpath() to os::realpath() and implement on W
On Tue, 20 Aug 2024 07:05:54 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix test failure
>> - enabled TestJcmdPIDSubstitution.java test for Windows
>
> src/hotspot/os/windows/memMapPrinter
On Wed, 21 Aug 2024 12:32:00 GMT, Simon Tooke wrote:
>> src/hotspot/share/services/diagnosticCommand.cpp line 1207:
>>
>>> 1205: const char* absname = os::Posix::realpath(name, tmp, sizeof(tmp));
>>> 1206: name = absname != nullptr ? absname : name;
>>> 1207: #endif
>>
>> I wince a bit
On Tue, 20 Aug 2024 07:14:18 GMT, Thomas Stuefe wrote:
>> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>>
>>> 96: buffer[idx++] = 'n';
>>> 97: } else if (prot != 0) {
>>> 98: snprintf(buffer, bufsiz, "(0x%x)", prot);
>>
>> This could truncate for the
On Thu, 22 Aug 2024 08:47:32 GMT, Thomas Stuefe wrote:
> > I think `test/jdk/sun/tools/jcmd/TestJcmdPIDSubstitution.java` should be
> > updated to allow System.dump_map on Windows, not just linux.
> > [6733b89](https://github.com/openjdk/jdk/commit/6733b89de1ed9ebcc1e8a8271970048ad0f0aac3)
>
>
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Wed, 21 Aug 2024 14:54:40 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 21 Aug 2024 14:54:40 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 21 Aug 2024 14:54:40 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Tue, 20 Aug 2024 06:06:39 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from tstuefe review
>
> src/hotspot/os/windows/memMapPrinter_windows.cpp line 3:
>
>> 1: /*
>> 2: * Copyright
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Tue, 20 Aug 2024 06:36:26 GMT, Thomas Stuefe wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most o
On Thu, 15 Aug 2024 13:45:16 GMT, Simon Tooke wrote:
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the h
This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
Windows.
System.map and System.dump_map are implemented using the Windows API and
provide roughly the same information in the same format. Most of the heavy
lifting was implemented by @tstuefe in #16301 - this PR add
63 matches
Mail list logo
