Re: RFR: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS [v2]

2023-12-04 Thread David Holmes
On Mon, 4 Dec 2023 12:35:42 GMT, Alan Bateman wrote: >> Thanks for looking at this @AlanBateman and @sspitsyn . I was trying to >> refer to the JNI text in a casual way rather than duplicating the actual >> content from there. This was more a strong hint/suggestion to "go read the >> JNI spec

Re: RFR: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS [v2]

2023-12-04 Thread Alan Bateman
On Mon, 4 Dec 2023 04:43:46 GMT, David Holmes wrote: >> src/hotspot/share/prims/jvmti.xml line 746: >> >>> 744: JNI_CreateJavaVM (in the JNI Invocation API) will >>> prepend these options to the options supplied >>> 745: in its JavaVMInitArgs argument. Note that module >>> related opti

Re: RFR: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS [v2]

2023-12-03 Thread David Holmes
> Please review this simple clarification to the JVM TI spec regarding use of > `JAVA_TOOL_OPTIONS` in regards to module options and their format. > > I do not believe this clarification needs a CSR request. > > Thanks. David Holmes has updated the pull request with a new target base due to a m