Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-17 Thread Johannes Bechberger
On Tue, 17 Oct 2023 21:37:05 GMT, Chris Plummer wrote: >> Yes, so the current way is probably ok? >> >> IDEs like IntelliJ properly handle the exception event that is sent and >> don't report an error, so I don't see a problem. > >> On the other hand, I think if the debug agent requires that a

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-17 Thread Chris Plummer
On Tue, 17 Oct 2023 20:41:10 GMT, Johannes Bechberger wrote: >> It seems that ex.request()) is null for this event. The spec for >> Event.request() says null might happen for VMDeath events, but doesn't >> mention any other. In any case, I guess JDI does not filter out any events >> for which

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-17 Thread Johannes Bechberger
On Tue, 17 Oct 2023 20:32:52 GMT, Chris Plummer wrote: >> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 76: >> >>> 74: while(eventIterator.hasNext() && start + TIMEOUT > >>> System.currentTimeMillis()) { >>> 75: Event event = eventIterator.next(); >>

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-17 Thread Chris Plummer
On Tue, 17 Oct 2023 20:16:18 GMT, Chris Plummer wrote: >> Johannes Bechberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed event location > > test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 76: > >> 74: while

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-17 Thread Chris Plummer
On Mon, 16 Oct 2023 19:07:37 GMT, Johannes Bechberger wrote: >> Fix `onthrow` issue by passing the event info to the `initialize` method. >> >> This prevents `jdb` from receiving a broken exception event and throwing an >> internal NullPointerException, upon attaching to the JDWP-agent. > > Jo

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-16 Thread Chris Plummer
On Mon, 16 Oct 2023 19:07:37 GMT, Johannes Bechberger wrote: >> Fix `onthrow` issue by passing the event info to the `initialize` method. >> >> This prevents `jdb` from receiving a broken exception event and throwing an >> internal NullPointerException, upon attaching to the JDWP-agent. > > Jo

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-16 Thread Johannes Bechberger
> Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. Johannes Bechberger has updated the pull request incrementally with one