On Tue, 11 Apr 2023 17:51:39 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 11 Apr 2023 17:51:39 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
> The TestScaffold incorrectly parse options, it should insert wrapper class
> between VM options and applications classame.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
Updated comments
-
Changes:
- all: https://
On Tue, 11 Apr 2023 16:55:42 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
> The TestScaffold incorrectly parse options, it should insert wrapper class
> between VM options and applications classame.
Leonid Mesnik has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains eight commits:
- updated after David's commen
On Fri, 7 Apr 2023 19:01:34 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
> The TestScaffold incorrectly parse options, it should insert wrapper class
> between VM options and applications classame.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
updated parsing.
-
Changes:
- all: https://
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 28 Mar 2023 04:27:40 GMT, David Holmes wrote:
>> the @run line contains only the test name and additional command-line
>> options if needed, the target app class 'Frames2Targ' is not included. I
>> have copy-pasted this example from
>> https://github.com/openjdk/jdk/blob/0deb648985b018
On Mon, 27 Mar 2023 18:25:52 GMT, Leonid Mesnik wrote:
> > Isn't the `-Xss4M` supposed to be passed as `-J-Xss4M`? That is what the
> > original logic is expecting.
>
> I haven't seen that -J-.. is used here in the args, all tests just use vm
> flags directly. I am not sure if updating tests i
On Mon, 27 Mar 2023 18:02:05 GMT, Leonid Mesnik wrote:
>> In that case did you mean:
>>
>> '@run driver Frames2Test -Xss4M Frames2Targ'
>>
>> ?
>
> the @run line contains only the test name and additional command-line options
> if needed, the target app class 'Frames2Targ' is not included. I h
On Mon, 27 Mar 2023 05:55:52 GMT, David Holmes wrote:
> Isn't the `-Xss4M` supposed to be passed as `-J-Xss4M`? That is what the
> original logic is expecting.
I haven't seen that -J-.. is used here in the args, all tests just use vm flags
directly. I am not sure if updating tests is the corre
On Mon, 27 Mar 2023 05:51:11 GMT, David Holmes wrote:
>> Frames2Test is the name of test that uses additional command-line options.
>> It is an example.
>
> In that case did you mean:
>
> '@run driver Frames2Test -Xss4M Frames2Targ'
>
> ?
the @run line contains only the test name and addition
On Mon, 27 Mar 2023 05:42:12 GMT, Leonid Mesnik wrote:
>> test/jdk/com/sun/jdi/TestScaffold.java line 469:
>>
>>> 467: // the first argument not-starting with '-' is treated as a
>>> classname
>>> 468: // the other arguments are split to targetVMArgs
>>> targetAppCommandLine co
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 27 Mar 2023 05:09:55 GMT, David Holmes wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added comments and trim arguments
>
> test/jdk/com/sun/jdi/TestScaffold.java line 469:
>
>> 467: // the first
On Fri, 24 Mar 2023 06:27:02 GMT, Leonid Mesnik wrote:
> The problem was that wrapper inserted it's arguments before vm options
> because didn't expect them in the args.
Sorry still not sure what you mean by that. Do you mean the `--enable-preview`
arg? That was appended to VM args:
argInfo.t
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
> The TestScaffold incorrectly parse options, it should insert wrapper class
> between VM options and applications classame.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
added comments and trim arguments
-
Changes:
On Thu, 23 Mar 2023 21:49:55 GMT, Leonid Mesnik wrote:
> The TestScaffold incorrectly parse options, it should insert wrapper class
> between VM options and applications classame.
I've added comment with example from one of tests and expected result of
parsing.
The problem was that wrapper ins
On Thu, 23 Mar 2023 21:49:55 GMT, Leonid Mesnik wrote:
> The TestScaffold incorrectly parse options, it should insert wrapper class
> between VM options and applications classame.
Sorry I'm struggling a bit to see where the current parsing logic is failing.
Can you given an example of a comman
26 matches
Mail list logo
