Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-18 Thread Chris Plummer
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-18 Thread Paul Hohensee
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-18 Thread Chris Plummer
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-18 Thread Paul Hohensee
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-13 Thread Chris Plummer
On Wed, 13 Dec 2023 20:51:36 GMT, Dean Long wrote: > The man page says "no default value" but then right below describes the > default value, which is confusing. I would remove "no default value". This was copied from VM.cds, which pretty much does the same thing (says "no default value" and t

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-13 Thread Dean Long
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-12 Thread Evgeny Astigeevich
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-11 Thread Yi-Fan Tsai
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an optional argument for specifying a > file name. > > `jcmd PID help Compiler.perfmap` shows the following usage. > > > Compiler.perfmap > Write map file for Linux perf tool. > > Im

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v7]

2023-12-11 Thread Chris Plummer
On Thu, 7 Dec 2023 22:49:55 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v7]

2023-12-07 Thread Yi-Fan Tsai
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an optional argument for specifying a > file name. > > `jcmd PID help Compiler.perfmap` shows the following usage. > > > Compiler.perfmap > Write map file for Linux perf tool. > > Im

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v5]

2023-12-07 Thread Evgeny Astigeevich
On Tue, 5 Dec 2023 20:13:11 GMT, Chris Plummer wrote: >> Hi Chris, >> The current design of `write_perf_map` provides a clean and explicit >> interface. The purpose of the function is evident from its signature: to >> write a perf map into a specified file. This explicitness makes the code >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v5]

2023-12-05 Thread Chris Plummer
On Tue, 5 Dec 2023 16:14:31 GMT, Evgeny Astigeevich wrote: >> src/hotspot/share/code/codeCache.cpp line 1809: >> >>> 1807: } >>> 1808: >>> 1809: void CodeCache::write_perf_map(const char* filename) { >> >> Why not have a `filename == nullptr` indicate that the default should be >> used. Then

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v5]

2023-12-05 Thread Evgeny Astigeevich
On Fri, 1 Dec 2023 21:25:19 GMT, Chris Plummer wrote: >> Yi-Fan Tsai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply man changes > > src/hotspot/share/code/codeCache.cpp line 1809: > >> 1807: } >> 1808: >> 1809: void CodeCache::w

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v6]

2023-12-01 Thread Yi-Fan Tsai
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an optional argument for specifying a > file name. > > `jcmd PID help Compiler.perfmap` shows the following usage. > > > Compiler.perfmap > Write map file for Linux perf tool. > > Im

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v5]

2023-12-01 Thread Chris Plummer
On Tue, 28 Nov 2023 23:25:27 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v5]

2023-12-01 Thread Chris Plummer
On Tue, 28 Nov 2023 23:25:27 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v5]

2023-11-29 Thread David Holmes
On Tue, 28 Nov 2023 23:25:27 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >> >>

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v5]

2023-11-28 Thread Yi-Fan Tsai
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an optional argument for specifying a > file name. > > `jcmd PID help Compiler.perfmap` shows the following usage. > > > Compiler.perfmap > Write map file for Linux perf tool. > > Im

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v4]

2023-11-28 Thread Chris Plummer
On Tue, 21 Nov 2023 20:42:47 GMT, Chris Plummer wrote: >> src/jdk.jcmd/share/man/jcmd.1 line 1: >> >>> 1: .\" Copyright (c) 2012, 2023, Oracle and/or its affiliates. All rights >>> reserved. >> >> The actual markdown source for this file needs to be updated with these >> changes. Those source

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v4]

2023-11-27 Thread Yi-Fan Tsai
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an optional argument for specifying a > file name. > > `jcmd PID help Compiler.perfmap` shows the following usage. > > > Compiler.perfmap > Write map file for Linux perf tool. > > Im

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v3]

2023-11-21 Thread Yi-Fan Tsai
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an option for specifying a file name. > > The help message of `jcmd PID help Compiler.perfmap` will be updated in a > separate PR. Yi-Fan Tsai has updated the pull request incrementall

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v2]

2023-11-21 Thread Yi-Fan Tsai
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an option for specifying a file name. > > The help message of `jcmd PID help Compiler.perfmap` will be updated in a > separate PR. Yi-Fan Tsai has updated the pull request incrementall

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap

2023-11-21 Thread Chris Plummer
On Thu, 21 Sep 2023 20:43:56 GMT, Yi-Fan Tsai wrote: > `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an option for specifying a file name. > > The help message of Compiler.perfmap: > > Compiler.perfmap > Write map file for Linux pe

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap

2023-11-21 Thread Chris Plummer
On Fri, 22 Sep 2023 02:48:57 GMT, David Holmes wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an option for specifying a file name. >> >> The help message of Compiler.perfmap: >> >> Compiler.perfmap >> Write map file for

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap

2023-09-22 Thread Evgeny Astigeevich
On Thu, 21 Sep 2023 20:43:56 GMT, Yi-Fan Tsai wrote: > `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an option for specifying a file name. > > The help message of Compiler.perfmap: > > Compiler.perfmap > Write map file for Linux pe

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap

2023-09-21 Thread David Holmes
On Thu, 21 Sep 2023 20:43:56 GMT, Yi-Fan Tsai wrote: > `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an option for specifying a file name. > > The help message of Compiler.perfmap: > > Compiler.perfmap > Write map file for Linux pe