Re: RFR: 8165827: Support private interface methods in JNI, JDWP, JDI and JDB

2016-10-18 Thread serguei.spit...@oracle.com
David, It looks good. Thanks, Serguei On 10/17/16 20:59, David Holmes wrote: Hi Lois, Dan, Serguei, Went to push this today and realized I had left off the updated JNI method lookup tests. As I said in the bug report JNI behaves as expected, but there weren't any testcases so I added them:

Re: RFR: 8165827: Support private interface methods in JNI, JDWP, JDI and JDB

2016-10-18 Thread David Holmes
Thanks Serguei! David On 18/10/2016 5:10 PM, serguei.spit...@oracle.com wrote: David, It looks good. Thanks, Serguei On 10/17/16 20:59, David Holmes wrote: Hi Lois, Dan, Serguei, Went to push this today and realized I had left off the updated JNI method lookup tests. As I said in the bug

Re: RFR: 8166289: RuntimeException: canRead() reports false for reading from the same module: expected true, was false

2016-10-18 Thread serguei.spit...@oracle.com
Hi Alexander, The fix looks good to me. In a case the bug is reproduced again we will have some details (module name and ID) to understand what is wrong. Thanks, Serguei On 10/17/16 06:08, Alexander Kulyakhtin wrote: Hi, Could you, please, review these test-only changes CR: https://bugs.

Re: RFR: 8166289: RuntimeException: canRead() reports false for reading from the same module: expected true, was false

2016-10-18 Thread Alexander Kulyakhtin
Hi Sergey, Thank you very much for the review. Best regards, Alexander - Original Message - From: serguei.spit...@oracle.com To: alexander.kulyakh...@oracle.com, serviceability-dev@openjdk.java.net Sent: Tuesday, October 18, 2016 10:31:40 AM GMT +03:00 Iraq Subject: Re: RFR: 8166289: Run

Re: RFR: 8165827: Support private interface methods in JNI, JDWP, JDI and JDB

2016-10-18 Thread Lois Foltan
Looks good David! Lois On 10/17/2016 11:59 PM, David Holmes wrote: Hi Lois, Dan, Serguei, Went to push this today and realized I had left off the updated JNI method lookup tests. As I said in the bug report JNI behaves as expected, but there weren't any testcases so I added them: http://cr.

Re: RFR: 8165827: Support private interface methods in JNI, JDWP, JDI and JDB

2016-10-18 Thread Daniel D. Daugherty
On 10/17/16 9:59 PM, David Holmes wrote: Hi Lois, Dan, Serguei, Went to push this today and realized I had left off the updated JNI method lookup tests. As I said in the bug report JNI behaves as expected, but there weren't any testcases so I added them: http://cr.openjdk.java.net/~dholmes/8

Re: RFR: 8165827: Support private interface methods in JNI, JDWP, JDI and JDB

2016-10-18 Thread David Holmes
Thanks Lois! David On 18/10/2016 10:06 PM, Lois Foltan wrote: Looks good David! Lois On 10/17/2016 11:59 PM, David Holmes wrote: Hi Lois, Dan, Serguei, Went to push this today and realized I had left off the updated JNI method lookup tests. As I said in the bug report JNI behaves as expected

Re: RFR: 8165827: Support private interface methods in JNI, JDWP, JDI and JDB

2016-10-18 Thread David Holmes
On 19/10/2016 12:27 AM, Daniel D. Daugherty wrote: On 10/17/16 9:59 PM, David Holmes wrote: Hi Lois, Dan, Serguei, Went to push this today and realized I had left off the updated JNI method lookup tests. As I said in the bug report JNI behaves as expected, but there weren't any testcases so I a