Re: [10] RFR 8181647: jhsdb jstack could not output thread name

Hi chihiro, getThreadState() in OSThread.java: +} else if (val == BREAKPOINTED) { +return ThreadState.BREAKPOINTED; +} else if (val == BREAKPOINTED) { +return ThreadState.BREAKPOINTED; These conditions are duplicated. Please upload webrev if you

Re: [10] RFR 8181647: jhsdb jstack could not output thread name

Hi all, In last week, I've posted review request [1]. Could you possibly review for this following small change? If review is ok, please commit this as cito. [1] http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-June/021430.html Thanks, Chihiro (Contributer) On 2017/06/18

RE: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

Hi Thomas, thanks for your review! > com/sun/tools/jdi/InvokableTypeImpl.java: > > import com.sun.jdi.VMCannotBeModifiedException; ?Why do we need to > import this type, we do not seem to use it? This is needed for the documentation, see line 97, the throws documentation. >

Re: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

Hi Christoph, On Wed, Jun 28, 2017 at 4:47 PM, Langer, Christoph wrote: > Hi Thomas, > > thanks for your review! > > > com/sun/tools/jdi/InvokableTypeImpl.java: > > > > import com.sun.jdi.VMCannotBeModifiedException; ?Why do we need to > > import this type, we do

Re: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

Hi Christoph, Thanks for the cleanup! Here some minor remarks (like Serguei, I did not check the expanded imports). --- com/sun/tools/jdi/InvokableTypeImpl.java: import com.sun.jdi.VMCannotBeModifiedException; ?Why do we need to import this type, we do not seem to use it? ---

RE: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

Hi Serguei, thanks for the review. The reordering of the imports was done by my Eclipse tooling. And as it builds (and also jtreg did not show a regression (on Windows)), I would suspect it is ok. Best regards Christoph From: serguei.spit...@oracle.com [mailto:serguei.spit...@oracle.com]

Re: Low-Overhead Heap Profiling

Hi, On 06/21/2017 10:45 PM, JC Beyler wrote: Hi all, First off: Thanks again to Robbin and Thomas for their reviews :) Next, I've uploaded a new webrev: http://cr.openjdk.java.net/~rasbold/8171119/webrev.06/ Here is an update: - @Robbin, I forgot to say that yes I need to look at

Re: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

On 6/28/17 01:43, Langer, Christoph wrote: Hi Serguei,   thanks for the review. The reordering of the imports was done by my Eclipse tooling. And as it builds (and also jtreg did not show a

Re: Low-Overhead Heap Profiling

Hi JC, Please, find more comments below. On 6/27/17 21:26, serguei.spit...@oracle.com wrote: Hi JC, Sorry for a latency in reply. I'm going to a 4-week vacation. But I'll try to help you