Re: RFR 8193150: Create a jtreg version of the test from JDK-8187143

2018-02-08 Thread serguei.spit...@oracle.com
Hi Paru, +1 Thanks, Serguei On 2/8/18 15:36, Chris Plummer wrote: Hi Paru, Looks good. Thanks for the changes. Chris On 2/8/18 2:50 PM, Paru Somashekar wrote: I have incorporated all your feedback and created a new webrev at : http://cr.openjdk.java.net/~psomashe/8193150/webrev.01/

Re: RFR 8193150: Create a jtreg version of the test from JDK-8187143

2018-02-08 Thread Paru Somashekar
Thanks Chris and Serguei for the review. thanks, Paru. On 2/8/18, 4:49 PM, serguei.spit...@oracle.com wrote: Hi Paru, +1 Thanks, Serguei On 2/8/18 15:36, Chris Plummer wrote: Hi Paru, Looks good. Thanks for the changes. Chris On 2/8/18 2:50 PM, Paru Somashekar wrote: I have

Re: RFR 8193150: Create a jtreg version of the test from JDK-8187143

2018-02-08 Thread Chris Plummer
Hi Paru, Looks good. Thanks for the changes. Chris On 2/8/18 2:50 PM, Paru Somashekar wrote: I have incorporated all your feedback and created a new webrev at : http://cr.openjdk.java.net/~psomashe/8193150/webrev.01/ - Added

Re: RFR: JDK-8187498: Add a -Xmanagement flag as syntactic sugar for -Dcom.sun.management.jmxremote.* properties

2018-02-08 Thread mandy chung
On 2/7/18 1:19 AM, Harsha Wardhana B wrote: --start-management-agent will not be recognized in the current format and hence will not default to --start-management-agent=local=true. `--start-local-management-server` is one option as Alan suggests. Another option is to make

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-02-08 Thread Jini George
Thank you very much, David and Serguei for the review. David, based on your comments, I took a relook at the fix and I have modified it. Since this is an object array klass, the search for the method needs to be done among the methods of the superclass (java.lang.Object). The modified webrev

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-02-08 Thread David Holmes
Hi Jini, On 8/02/2018 6:59 PM, Jini George wrote: Thank you very much, David and Serguei for the review. David, based on your comments, I took a relook at the fix and I have modified it. Since this is an object array klass, the search for the method needs to be done among the methods of the

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-02-08 Thread Jini George
Thank you, David! - Jini. On 2/9/2018 9:18 AM, David Holmes wrote: Hi Jini, On 8/02/2018 6:59 PM, Jini George wrote: Thank you very much, David and Serguei for the review. David, based on your comments, I took a relook at the fix and I have modified it. Since this is an object array klass,

Re: RFR: 8041626: [Event Request] Shutdown reason

2018-02-08 Thread David Holmes
Hi Robin, On 9/02/2018 1:50 AM, Robin Westberg wrote: Hi David, On 8 Feb 2018, at 04:28, David Holmes wrote: Hi Robin, Adding in hotspot-runtime-dev as all the hotspot changes belong to runtime. Thanks, sorry about that.. I had an initial look through this. To

Re: RFR 8193150: Create a jtreg version of the test from JDK-8187143

2018-02-08 Thread Paru Somashekar
I have incorporated all your feedback and created a new webrev at : http://cr.openjdk.java.net/~psomashe/8193150/webrev.01/ - Added comments - modified the logic for failReason and breakpoint reached aspect on the debugger side.

RE: Issue with 8192897: NPE occurs on clhsdb jstack

2018-02-08 Thread stewartd . qdt
Yes, this is consistently reproducible on my system. I'm happy to provide more information if it will help. If I knew more about how the Java stack worked, I could do more of this debugging myself. Is it ever legal to have a Method pointer of null? Daniel -Original Message- From: Jini

Re: RFR: 8041626: [Event Request] Shutdown reason

2018-02-08 Thread Robin Westberg
Hi David, > On 8 Feb 2018, at 04:28, David Holmes wrote: > > Hi Robin, > > Adding in hotspot-runtime-dev as all the hotspot changes belong to runtime. Thanks, sorry about that.. > I had an initial look through this. > > To be honest I don't like it. We seem to have