Re: RFR: 8199323: hsdis could not be loaded which are located on long path

Looks fine to me. Just need a second review. And if you use the new submit-hs repo [1] to do pre-push testing you can push this yourself. Thanks, David [1] http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030656.html On 13/03/2018 12:25 AM, Yasumasa Suenaga wrote: Hi David,

Re: RFR: 8199323: hsdis could not be loaded which are located on long path

Thanks David! I've run test on submit-hs repo, but I received 1 failure: mach5-one-ysuenaga-JDK-8199323-20180313-0429-14193 java/lang/invoke/condy/CondyInterfaceWithOverpassMethods.java windows-x64 Error: failed to clean up files after test I guess the failure does not relate

Re: RFR: 8199323: hsdis could not be loaded which are located on long path

Thanks Thomas! I did not understand cause of failure in CondyInterfaceWithOverpassMethods.java. Can you share Mach5 report? I want to know I can push this change now. Yasumasa 2018-03-13 17:34 GMT+09:00 Thomas Stüfe : > Hi Yasumasa, > looks fine to me too. Thank you

Re: RFR: 8199323: hsdis could not be loaded which are located on long path

Hi Yasumasa, looks fine to me too. Thank you for fixing. Like David, not a big fan of the array allocation on the stack, but it will probably be okay. Lets hope noone changes JVM_MAXPATHLEN. Best Regards, Thomas On Tue, Mar 13, 2018 at 8:38 AM, David Holmes wrote: >

Re: RFR: 8199323: hsdis could not be loaded which are located on long path

Hi Yasumasa, On Tue, Mar 13, 2018 at 9:49 AM, Yasumasa Suenaga wrote: > Thanks Thomas! > > I did not understand cause of failure in CondyInterfaceWithOverpassMeth > ods.java. > Can you share Mach5 report? > > Sorry, unfortunately no. I'm a reviewer, but not from Oracle :)

Re: RFR: 8199323: hsdis could not be loaded which are located on long path

On 13/03/2018 6:26 PM, Yasumasa Suenaga wrote: Thanks David! I've run test on submit-hs repo, but I received 1 failure: mach5-one-ysuenaga-JDK-8199323-20180313-0429-14193 java/lang/invoke/condy/CondyInterfaceWithOverpassMethods.java windows-x64 Error: failed to clean up files after

RFR: 8049695: nsk/jdb/options/connect/connect003 fails with "Launched jdb could not attach to debuggee during 300000 milliseconds"

Hi all, Please review a small fix for https://bugs.openjdk.java.net/browse/JDK-8049695 webrev: http://cr.openjdk.java.net/~amenkov/shmem_long_name/webrev_open/ Root cause of the issue is jbd hungs as a result of the buffer overflow. In the beginning of the shmemBase.c: #define MAX_IPC_PREFIX

Re: RFR: Two line change in documentation

Hi Jc, Yes, these are typos. Thank you for fixing them! Is it a formal review request (RFR) ? If so, then a bug number is needed. I've filed one:   https://bugs.openjdk.java.net/browse/JDK-8199561 The fix looks good. I think, this can be fixed under a trivial fix rule with just one review.

RFR 8166642: serviceability/dcmd/framework/* timeout

Please review the changes that fix intermittent timeout failure of serviceability/dcmd/framework/* tests. The problem here is that these tests invoke jcmd in different ways and one of such ways is when a main class is passed to the jcmd as a VM identifier. The main class for jtreg test is

Re: RFR 8166642: serviceability/dcmd/framework/* timeout

Hi Daniil, On 14/03/2018 3:26 PM, Daniil Titov wrote: Please review the changes that fix intermittent timeout failure of serviceability/dcmd/framework/* tests. The problem here is that these tests invoke jcmd in different ways and one of such ways is when a main class is passed to the jcmd

Re: RFR 8166642: serviceability/dcmd/framework/* timeout

Hi Danill, The fix looks good. Were you able to reproduce this problem, and then after the fix run the tests enough times to be confident this really resolves the issue? Are you going to close JDK-8194057 as a dup? thanks, Chris On 3/13/18 10:26 PM, Daniil Titov wrote: Please review the

Re: RFR: 8049695: nsk/jdb/options/connect/connect003 fails with "Launched jdb could not attach to debuggee during 300000 milliseconds"

Hi Alex, On 14/03/2018 9:14 AM, Alex Menkov wrote: Hi all, Please review a small fix for https://bugs.openjdk.java.net/browse/JDK-8049695 webrev: http://cr.openjdk.java.net/~amenkov/shmem_long_name/webrev_open/ Root cause of the issue is jbd hungs as a result of the buffer overflow. In the

Re: RFR: Two line change in documentation

On 14/03/2018 7:32 AM, serguei.spit...@oracle.com wrote: Hi Jc, Yes, these are typos. Thank you for fixing them! Is it a formal review request (RFR) ? If so, then a bug number is needed. I've filed one:   https://bugs.openjdk.java.net/browse/JDK-8199561 The fix looks good. I think, this can