Re: RFR (S) 8205643: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java fails

2018-07-10 Thread Alex Menkov
Hi JC, you need also to remove the test from ProblemList --alex On 07/10/2018 11:41, JC Beyler wrote: Hi All, Could someone review the one liner for the bug: https://bugs.openjdk.java.net/browse/JDK-8205643 The webrev is here: http://cr.openjdk.java.net/~jcbeyler/8205643/webrev.00/

Re: RFR (S) 8205643: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java fails

2018-07-10 Thread Alex Menkov
Looks good to me. --alex On 07/10/2018 13:37, JC Beyler wrote: Hi Alex, Done here: http://cr.openjdk.java.net/~jcbeyler/8205643/webrev.01/ Any other issues with this fix? Thanks! Jc On Tue, Jul 10, 2018 at 12:26 PM Alex Menkov > wrote: Hi JC, you

Re: RFR (S) 8205643: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java fails

2018-07-10 Thread serguei.spit...@oracle.com
Hi Jc, The fix looks good. Alex is right. I forgot to tell you that the test has be excluded from the file:    open/test/hotspot/jtreg/ProblemList.txt Thanks, Serguei On 7/10/18 12:26, Alex Menkov wrote: Hi JC, you need also to remove the test from ProblemList --alex On 07/10/2018 11:41,

Re: RFR (S) 8205643: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java fails

2018-07-10 Thread JC Beyler
Hi Serguei, Here it is: http://cr.openjdk.java.net/~jcbeyler/8205643/webrev.02/ Could someone test/push it please? Thanks! Jc On Tue, Jul 10, 2018 at 2:56 PM serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > Sorry, did not see your reply to Alex. > Looks good - ship it! > >

Re: RFR (S) 8205643: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java fails

2018-07-10 Thread serguei.spit...@oracle.com
Hi Jc, I'll test and push it. Thanks, Serguei On 7/10/18 15:31, JC Beyler wrote: Hi Serguei, Here it is: http://cr.openjdk.java.net/~jcbeyler/8205643/webrev.02/

Re: RFR (S) 8205643: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java fails

2018-07-10 Thread serguei.spit...@oracle.com
Sorry, did not see your reply to Alex. Looks good - ship it! Thanks, Serguei On 7/10/18 14:54, serguei.spit...@oracle.com wrote: Hi Jc, The fix looks good. Alex is right. I forgot to tell you that the test has be excluded from the file:    open/test/hotspot/jtreg/ProblemList.txt Thanks,

Re: RFR: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

2018-07-10 Thread Jini George
Gentle reminder ! Thanks, Jini. On 7/10/2018 12:14 AM, Jini George wrote: Requesting reviews for enabling SA tests on OS X for Mach5. https://bugs.openjdk.java.net/browse/JDK-8199700 Webrev: http://cr.openjdk.java.net/~jgeorge/8199700/webrev.00/ The changes are mostly to include the