RE: serviceability agent : problems when using gcc LTO (link time optimization)

Hello, thanks for the info - seems that for the minimal VM , lto is fine but currently not for the other (server/...) VM builds . Btw. I noticed similar issues with the SA when using link-time-gc . Looks like this eliminates the vtable info too that tha SA-coding ( LinuxVtblAccess cl

RFR (XS): 8237008: Exclude serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 and linuxppc64le

Hi, after JDK-8232759 "Remove GC.class_stats" [0] was pushed, we see the test "serviceability/sa/TestInstanceKlassSizeForInterface.java" failing on linuxppc64 and linuxppc64le the same way as "serviceability/sa/TestInstanceKlassSize.java". Hence, I'm requesting the same exclusion of TestInstan

RE: RFR (XS): 8237008: Exclude serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 and linuxppc64le

Hi Christoph, looks good to me. Thanks, Martin From: Langer, Christoph Sent: Montag, 13. Januar 2020 11:24 To: hotspot-...@openjdk.java.net; Doerr, Martin Cc: OpenJDK Serviceability Subject: RFR (XS): 8237008: Exclude serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 an

Re: RFR (XS): 8237008: Exclude serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 and linuxppc64le

Hi Christoph, I think those tests are currnetly failing on all platforms - see JDK-8236917. The failures after GC.class_stats removal are unrelated to the failures reported in 8230664 AFAICS. David On 13/01/2020 8:23 pm, Langer, Christoph wrote: Hi, after JDK-8232759 “Remove GC.class_stats

RE: RFR (XS): 8237008: Exclude serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 and linuxppc64le

Hi David, thanks for the heads up. However, in our CI, these tests pass on all platforms except linuxppc64/linuxppc64le consistently. I think I'll push the exclusion and once JDK-8236917 has been resolved I'll try on the ppc linuxes again... Best regards Christoph > -Original Message-

Re: RFR (XS): 8237008: Exclude serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 and linuxppc64le

Hi, I didn't see this with my filtering.  Do you know why it fails for ppcle? It fails for us on all platforms because test.vm.opts isn't set in our CI jobs. Thanks, Coleen On 1/13/20 8:26 AM, Langer, Christoph wrote: Hi David, thanks for the heads up. However, in our CI, these tests pass

RE: RFR (XS): 8237008: Exclude serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 and linuxppc64le

Hi Coleen, why it's failing on ppc or ppcle was analyzed in https://bugs.openjdk.java.net/browse/JDK-8230664. You can read in the description: The test retrieves the size of Java classes by 2 different APIs and expects the result to be equal: - SA reports the size of the reserved memory. Round

Re: jmx-dev RFR(S): 8234484: Add ability to configure third port for remote JMX

Hi Felix, On 11/01/2020 07:37, Yangfei (Felix) wrote: Hi Daniel, Thanks for the suggestions. I modified the patch making the third port also configurable via the management.properties file. New webrev: http://cr.openjdk.java.net/~fyang/8234484/webrev.01/ I think I would prefer

Re: jmx-dev RFR: 8213222: remove RMIConnectorServer.CREDENTIAL_TYPES

Hi Daniil, Looks good to me as well. I wonder however if the release note should point to the replacement? Something like: The terminally deprecated constant `javax.management.remote.rmi.RMIConnectorServer.CREDENTIAL_TYPE` has been removed. A filter pattern can be specified instead using `RMI

Re: RFR (XS): 8237008: Exclude serviceability/sa/TestInstanceKlassSizeForInterface.java on linuxppc64 and linuxppc64le

On 13/01/2020 11:26 pm, Langer, Christoph wrote: Hi David, thanks for the heads up. However, in our CI, these tests pass on all platforms except linuxppc64/linuxppc64le consistently. Sorry I wasn't specific enough. This test fails on all platforms in some configuration due to a problem with

Re: RFR: JDK-8235846: Improve WindbgDebuggerLocal implementation

Hi Alex, It looks pretty good. Just some minor comments below. The class AutoCOMPtr has unfixed indents. I guess, the function AutoArrayPtr.asPtr() is not used anymore and can be deleted. I'd suggest to remove first level '()'

Re: RFR(M): 8236913: debug agent's jdwp command logging should include the command set name and command name

Hi Alex, Are you ok with the _p arguments? Also, can I get a second reviewer please. thanks, Chris On 1/10/20 3:00 PM, Chris Plummer wrote: Hi Alex, I'll fix the mistakes in MethodImpl.c and ReferenceTypeImpl.c. As for the "_p" suffix, it means the argument is a pointer type that a value