Hi Chris,
It looks good to me modulo the comments from Alex.
I'm ok with the _p arguments.
Probably, you've already considered to return Command (instead of CommandHandler) from the
debugDispatch_getHandler().
It allows to get rid of the cmdName_
On 2020-01-10 11:01, Baesken, Matthias wrote:
Hello, I recently looked into the gcc lto optimization mode (see for some
details https://gcc.gnu.org/onlinedocs/gccint/LTO-Overview.html and
http://hubicka.blogspot.com/2019/05/gcc-9-link-time-and-inter-procedural.html
).
This mode can le
Hi Magnus, thanks for the info , I already noticed yesterday the setting for
arm-32 in the minimal build .
Do you think we could set it too for the other Linux platforms in the minimal
build ( serviceability agent is not supported there as well so the observed
issue wouldn’t be a problem).
On 2020-01-14 13:49, Baesken, Matthias wrote:
Hi Magnus, thanks for the info , I already noticed yesterday the
setting for arm-32 in the minimal build .
Do you think we could set it too for the other Linux platforms in
the minimal build ( serviceability agent is not supported there as
we
Magnus, Matthias,
for me, lto is a little heavyweight for development. x86_64 build time
with gcc 7:
Server 1m32.484s
Server+Minimal 1m42.166s
Server+Minimal (--with-jvm-features="link-time-opt") 5m29.422s
If the change to enable lto by default is proposed, what would be the
recommended strategy
Hello Magnus and Aleksei, thanks for the input .
The times you provided really look like they make a big difference at least
for people often building minimal-vm .
Guess I have to measure myself a bit (maybe the difference is not that big on
our linux s390x / ppc64(le) ) .
>
> If the
On 14/01/2020 19:57, Baesken, Matthias wrote:
> Hello Magnus and Aleksei, thanks for the input .
>
> The times you provided really look like they make a big difference at least
> for people often building minimal-vm .
> Guess I have to measure myself a bit (maybe the difference is not
Hi Chris,
On 01/13/2020 20:11, Chris Plummer wrote:
Hi Alex,
Are you ok with the _p arguments?
Yes, LGTM.
--alex
Also, can I get a second reviewer please.
thanks,
Chris
On 1/10/20 3:00 PM, Chris Plummer wrote:
Hi Alex,
I'll fix the mistakes in MethodImpl.c and ReferenceTypeImpl.c. As
Hi Serguei,
I didn't want to return a Command because then the
cmdSetNum and cmdNum would need to be checked by the caller before
calling debugDispatch_getHandler() or have special handling for NULL being returned.
Thanks for the review.
Hi Chris,
Okay, thanks!
Serguei
On 1/14/20 10:39 AM, Chris Plummer wrote:
Hi Serguei,
I didn't want to return a Command because then the cmdSetNum and
cmdNum would need to be checked by the caller before calling
debugDispatch_getHandler()or have special handling for NULL being
returned.
T
Summary: Use getTestJavaOpts() instead of getVmOptions() because of
mach5 configuration settings.
Tested with hs-tier3 with no failures anymore.
open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236917.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8236917
Thanks,
Coleen
Summary: Make jmap -clstats call jcmd VM.classloader_stats instead which
better matches the documentation
Tested with tier1 and *
jtreg:open/test/jdk/sun/tools/jmap/BasicJMapTest.java
locally.
open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236968.01/webrev
bug link https://bugs.ope
Hi Serguei,
Thank you for the review.
updated webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_improve/webrev.02/
On 01/13/2020 16:39, serguei.spit...@oracle.com wrote:
Hi Alex,
It looks pretty good.
Just some minor comments below.
The class AutoCOMPtr has unfixed indents.
I guess, th
Hi
The fix looks good itself (you still need 'R'eview). However I see about
20 other SA/ tests where lingeredApp is still executed with vm.opts
only. Even it doesn't cause any failures it means that tests silently
ignore java.opts set by user.
I think it makes sense to fix them also or file
Looks good. Thanks for fixing!
Chris
On 1/14/20 11:38 AM, coleen.phillim...@oracle.com wrote:
Summary: Use getTestJavaOpts() instead of getVmOptions() because of
mach5 configuration settings.
Tested with hs-tier3 with no failures anymore.
open webrev at http://cr.openjdk.java.net/~coleenp/20
Hi Alan and Daniel,
Thank you for reviewing this change and the CSR. I updated the release note
as Daniel suggested.
Best regards,
Daniil
On 1/13/20, 7:36 AM, "Daniel Fuchs" wrote:
Hi Daniil,
Looks good to me as well. I wonder however if the release note
should point to the
Hi Alex,
Thank you for the update!
It looks good.
Still incorrect indent:
103 ~AutoJavaString() { 104 if (m_buf) { 105
m_env->ReleaseStringUTFChars(m_str, m_buf); 106 } 107 } 108 109 operator
const char* () const { 110 return m_buf; 111 } ... 133 void
setReleaseMode(jint mode) {
134 release
On 1/14/20 3:45 PM, Leonid Mesnik wrote:
Hi
The fix looks good itself (you still need 'R'eview). However I see
about 20 other SA/ tests where lingeredApp is still executed with
vm.opts only. Even it doesn't cause any failures it means that tests
silently ignore java.opts set by user.
I t
Thanks Chris!
Coleen
On 1/14/20 3:57 PM, Chris Plummer wrote:
Looks good. Thanks for fixing!
Chris
On 1/14/20 11:38 AM, coleen.phillim...@oracle.com wrote:
Summary: Use getTestJavaOpts() instead of getVmOptions() because of
mach5 configuration settings.
Tested with hs-tier3 with no failur
Fix looks good - thanks Coleen. This one certainly had us scratching our
heads for a while!
I agree there should be a follow up issue about use of getVmOptions() in
tests.
David
On 15/01/2020 5:38 am, coleen.phillim...@oracle.com wrote:
Summary: Use getTestJavaOpts() instead of getVmOptions(
Thanks David. The follow up issue is:
https://bugs.openjdk.java.net/browse/JDK-8237111
But there are more than the LingeredApps that use getVmOptions().
Somebody should make sure all these tests are getting the right values.
thanks,
Coleen
On 1/14/20 4:56 PM, David Holmes wrote:
Fix looks go
Hi Coleen,
I concur with the discussion in the bug report. This change looks good.
Thanks,
David
On 15/01/2020 6:37 am, coleen.phillim...@oracle.com wrote:
Summary: Make jmap -clstats call jcmd VM.classloader_stats instead which
better matches the documentation
Tested with tier1 and *
jtreg
Hi Coleen,
Looks good. Please update the copyright.
thanks,
Chris
On 1/14/20 12:37 PM, coleen.phillim...@oracle.com wrote:
Summary: Make jmap -clstats call jcmd VM.classloader_stats instead
which better matches the documentation
Tested with tier1 and *
jtreg:open/test/jdk/sun/tools/jmap/Ba
Thanks Chris,
I'll fix the copyrights on commit.
Coleen
On 1/14/20 6:11 PM, Chris Plummer wrote:
Hi Coleen,
Looks good. Please update the copyright.
thanks,
Chris
On 1/14/20 12:37 PM, coleen.phillim...@oracle.com wrote:
Summary: Make jmap -clstats call jcmd VM.classloader_stats instead
wh
Hi Paul,
I made some minor updates to the CSR request and added myself as a reviewer.
Thanks,
David
On 15/01/2020 10:00 am, Hohensee, Paul wrote:
Please review this CSR for a backport of JDK-8144732 to jdk8u.
JBS issue: https://bugs.openjdk.java.net/browse/JDK-8144732
JBS release note issue:
25 matches
Mail list logo
