Hi Serguei,
Your point about about the JVM state being read-only and
unchanging while SA is attached is valid. I had to clarify this
not so obvious point a couple times during internal discussions.
Basically any hotspot state that SA has cached is thrown
Please review this small change which removes the STACK_BIAS constant and its
uses:
JBS: https://bugs.openjdk.java.net/browse/JDK-8245521
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8245521/webrev.00/open/webrev/
Background (from JBS):
With Solaris/SPARC removed the STACK_BIAS
Hi Dannil,
On 22/05/2020 3:06 pm, Daniil Titov wrote:
Please review a webrev [1] that reverts the changes done in
jdk.test.lib.process.OutputAnalyzer in [3].
Change [3] modified OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings()
methods to ignore also VM version strings . The current
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8245392
CSR draft (one CSR reviewer is needed before finalizing
it):
https://bugs.openjdk.java.net/browse/JDK-8245433
Webrev:
Please review a webrev [1] that reverts the changes done in
jdk.test.lib.process.OutputAnalyzer in [3].
Change [3] modified OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings()
methods to ignore also VM version strings . The current webrev [1] reverts this
change and instead makes the tests
Hi Mikael,
Looks good.
I assume the change to GraalHotSpotVMConfig.java is to allow it to work
with older VMs?
Thanks,
David
On 22/05/2020 1:36 pm, Mikael Vidstedt wrote:
Please review this small change which removes the STACK_BIAS constant and its
uses:
JBS:
Hi Serguei,
On 22/05/2020 3:02 pm, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8245392
CSR draft (one CSR reviewer is needed before finalizing it):
https://bugs.openjdk.java.net/browse/JDK-8245433
I've made some updates and comments
Hi Mandy,
Thanks for the suggestions. They have been incorporated in the revised
webrev.
http://cr.openjdk.java.net/~hseigel/webrev.01/webrev/
Harold
On 5/20/2020 1:05 PM, Mandy Chung wrote:
Hi Vicente,
On 5/20/20 8:40 AM, Vicente Romero wrote:
Hi David,
Hi Chris,
With the below fixed this looks good to me.
One comment about the constructor:
146 public InstanceKlass(Address addr) {
147 super(addr);
148
149 // If the class hasn't yet reached the "loaded" init state, then don't go any further
Hi David,
Thanks for looking at this! Please review this new webrev:
http://cr.openjdk.java.net/~hseigel/webrev.01/webrev/
This webrev contains the following significant changes:
1. The format/indentation issues in classFileParser.cpp were fixed.
2. Unneeded checks in
Hi Chris,
I have a question about a change in
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/Dictionary.java.
61 /** All classes, and their initiating class loader, passed in. */
62 public void allEntriesDo(ClassLoaderDataGraph.ClassAndLoaderVisitor v,
Oop loader) {
63
Yes, you are correct. As I mentioned earlier, it turns out this
functionality isn't used, other wise it also would have been exposed by
the other bug I fixed (the unnecessary outter loop). I'll fix this to
use !isLoaded().
thanks,
Chris
On 5/21/20 10:44 AM, Daniil Titov wrote:
Hi Chris,
I
Ping!
Forwarded Message
Subject:
RFR(S): 8244203:
sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java fails
with NullPointerException
13 matches
Mail list logo
