Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v3]

2020-11-06 Thread Coleen Phillimore
On Fri, 6 Nov 2020 01:01:40 GMT, Chris Plummer wrote: >> char tmp[10 + 1]; >> snprintf(tmp, sizeof(tmp), "%.3d", millisecs); >> snprintf(tbuf, ltbuf, "%s.%s %s", timestamp_date_time, tmp, >> timestamp_timezone); >> This also gets the same thing. > > The concern is when it is less than

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

2020-11-06 Thread Thomas Stuefe
On Fri, 6 Nov 2020 12:02:28 GMT, Coleen Phillimore wrote: >> src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 84: >> >>> 82: // Truncate milliseconds in buffer large enough to hold the >>> 83: // value which is always < 1000 (and so a maximum of 3 digits for >>> "%.3s") >>>

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

2020-11-06 Thread Coleen Phillimore
On Fri, 6 Nov 2020 06:39:04 GMT, Thomas Stuefe wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust millisecond format. > > src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 84: > >> 82: //

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

2020-11-06 Thread Coleen Phillimore
On Fri, 6 Nov 2020 01:20:01 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust millisecond format. > > src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 83: > >> 81: >> 82:

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v7]

2020-11-06 Thread Coleen Phillimore
> This change turns the HashTable that JVMTI uses for object tagging into a > regular Hotspot hashtable - the one in hashtable.hpp with resizing and > rehashing. Instead of pointing directly to oops so that GC has to walk the > table to follow oops and then to rehash the table, this table

RFR: 8255982: Extend BasicJMapTest to test with different GC Heap

2020-11-06 Thread Lin Zang
The implementation of jmap tool depends on the implementation of object iteration by different GC heap. This patch extend the BasicJMapTest to cover differet GC Heap. - Commit messages: - 8255982: Extend BasicJMapTest to test with different GC Heap Changes:

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

2020-11-06 Thread David Holmes
On 6/11/2020 10:08 pm, Thomas Stuefe wrote: On Fri, 6 Nov 2020 12:02:28 GMT, Coleen Phillimore wrote: src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 84: 82: // Truncate milliseconds in buffer large enough to hold the 83: // value which is always < 1000 (and so a maximum

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

2020-11-06 Thread Thomas Stüfe
On Fri, Nov 6, 2020 at 2:01 PM David Holmes wrote: > On 6/11/2020 10:08 pm, Thomas Stuefe wrote: > > On Fri, 6 Nov 2020 12:02:28 GMT, Coleen Phillimore > wrote: > > > >>> src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 84: > >>> > 82: // Truncate milliseconds in buffer

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v3]

2020-11-06 Thread Claes Redestad
On Fri, 6 Nov 2020 11:58:04 GMT, Coleen Phillimore wrote: >> The concern is when it is less than 100ms. > > unsigned millisecs[] = { 2, 20, 200, 1000 }; > get_time_stamp(millisecs[i], buf, sizeof(buf)); > > gets: > > timestamp 06.11.2020 06:56:08.002 EST > timestamp 06.11.2020 06:56:08.020

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v5]

2020-11-06 Thread Coleen Phillimore
> Apply patch suggested by @cl4es in the bug report. Passes > linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug > builds with this patch, and tier1. > > thanks, > Coleen Coleen Phillimore has updated the pull request incrementally with one additional commit

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v3]

2020-11-06 Thread Coleen Phillimore
On Fri, 6 Nov 2020 13:16:54 GMT, Claes Redestad wrote: >> unsigned millisecs[] = { 2, 20, 200, 1000 }; >> get_time_stamp(millisecs[i], buf, sizeof(buf)); >> >> gets: >> >> timestamp 06.11.2020 06:56:08.002 EST >> timestamp 06.11.2020 06:56:08.020 EST >> timestamp 06.11.2020 06:56:08.200 EST

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v5]

2020-11-06 Thread Claes Redestad
On Fri, 6 Nov 2020 13:28:12 GMT, Coleen Phillimore wrote: >> Apply patch suggested by @cl4es in the bug report. Passes >> linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug >> builds with this patch, and tier1. >> >> thanks, >> Coleen > > Coleen Phillimore

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v6]

2020-11-06 Thread Claes Redestad
On Fri, 6 Nov 2020 14:30:14 GMT, Coleen Phillimore wrote: >> Apply patch suggested by @cl4es in the bug report. Passes >> linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug >> builds with this patch, and tier1. >> >> thanks, >> Coleen > > Coleen Phillimore

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v5]

2020-11-06 Thread Thomas Stuefe
On Fri, 6 Nov 2020 13:28:12 GMT, Coleen Phillimore wrote: >> Apply patch suggested by @cl4es in the bug report. Passes >> linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug >> builds with this patch, and tier1. >> >> thanks, >> Coleen > > Coleen Phillimore

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v6]

2020-11-06 Thread Thomas Stuefe
On Fri, 6 Nov 2020 14:30:14 GMT, Coleen Phillimore wrote: >> Apply patch suggested by @cl4es in the bug report. Passes >> linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug >> builds with this patch, and tier1. >> >> thanks, >> Coleen > > Coleen Phillimore

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v6]

2020-11-06 Thread Coleen Phillimore
On Fri, 6 Nov 2020 14:35:34 GMT, Claes Redestad wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Now this builds. I hope it's perfect. > > Perfect! Thanks Claes and Thomas for all your help and the code

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v6]

2020-11-06 Thread Chris Plummer
On Fri, 6 Nov 2020 14:30:14 GMT, Coleen Phillimore wrote: >> Apply patch suggested by @cl4es in the bug report. Passes >> linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug >> builds with this patch, and tier1. >> >> thanks, >> Coleen > > Coleen Phillimore

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v5]

2020-11-06 Thread Coleen Phillimore
On Fri, 6 Nov 2020 14:03:10 GMT, Thomas Stuefe wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More. > > src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 86: > >> 84: char tmp[20]; >> 85:

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v6]

2020-11-06 Thread Coleen Phillimore
> Apply patch suggested by @cl4es in the bug report. Passes > linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug > builds with this patch, and tier1. > > thanks, > Coleen Coleen Phillimore has updated the pull request incrementally with one additional commit

Integrated: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

2020-11-06 Thread Coleen Phillimore
On Thu, 5 Nov 2020 00:37:15 GMT, Coleen Phillimore wrote: > Apply patch suggested by @cl4es in the bug report. Passes > linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug > builds with this patch, and tier1. > > thanks, > Coleen This pull request has now

Integrated: 8254864: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java timed out

2020-11-06 Thread Alex Menkov
On Tue, 3 Nov 2020 23:16:50 GMT, Alex Menkov wrote: > - Fixed synchronization logic in resexhausted001; > - On Windows JVM cannot produce OOM caused by thread creation failure. > Massive thread creation causes big system (not VM) memory consumption, as a > result test host dramatically slows