Re: code review round 0 for minor FDS makefile fix (8033714)

wrote: This code review request is going to three different aliases. Don't use Thunderbird's reply to list option since it will pick just _one_ of the _three_ lists. Greetings, Doug Simon and Tom Rodriguez have sent a Full Debug Symbols (FDS) makefile fix our way. Here are the bug

Re: [10] RFR(M) 8182701: Modify JVMCI to allow Graal Compiler to expose platform MBean

> On 15 Sep 2017, at 14:32, Jaroslav Tulach wrote: > > Thanks for the review Mandy, Daniel. Now, that the consolidated JDK10 > repository is available, I have updated my webrev to its structure. In > addition to that I addressed your comments: > > On úterý 12.

RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

Please review this change that removes the existing Graal service provider for hooking into the Platform MBean Server and makes jdk.internal.vm.compiler.management an upgradeable module. Please refer to

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

ernal.vm.compiler module. The rest of the changes will come in the next Graal update. If you'd like, I can defer pushing these changes until the Graal changes land on github so that the complete change can be reviewed. -Doug > On 13/04/2018 4:24 AM, Doug Simon wrote: >> Please review this chang

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

> On 13 Apr 2018, at 15:59, David Holmes <david.hol...@oracle.com> wrote: > > On 13/04/2018 5:12 PM, Doug Simon wrote: >>> On 13 Apr 2018, at 07:15, David Holmes <david.hol...@oracle.com> wrote: >>> >>> Hi Doug, >>> >>>

Re: RFR: 8208686: [AOT] JVMTI ResourceExhausted event repeated for same allocation

Thanks for the review. -Doug > On 5 Oct 2018, at 19:27, Tom Rodriguez wrote: > > Looks good. > > tom > > Doug Simon wrote on 10/5/18 8:22 AM: >> Hi, >> Testing found a bug in the original webrev. Namely, when clearing out a >> pending exception and

Re: RFR: 8208686: [AOT] JVMTI ResourceExhausted event repeated for same allocation

Thanks for re-reviewing. -Doug > On 5 Oct 2018, at 18:05, Vladimir Kozlov wrote: > > Looks good. > > Thanks, > Vladimir > > On 10/5/18 8:22 AM, Doug Simon wrote: >> Hi, >> Testing found a bug in the original webrev. Namely, when clearing out a >

Re: RFR: 8208686: [AOT] JVMTI ResourceExhausted event repeated for same allocation

> > Thanks, > Vladimir > > On 9/25/18 8:11 AM, Daniel D. Daugherty wrote: >> Adding serviceability-dev@... since this is JVM/TI... >> Dan >> On 9/25/18 10:48 AM, Doug Simon wrote: >>> A major design point of Graal is to treat allocations as non-side effecting

Re: RFR: 8208686: [AOT] JVMTI ResourceExhausted event repeated for same allocation

> Thanks, > Serguei > > On 10/2/18 1:11 AM, Doug Simon wrote: >> It would be great to get some input from the non-compilers teams on this RFR. >> >> -Doug >> >>> On 28 Sep 2018, at 19:51, Vladimir Kozlov >>> wrote: >>> >>>

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

> On 29 Oct 2019, at 10:12, David Holmes wrote: > > Hi Doug, > > Thanks for taking a look so quickly! :) > > On 29/10/2019 6:55 pm, Doug Simon wrote: >> Hi David, >> Since Graal needs to work against multiple JVMCI versions (and VM >> versions!)

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

> On 31 Oct 2019, at 05:30, David Holmes wrote: > > Hi Doug, > > On 30/10/2019 10:06 pm, Doug Simon wrote: >>> On 30 Oct 2019, at 05:28, David Holmes >> <mailto:david.hol...@oracle.com>> wrote: >>> >>> Hi Doug, >>> >>&

Re: RFR: 8252685: APIs that require JavaThread should take JavaThread arguments [v2]

On Thu, 13 May 2021 03:26:50 GMT, Vladimir Kozlov wrote: > Compiler related changes seems fine. > @dougxc, note that jvmci is affected. It looks reasonable for me but you may > need to check if it is correct from libgraal POV. I tried to test this patch against GraalVM but am blocked due to

Re: RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v2]

On Wed, 30 Jun 2021 16:43:04 GMT, Daniel D. Daugherty wrote: > Looks good to me. I had a hard time with all the whitespace indentation https://github.blog/2018-05-01-ignore-white-space-in-code-review/ - PR: https://git.openjdk.java.net/jdk/pull/4629

Re: RFR: 8262910: Cleanup THREAD/TRAPS/naming and typing issues in ObjectMonitor and related code [v3]

On Thu, 4 Mar 2021 23:37:27 GMT, Daniel D. Daugherty wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More pointer declaration style fixups > >

Re: RFR: 8218885: Restore pop_frame and force_early_return functionality for Graal

On Wed, 22 Sep 2021 05:40:40 GMT, Tom Rodriguez wrote: > This logic no longer seems to be necessary since the adjustCompilationLevel > callback has been removed. I sent instructions via email since it requires using internal resources. - PR:

Re: RFR: 8284903: Fix typos in hotspot

On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted,