://jbs.oracle.com/bugs/browse/JDK-8009728
Tested with vm.quick.testlist which includes redefine classes tests
and jck lang and vm tests.
Thanks,
Coleen
---BeginMessage---
On 3/06/2013 9:52 PM, Mikhailo Seledtsov wrote:
Thank you David,
I have updated my editor to use 4 spaces as indentation
Changes look good to me.
Misha
On 6/2/2015 11:55 AM, Chris Plummer wrote:
I'm going to have to separate out the ProcessTool.java changes into a
separate changeset (and CR). In the meantime, feel free to review what
I have below. The code won't be changing at all when I separate out
the
Hi Chris,
Please see my comments in the original issue, (Mikhailo Seledtsov
https://bugs.openjdk.java.net/secure/ViewProfile.jspa?name=mseledtsov
added a comment - 2015-06-22 19:12).
Misha
On 6/22/2015 2:27 PM, Ioi Lam wrote:
Looks good to me, but someone from SQE should revew
Hi Chris,
After discussion and better understanding the problem, I agree with the
changes.
I have also added a new comment to the issue.
Misha
On 6/22/2015 4:14 PM, Mikhailo Seledtsov wrote:
Hi Chris,
Please see my comments in the original issue, (Mikhailo Seledtsov
https
Hi Igor,
Looks good. One style nit:
LineNumberOnBraceTarg:
All other Java tests use style of CAP_UNDERSCORE (e.g. STOP_LINE) for line
number variables, but this test uses 'stopLine'.
Consider changing it to STOP_LINE (and STOP_LINE_2) to be uniform.
The rest looks good to me (+ David's
oes not look unified:
http://cr.openjdk.java.net/~iignatyev/8177507/webrev.00/test/com/sun/jdi/LambdaBreakpointTest.java.udiff.html
On 3/29/17 11:08, Mikhailo Seledtsov wrote:
One style nit:
LineNumberOnBraceTarg:
All other Java tests use style of CAP_UNDERSCORE (e.g. STOP_LINE)
for line number va
Looks good to me,
Misha
On 5/9/18, 5:14 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8202392/webrev.00/index.html
1396 lines changed: 1396 ins; 0 del; 0 mod;
Hi all,
could you please review his patch which open sources heapdump tests from
so-called VM testbase? as it's
+1,
Misha
On 5/18/18, 6:42 PM, serguei.spit...@oracle.com wrote:
Hi Igor,
This looks good to me.
Thank you a lot for taking care about this move from closed to open!
Thanks,
Serguei
On 5/15/18 14:21, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199379/webrev.00/index.html
Hi Bob,
I looked at the tests. In general they look good. I am a bit
concerned about the use of ERROR_MARGIN in one of the tests. We need to
make sure that the tests are stable, and do not produce intermittent
failures.
Thank you,
Misha
On 6/7/18, 10:43 AM, Bob Vandette wrote:
Can I
+1
Misha
On 5/30/18, 3:43 PM, serguei.spit...@oracle.com wrote:
Hi Igor,
The fix looks good.
At least, I do not see any issues.
Thanks,
Serguei
On 5/29/18 16:22, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199371/webrev.00/index.html
64675 lines changed: 64675 ins; 0
Hi Alex,
Several test-related comments:
- CanGenerateAllClassHook.java
" 44 * So the test runs 2 java process": s/process/process*es*/
- CanGenerateAllClassHook.java
A general comment - please consider using "TestCommon" class and
"CDSTestUtils" where possible.
There are
Looks good to me,
Thank you,
Misha
On 2/5/18, 12:10 PM, Alex Menkov wrote:
Thank you for the feedback.
Updated fix:
http://cr.openjdk.java.net/~amenkov/can_generate_class_hook/webrev.03/
--alex
On 02/02/2018 11:18, Mikhailo Seledtsov wrote:
Hi Alex,
Several test-related comments
Looks good to me,
(I am not a Reviewer though)
Misha
On 3/15/19 4:14 PM, coleen.phillim...@oracle.com wrote:
Summary: move tests out of runtime to jvmti/RedefineClasses
These always belonged in serviceability/jvmti. Also, moved a couple
tests within serviceability/jvmti to RedefineClasses
me, while the main test process waits for the file to exist before running the test
cases.
Passes on Linux-x64 Docker-enabled host. Testing in the test cluster is in
progress.
Thank you,
Misha
On 8/7/19 5:11 PM, David Holmes wrote:
On 8/08/2019 9:04 am, Mikhailo Seledtsov wrote:
Hi Severin,
host. Testing in the test cluster is in
progress.
Thank you,
Misha
On 8/7/19 5:11 PM, David Holmes wrote:
On 8/08/2019 9:04 am, Mikhailo Seledtsov wrote:
Hi Severin, Bob,
Thank you for reviewing the code.
On 8/7/19, 11:38 AM, Bob Vandette wrote:
Can’t you come up with a better
lume, while the main test process
waits for the file to exist before running the test cases.
Passes on Linux-x64 Docker-enabled host. Testing in the test cluster
is in progress.
Thank you,
Misha
On 8/7/19 5:11 PM, David Holmes wrote:
On 8/08/2019 9:04 am, Mikhailo Seledtsov wrote:
Hi Severin, B
n test process waits for
the file to exist before running the test cases.
Passes on Linux-x64 Docker-enabled host. Testing in the test cluster is
in progress.
Thank you,
Misha
On 8/7/19 5:11 PM, David Holmes wrote:
On 8/08/2019 9:04 am, Mikhailo Seledtsov wrote:
Hi Severin, Bob,
Thank you fo
est process waits for the file to exist
before running the test cases.
Passes on Linux-x64 Docker-enabled host. Testing in the test
cluster is in progress.
Thank you,
Misha
On 8/7/19 5:11 PM, David Holmes wrote:
On 8/08/2019 9:04 am, Mikhailo Seledtsov wrote:
Hi Severin, Bob,
Thank you
the file to exist
before running the test cases.
Passes on Linux-x64 Docker-enabled host. Testing in the test
cluster is in progress.
Thank you,
Misha
On 8/7/19 5:11 PM, David Holmes wrote:
On 8/08/2019 9:04 am, Mikhailo Seledtsov wrote:
Hi Severin, Bob,
Thank you for reviewing the
Testing in the test cluster is in
progress.
Thank you,
Misha
On 8/7/19 5:11 PM, David Holmes wrote:
On 8/08/2019 9:04 am, Mikhailo Seledtsov wrote:
Hi Severin, Bob,
Thank you for reviewing the code.
On 8/7/19, 11:38 AM, Bob Vandette wrote:
Can’t you come up with a better way o
On Tue, 8 Jun 2021 20:44:46 GMT, Kevin Walls wrote:
> Since 8214300, jcmd cannot attach to a Java process in a docker container.
>
> That change started using a canonicalized File to create the .attach_pidXXX
> file. For a target process in a container, it will follow a symlink that is
>
On Tue, 30 Mar 2021 20:29:18 GMT, Chris Plummer wrote:
>>> You'll need a CSR for this enhancement.
>>
>> Hmm, yeah.
>> I'm wondering if this should rather go into the Lilliput repository once it
>> is created (I'd expect in ~1week or so). Then it would be refined during
>> Lilliput project
On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which moves `ClassFileInstaller` class to
> `jdk.test.lib.helpers` package?
> to reduce changes in the tests, `ClassFileInstaller` in the default package
> is kept w/ just `main` method
On Tue, 2 Mar 2021 23:27:21 GMT, Igor Ignatyev wrote:
> resurrecting old
> [RFR](https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-June/041981.html):
>
>> Hi all,
>>
>> could you please review the patch which introduces a new @requires property
>> to filter out the tests which ignore
g updated, I thought it would be a
> good idea to also change the name to use more generic container terminology:
> buildJdkDockerImage() --> buildJdkContainerImage()
Mikhailo Seledtsov has updated the pull request incrementally with one
additional commit since the last revision:
Address
On Tue, 17 Aug 2021 20:30:04 GMT, Harold Seigel wrote:
>> Mikhailo Seledtsov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressing review feedback
>
> test/lib/jdk/test/lib/containers/docker/DockerTest
g updated, I thought it would be a
> good idea to also change the name to use more generic container terminology:
> buildJdkDockerImage() --> buildJdkContainerImage()
Mikhailo Seledtsov has updated the pull request incrementally with one
additional commit since the last revision:
Fix
On Tue, 17 Aug 2021 22:13:54 GMT, Mikhailo Seledtsov
wrote:
>> Please review this change that updates the buildJdkDockerImage() test
>> library API.
>>
>> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
>> support for containers is
On Mon, 16 Aug 2021 23:31:41 GMT, Mikhailo Seledtsov
wrote:
> Please review this change that updates the buildJdkDockerImage() test library
> API.
>
> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
> support for containers is not tested&qu
On Mon, 16 Aug 2021 23:48:46 GMT, Igor Ignatyev wrote:
>> Please review this change that updates the buildJdkDockerImage() test
>> library API.
>>
>> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
>> support for containers is not tested".
>> The initial intent was
On Mon, 16 Aug 2021 17:25:57 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8272124. The fix puts a limit of 3 when
> splitting self cgroup lines by ':' so that Cgroup paths won't get truncated
> if they contain embedded ':'s. For example, an entry of
>
Please review this change that updates the buildJdkDockerImage() test library
API.
This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
support for containers is not tested".
The initial intent was to extend the buildJdkDockerImage() API of
DockerTestUtils to accept custom
On Mon, 16 Aug 2021 23:31:41 GMT, Mikhailo Seledtsov
wrote:
> Please review this change that updates the buildJdkDockerImage() test library
> API.
>
> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
> support for containers is not tested&qu
On Wed, 9 Mar 2022 20:41:37 GMT, Daniel D. Daugherty wrote:
> A trivial fix to solve a memory leak/memory pinning for long runs of
> suspendthrd003.
>
> See the bug report for the gory analysis details.
>
> This fix was included in my jdk-19+12 stress runs so the updated test was
> executed
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Mon, 2 May 2022 06:24:21 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Fri, 29 Apr 2022 18:23:35 GMT, Mikhailo Seledtsov
wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> test/jdk/jdk/jfr/api/consume
40 matches
Mail list logo
