Re: RFR(xs): 8166012: [linux] Remove remnants of LinuxThreads from Linux attach framework

2016-09-14 Thread Thomas Stüfe 
Thanks, David!

On Wed, Sep 14, 2016 at 11:43 AM, David Holmes 
wrote:

> Hi Thomas,
>
> On 14/09/2016 7:37 PM, Thomas Stüfe wrote:
>
>> Please take a look at this small change:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8166012
>> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8166012-Remove-re
>> mnants-of-LinuxThreads-from-Linux-attach-framework/webrev.00/webrev/
>>
>> I noticed this when comparing AIX and Linux attach implementation.
>> This is a followup to JDK-8157236. See also JDK-8078513.
>>
>
> I just noticed this code myself yesterday :)
>
> Deletion looks good.
>
> Thanks,
> David
>
> Kind Regards, Thomas
>>
>

Re: RFR(xs): 8166012: [linux] Remove remnants of LinuxThreads from Linux attach framework

2016-09-14 Thread Alan Bateman 

On 14/09/2016 10:37, Thomas Stüfe wrote:


Please take a look at this small change:

Bug: https://bugs.openjdk.java.net/browse/JDK-8166012
webrev: 
http://cr.openjdk.java.net/~stuefe/webrevs/8166012-Remove-remnants-of-LinuxThreads-from-Linux-attach-framework/webrev.00/webrev/ 



I noticed this when comparing AIX and Linux attach implementation.
This is a followup to JDK-8157236. See also JDK-8078513.


Looks right to me.

-Alan

Re: RFR(xs): 8166012: [linux] Remove remnants of LinuxThreads from Linux attach framework

2016-09-14 Thread David Holmes 

Hi Thomas,

On 14/09/2016 7:37 PM, Thomas Stüfe wrote:

Please take a look at this small change:

Bug: https://bugs.openjdk.java.net/browse/JDK-8166012
webrev: 
http://cr.openjdk.java.net/~stuefe/webrevs/8166012-Remove-remnants-of-LinuxThreads-from-Linux-attach-framework/webrev.00/webrev/

I noticed this when comparing AIX and Linux attach implementation.
This is a followup to JDK-8157236. See also JDK-8078513.


I just noticed this code myself yesterday :)

Deletion looks good.

Thanks,
David


Kind Regards, Thomas

RFR(xs): 8166012: [linux] Remove remnants of LinuxThreads from Linux attach framework

2016-09-14 Thread Thomas Stüfe 
Please take a look at this small change:

Bug: https://bugs.openjdk.java.net/browse/JDK-8166012
webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8166012-Remove-remnants-of-LinuxThreads-from-Linux-attach-framework/webrev.00/webrev/

I noticed this when comparing AIX and Linux attach implementation.
This is a followup to JDK-8157236. See also JDK-8078513.

Kind Regards, Thomas