Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-13 Thread Doug Simon
> On 13 Apr 2018, at 15:59, David Holmes wrote: > > On 13/04/2018 5:12 PM, Doug Simon wrote: >>> On 13 Apr 2018, at 07:15, David Holmes wrote: >>> >>> Hi Doug, >>> >>> Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-13 Thread David Holmes
On 13/04/2018 5:12 PM, Doug Simon wrote: On 13 Apr 2018, at 07:15, David Holmes wrote: Hi Doug, Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with this ??? These are the non-Graal code base changes needed to move the bean out of the

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-13 Thread Doug Simon
> On 13 Apr 2018, at 07:15, David Holmes wrote: > > Hi Doug, > > Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with this > ??? These are the non-Graal code base changes needed to move the bean out of the jdk.internal.vm.compiler module. The

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-13 Thread Alan Bateman
On 12/04/2018 19:24, Doug Simon wrote: Please review this change that removes the existing Graal service provider for hooking into the Platform MBean Server and makes jdk.internal.vm.compiler.management an upgradeable module. Please refer to

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-12 Thread David Holmes
Hi Doug, Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with this ??? Thanks, David On 13/04/2018 4:24 AM, Doug Simon wrote: Please review this change that removes the existing Graal service provider for hooking into the Platform MBean Server and makes

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-12 Thread mandy chung
On 4/13/18 2:24 AM, Doug Simon wrote: Please review this change that removes the existing Graal service provider for hooking into the Platform MBean Server and makes jdk.internal.vm.compiler.management an upgradeable module. Please refer to

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-12 Thread Igor Veresov
Looks good to me. igor > On Apr 12, 2018, at 11:24 AM, Doug Simon wrote: > > Please review this change that removes the existing Graal service provider > for hooking into the Platform MBean Server and makes > jdk.internal.vm.compiler.management an upgradeable module. >

RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-12 Thread Doug Simon
Please review this change that removes the existing Graal service provider for hooking into the Platform MBean Server and makes jdk.internal.vm.compiler.management an upgradeable module. Please refer to