RE: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-26 Thread Amit Sapre
Thanks Alan & mandy for reviews. Amit From: Alan Bateman Sent: Friday, March 23, 2018 9:54 PM To: Amit Sapre; Mandy Chung; serviceability-dev@openjdk.java.net; compiler-...@openjdk.java.net Subject: Re: RFR : JDK-8071367 - JMX: Remove SNMP support On 23/03/2018 10:43, Amit Sapre w

Re: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-23 Thread Alan Bateman
On 23/03/2018 10:43, Amit Sapre wrote: Thanks all for the inputs. This webrev addresses the inputs : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.02/ I think you need to put {@code ... } around

Re: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-23 Thread mandy chung
On 3/23/18 3:43 AM, Amit Sapre wrote: Thanks all for the inputs. This webrev addresses the inputs : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.02/ Looks good. Mandy

RE: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-23 Thread Amit Sapre
-...@openjdk.java.net Subject: Re: RFR : JDK-8071367 - JMX: Remove SNMP support On 3/22/18 6:12 AM, Alan Bateman wrote: On 22/03/2018 10:03, Amit Sapre wrote: Thanks Alan and Mandy for inputs. This webrev : HYPERLINK "http://cr.openjdk.java.net/%7Easapre/webrev/2018/JDK-8071367/webrev.01/

Re: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-22 Thread mandy chung
On 3/22/18 5:36 PM, Martin Buchholz wrote: On Wed, Mar 7, 2018 at 11:27 PM, Amit Sapre > wrote: Bug ID : https://bugs.openjdk.java.net/browse/JDK-8071367 Is there a reason

Re: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-22 Thread Martin Buchholz
On Wed, Mar 7, 2018 at 11:27 PM, Amit Sapre wrote: > > Bug ID : https://bugs.openjdk.java.net/browse/JDK-8071367 > Is there a reason this bug is not visible?

Re: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-22 Thread mandy chung
On 3/22/18 6:12 AM, Alan Bateman wrote: On 22/03/2018 10:03, Amit Sapre wrote: Thanks Alan and Mandy for inputs. This webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.01/ addresses your

Re: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-22 Thread Alan Bateman
On 22/03/2018 10:03, Amit Sapre wrote: Thanks Alan and Mandy for inputs. This webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.01/ addresses your comments. I reverted changes for  

RE: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-22 Thread Amit Sapre
, March 09, 2018 1:33 AM To: Alan Bateman; Amit Sapre Cc: serviceability-dev@openjdk.java.net; compiler-...@openjdk.java.net Subject: Re: RFR : JDK-8071367 - JMX: Remove SNMP support On 3/7/18 11:46 PM, Alan Bateman wrote: On 08/03/2018 07:27, Amit Sapre wrote: Hello, Please review

Re: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-08 Thread mandy chung
On 3/7/18 11:46 PM, Alan Bateman wrote: On 08/03/2018 07:27, Amit Sapre wrote: Hello, Please review the changes for removing SNMP support. Bug ID : https://bugs.openjdk.java.net/browse/JDK-8071367 Webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.00

Re: RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-07 Thread Alan Bateman
On 08/03/2018 07:27, Amit Sapre wrote: Hello, Please review the changes for removing SNMP support. Bug ID : https://bugs.openjdk.java.net/browse/JDK-8071367 Webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.00

RFR : JDK-8071367 - JMX: Remove SNMP support

2018-03-07 Thread Amit Sapre
Hello, Please review the changes for removing SNMP support. Bug ID : https://bugs.openjdk.java.net/browse/JDK-8071367 Webrev : http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.00 Thanks, Amit