Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

On Fri, Nov 6, 2020 at 2:01 PM David Holmes wrote: > On 6/11/2020 10:08 pm, Thomas Stuefe wrote: > > On Fri, 6 Nov 2020 12:02:28 GMT, Coleen Phillimore > wrote: > > > >>> src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 84: > >>> > 82: // Truncate milliseconds in buffer

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

On 6/11/2020 10:08 pm, Thomas Stuefe wrote: On Fri, 6 Nov 2020 12:02:28 GMT, Coleen Phillimore wrote: src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 84: 82: // Truncate milliseconds in buffer large enough to hold the 83: // value which is always < 1000 (and so a maximum

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

On Fri, 6 Nov 2020 12:02:28 GMT, Coleen Phillimore wrote: >> src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 84: >> >>> 82: // Truncate milliseconds in buffer large enough to hold the >>> 83: // value which is always < 1000 (and so a maximum of 3 digits for >>> "%.3s") >>>

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

On Fri, 6 Nov 2020 01:20:01 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust millisecond format. > > src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 83: > >> 81: >> 82:

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

On Fri, 6 Nov 2020 06:39:04 GMT, Thomas Stuefe wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust millisecond format. > > src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 84: > >> 82: //

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

On Fri, 6 Nov 2020 01:04:09 GMT, Coleen Phillimore wrote: >> Apply patch suggested by @cl4es in the bug report. Passes >> linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug >> builds with this patch, and tier1. >> >> thanks, >> Coleen > > Coleen Phillimore

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

On Fri, 6 Nov 2020 01:04:09 GMT, Coleen Phillimore wrote: >> Apply patch suggested by @cl4es in the bug report. Passes >> linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug >> builds with this patch, and tier1. >> >> thanks, >> Coleen > > Coleen Phillimore

Re: RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

> Apply patch suggested by @cl4es in the bug report. Passes > linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug > builds with this patch, and tier1. > > thanks, > Coleen Coleen Phillimore has updated the pull request incrementally with one additional commit