Re: RFR: 8282475: SafeFetch should not rely on existence of Thread::current [v5]
On Wed, 9 Mar 2022 08:16:51 GMT, Johannes Bechberger wrote: > Oh, I did not know that. Sorry for that, I just wanted to rebase it and > forgot that this would change all the commit ids. You couldn't know. Just merge "master", which achieves the same and leaves the history intact. Additional tip. You can start a PR in draft mode. Reviews won't start until you un-draft. In draft mode, you have plenty of time to flesh out the patch and fix all bugs that show up in GHAs. In that phase, it's still okay to rebase. Once you consider the patch ready, you can un-draft the PR and the reviews start. Only then you should not rebase anymore. Starting out with a draft PR has also the advantage of not using reviewer time on an incomplete patch. - PR: https://git.openjdk.java.net/jdk/pull/7727
Re: RFR: 8282475: SafeFetch should not rely on existence of Thread::current [v5]
On Tue, 8 Mar 2022 13:17:29 GMT, Johannes Bechberger wrote: >> The WXMode for the current thread (on MacOS aarch64) is currently stored in >> the thread class which is unnecessary as the WXMode is bound to the current >> OS thread, not the current instance of the thread class. >> This pull request moves the storage of the current WXMode into a thread >> local global variable in `os` and changes all related code. SafeFetch >> depended on the existence of a thread object only because of the WXMode. >> This pull request therefore removes the dependency, making SafeFetch usable >> in more contexts. > > Johannes Bechberger has updated the pull request with a new target base due > to a merge or a rebase. The pull request now contains ten commits: > > - Move code to os::current_thread_wx > - Small fixes > - Move WX functionality into os specific files > - Minor fixes > - Fix include for threadWXSetters.inline.hpp > - Remove thread parameter from ThreadWXEnable > - Remove thread parameter from os methods > - Remove wx_init and current thread assert in safefetch > - Use os::current_thread_change_wx instead of thread methods Oh, I did not know that. Sorry for that, I just wanted to rebase it and forgot that this would change all the commit ids. - PR: https://git.openjdk.java.net/jdk/pull/7727
Re: RFR: 8282475: SafeFetch should not rely on existence of Thread::current [v5]
> The WXMode for the current thread (on MacOS aarch64) is currently stored in > the thread class which is unnecessary as the WXMode is bound to the current > OS thread, not the current instance of the thread class. > This pull request moves the storage of the current WXMode into a thread local > global variable in `os` and changes all related code. SafeFetch depended on > the existence of a thread object only because of the WXMode. This pull > request therefore removes the dependency, making SafeFetch usable in more > contexts. Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - Move code to os::current_thread_wx - Small fixes - Move WX functionality into os specific files - Minor fixes - Fix include for threadWXSetters.inline.hpp - Remove thread parameter from ThreadWXEnable - Remove thread parameter from os methods - Remove wx_init and current thread assert in safefetch - Use os::current_thread_change_wx instead of thread methods - Changes: https://git.openjdk.java.net/jdk/pull/7727/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7727=04 Stats: 241 lines in 32 files changed: 52 ins; 111 del; 78 mod Patch: https://git.openjdk.java.net/jdk/pull/7727.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7727/head:pull/7727 PR: https://git.openjdk.java.net/jdk/pull/7727
