Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-02-09 Thread serguei.spit...@oracle.com
Hi Jini, The update looks good to me. Thanks, Serguei On 2/8/18 00:59, Jini George wrote: Thank you very much, David and Serguei for the review. David, based on your comments, I took a relook at the fix and I have modified it. Since this is an object array klass, the search for the method

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-02-09 Thread Jini George
Thank you very much, Serguei. - Jini. On 2/9/2018 1:28 PM, serguei.spit...@oracle.com wrote: Hi Jini, The update looks good to me. Thanks, Serguei On 2/8/18 00:59, Jini George wrote: Thank you very much, David and Serguei for the review. David, based on your comments, I took a relook at

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-02-08 Thread Jini George
Thank you, David! - Jini. On 2/9/2018 9:18 AM, David Holmes wrote: Hi Jini, On 8/02/2018 6:59 PM, Jini George wrote: Thank you very much, David and Serguei for the review. David, based on your comments, I took a relook at the fix and I have modified it. Since this is an object array klass,

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-02-08 Thread David Holmes
Hi Jini, On 8/02/2018 6:59 PM, Jini George wrote: Thank you very much, David and Serguei for the review. David, based on your comments, I took a relook at the fix and I have modified it. Since this is an object array klass, the search for the method needs to be done among the methods of the

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-02-08 Thread Jini George
Thank you very much, David and Serguei for the review. David, based on your comments, I took a relook at the fix and I have modified it. Since this is an object array klass, the search for the method needs to be done among the methods of the superclass (java.lang.Object). The modified webrev

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-01-24 Thread David Holmes
Hi Jini, On 25/01/2018 3:43 AM, Jini George wrote: Hello, Requesting reviews for the issue: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes ID: https://bugs.openjdk.java.net/browse/JDK-8175384 Webrev: http://cr.openjdk.java.net/~jgeorge/8175384/webrev.01/

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-01-24 Thread serguei.spit...@oracle.com
Hi Jini, It looks good to me. Thanks, Serguei On 1/24/18 09:43, Jini George wrote: Hello, Requesting reviews for the issue: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes ID: https://bugs.openjdk.java.net/browse/JDK-8175384 Webrev: