Re: RFR (XS) 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
Thanks David. The follow up issue is: https://bugs.openjdk.java.net/browse/JDK-8237111 But there are more than the LingeredApps that use getVmOptions(). Somebody should make sure all these tests are getting the right values. thanks, Coleen On 1/14/20 4:56 PM, David Holmes wrote: Fix looks good - thanks Coleen. This one certainly had us scratching our heads for a while! I agree there should be a follow up issue about use of getVmOptions() in tests. David On 15/01/2020 5:38 am, coleen.phillim...@oracle.com wrote: Summary: Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings. Tested with hs-tier3 with no failures anymore. open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236917.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8236917 Thanks, Coleen
Re: RFR (XS) 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
Fix looks good - thanks Coleen. This one certainly had us scratching our heads for a while! I agree there should be a follow up issue about use of getVmOptions() in tests. David On 15/01/2020 5:38 am, coleen.phillim...@oracle.com wrote: Summary: Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings. Tested with hs-tier3 with no failures anymore. open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236917.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8236917 Thanks, Coleen
Re: RFR (XS) 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
Thanks Chris! Coleen On 1/14/20 3:57 PM, Chris Plummer wrote: Looks good. Thanks for fixing! Chris On 1/14/20 11:38 AM, coleen.phillim...@oracle.com wrote: Summary: Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings. Tested with hs-tier3 with no failures anymore. open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236917.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8236917 Thanks, Coleen
Re: RFR (XS) 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
On 1/14/20 3:45 PM, Leonid Mesnik wrote: Hi The fix looks good itself (you still need 'R'eview). However I see about 20 other SA/ tests where lingeredApp is still executed with vm.opts only. Even it doesn't cause any failures it means that tests silently ignore java.opts set by user. I think it makes sense to fix them also or file new issue for this activity. I'll file another bug for the other instances. I'm not sure that maybe we want to remove getVmOptions() with that bug, so as not to trick anyone else. Thanks, Coleen Leonid On 1/14/20 11:38 AM, coleen.phillim...@oracle.com wrote: Summary: Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings. Tested with hs-tier3 with no failures anymore. open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236917.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8236917 Thanks, Coleen
Re: RFR (XS) 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
Looks good. Thanks for fixing! Chris On 1/14/20 11:38 AM, coleen.phillim...@oracle.com wrote: Summary: Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings. Tested with hs-tier3 with no failures anymore. open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236917.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8236917 Thanks, Coleen
Re: RFR (XS) 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
Hi The fix looks good itself (you still need 'R'eview). However I see about 20 other SA/ tests where lingeredApp is still executed with vm.opts only. Even it doesn't cause any failures it means that tests silently ignore java.opts set by user. I think it makes sense to fix them also or file new issue for this activity. Leonid On 1/14/20 11:38 AM, coleen.phillim...@oracle.com wrote: Summary: Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings. Tested with hs-tier3 with no failures anymore. open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236917.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8236917 Thanks, Coleen
