Re: Review Request: JDK-8166237: jdk.jdi missing requires jdk.jdwp.agent

2016-09-18 Thread serguei.spit...@oracle.com 

It is good.

Thanks,
Serguei


On 9/17/16 10:11, Mandy Chung wrote:

diff --git a/src/jdk.jdi/share/classes/module-info.java 
b/src/jdk.jdi/share/classes/module-info.java
--- a/src/jdk.jdi/share/classes/module-info.java
+++ b/src/jdk.jdi/share/classes/module-info.java
@@ -25,6 +25,7 @@
  
  module jdk.jdi {

  requires jdk.attach;
+requires jdk.jdwp.agent;
  
  exports com.sun.jdi;

  exports com.sun.jdi.connect;


This dependency is needed for JDI launching connector to launch the target VM 
with debugger options that loads the JDWP agent.

Mandy

Re: Review Request: JDK-8166237: jdk.jdi missing requires jdk.jdwp.agent

2016-09-17 Thread Alan Bateman 

On 17/09/2016 10:11, Mandy Chung wrote:


diff --git a/src/jdk.jdi/share/classes/module-info.java 
b/src/jdk.jdi/share/classes/module-info.java
--- a/src/jdk.jdi/share/classes/module-info.java
+++ b/src/jdk.jdi/share/classes/module-info.java
@@ -25,6 +25,7 @@
  
  module jdk.jdi {

  requires jdk.attach;
+requires jdk.jdwp.agent;
  
  exports com.sun.jdi;

  exports com.sun.jdi.connect;



Looks good to me.

-Alan

Review Request: JDK-8166237: jdk.jdi missing requires jdk.jdwp.agent

2016-09-17 Thread Mandy Chung 
diff --git a/src/jdk.jdi/share/classes/module-info.java 
b/src/jdk.jdi/share/classes/module-info.java
--- a/src/jdk.jdi/share/classes/module-info.java
+++ b/src/jdk.jdi/share/classes/module-info.java
@@ -25,6 +25,7 @@
 
 module jdk.jdi {
 requires jdk.attach;
+requires jdk.jdwp.agent;
 
 exports com.sun.jdi;
 exports com.sun.jdi.connect;


This dependency is needed for JDI launching connector to launch the target VM 
with debugger options that loads the JDWP agent.

Mandy