On Mon, 4 Nov 2024 20:29:23 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>> This port was [deprecated for removal in JDK
>>> 21](https://openjdk.org/jeps/449) with the express intent to remove it in a
>>> future release.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update copyright years
I have now searched for `@[0-9]` to find instances of "stdcall-style" symbol
names, and fixed those. I have also done a wide sweep of searching for "@" in
general over the code base, which (unsurprisingly) generated a sh*tload of
hits. I tried to sift through this, using some mental heuristics to skip those
that are likely to be irrelevant, and scrutinized some other more carefully, to
identify any other code that might be working with name mangling/parsing. I
found no such code, outside of what I had already previously located.
At this point, I believe I have resolved all outstanding issues from the
reviews, and also finished fixing up the additional removal of the 32-bit
Windows calling convention remnants.
>From my PoV, what remains now is for me to repeat the in-depth testing of this
>PR, and to wait for the JEP to become targeted.
@shipilev @erikj79 @vnkozlov @kimbarrett I'd appreciate a re-review from you at
the current commit.
-
PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2455648651
PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2455651750
