Re: [Shinken-devel] Error in init.d/shinken-poller

2010-12-28 Thread Michael Jeanson
- Original Message - > Hi, > > > > a common init.d script for differents daemons? > > > > Yes, I would strongly discourage it from a packager > > perspective, it would > > make it harder to do split packages which are a great feature > > Sven's script can be configured by setting > AVAIL_

Re: [Shinken-devel] Error in init.d/shinken-poller

2010-12-28 Thread Gerhard Lausser
Hi, > > a common init.d script for differents daemons? > > Yes, I would strongly discourage it from a packager > perspective, it would > make it harder to do split packages which are a great feature Sven's script can be configured by setting AVAIL_MODULES="scheduler poller reactionner broker

Re: [Shinken-devel] Error in init.d/shinken-poller

2010-12-28 Thread Michael Jeanson
- Original Message - > It's done, push in progress. > > I must look at the doc and tests for using this new way. > > David and other packagers : is it a problem for the packages if we got > a common init.d script for differents daemons? Yes, I would strongly discourage it from a packager

Re: [Shinken-devel] Error in init.d/shinken-poller

2010-12-28 Thread nap
It's done, push in progress. I must look at the doc and tests for using this new way. David and other packagers : is it a problem for the packages if we got a common init.d script for differents daemons? Jean On Tue, Dec 28, 2010 at 10:35 AM, Sven Nierlein wrote: > Hi, > > On 28.12.2010 09:4

Re: [Shinken-devel] Error in init.d/shinken-poller

2010-12-28 Thread Sven Nierlein
Hi, On 28.12.2010 09:40, Klapproth, Martin wrote: > > Found an error in the shinken-poller init.d script (shinken version 0.4) > There is a new init.d script at bin/init.d/shinken which is able to start all parts of shinken. Usage: bin/init.d/shinken [ -d ] {start|stop|restart|status|check} [

Re: [Shinken-devel] Error in init.d/shinken-poller

2010-12-28 Thread Hartmut Goebel
Am 28.12.2010 09:40, schrieb Klapproth, Martin: > must be replaced with > > - kill `cat $PIDFILE` > This is bas shell style: a) Usage of backticks are discouraged, use $(...) instead, which in addition is POSIX. b) "unnecessary usage of cat". Should be kill < $PIDFILE Being in nitpicking mod

Re: [Shinken-devel] Error in init.d/shinken-poller

2010-12-28 Thread Klapproth, Martin
inken-devel@lists.sourceforge.net Subject: Re: [Shinken-devel] Error in init.d/shinken-poller Hi, The POLLERPID is defined in the /etc/default/shinken file if I'm not wrong. It's defined in the installation with the setup.py. You can change it after with this file. Where the PIDFILE va

Re: [Shinken-devel] Error in init.d/shinken-poller

2010-12-28 Thread nap
Hi, The POLLERPID is defined in the /etc/default/shinken file if I'm not wrong. It's defined in the installation with the setup.py. You can change it after with this file. Where the PIDFILE value is pointing? I don't see it initialized inte h init.d file. Jean On Tue, Dec 28, 2010 at 9:40 AM, K

[Shinken-devel] Error in init.d/shinken-poller

2010-12-28 Thread Klapproth, Martin
Found an error in the shinken-poller init.d script (shinken version 0.4) Line 102: - kill `cat $POLLERPID` must be replaced with - kill `cat $PIDFILE` $POLLERPID holds the default pid file path /var/lib/shinken/pollerd.pid That works great when you don't change the pid file path.