Re: [Shinken-devel] Questions about external_mapping.py

2012-07-13 Thread Hartmut Goebel
Am 09.07.2012 12:00, schrieb Olivier Hanesse: > Indeed, we can also remove spaces in host /vm-name to make it more robust. Okay, I'm change it. Are hash-sigens allowed in host-names? If not, I'd add the comment-lines (starting with a hash), too. (This is cheap and may be useful.) -- Schönen Gru

Re: [Shinken-devel] Questions about external_mapping.py

2012-07-09 Thread Olivier Hanesse
2012/7/7 Hartmut Goebel > Hi, > > when cleaning up comments, I just stepped over external_mapping.py. > > * The input-file is a text file, isn't it? So why is it read in binary > mode? > > Indeed, it is a bug, we can remove the 'b' part. > * Leading/trailing spaces in host- and vm-names are pr

[Shinken-devel] Questions about external_mapping.py

2012-07-07 Thread Hartmut Goebel
Hi, when cleaning up comments, I just stepped over external_mapping.py. * The input-file is a text file, isn't it? So why is it read in binary mode? * Leading/trailing spaces in host- and vm-names are preserved is this intended? Are names allowed to contains spaces at all? If not, i would change