Re: [shogun] Automatize Code Style Checks

2017-04-05 Thread Heiko Strathmann
On Wed, 5 Apr 2017 at 10:19, Fernando J. Iglesias García < fernando.igles...@shogun-toolbox.org> wrote: > Automatising style checks is indeed something very nice to have. > > I think it is worth to take into account that labelling a PR as failure > because of style failures might make the

Re: [shogun] Automatize Code Style Checks

2017-04-05 Thread Fernando J . Iglesias García
Automatising style checks is indeed something very nice to have. I think it is worth to take into account that labelling a PR as failure because of style failures might make the process of getting into contributing to Shogun less friendly for newcomers. On 5 April 2017 at 10:10, Viktor Gal

Re: [shogun] Automatize Code Style Checks

2017-04-05 Thread Viktor Gal
Hi Giovanni great idea! there’s already a clang-format file in my shogun folder for a while… but it was never finished as there was always something else to be worked on. lemme try to dig it up for you the formatting file - as far as i’ve got with it - and then we could finish that together? +

[shogun] Automatize Code Style Checks

2017-04-05 Thread Giovanni De Toni
Hello everybody, Since I noticed that many of the developers' comments on PRs are targeted to fix code formatting and style, I thought it would be very useful to have a way to reduce the time spent on these small issues (and therefore, gain more time to focus on the "working" code). There is a