Hi,
great stuff so far! see my answers below.
> On 22 Jul 2019, at 20:48, Ahmed Essam wrote:
>
> Regarding using spdlog, here are the assumptions:
> 1. There will be only one global SGIO object for logging.
> 2. Two streams are used: stdout (for all log levels except for MSG_ERROR) and
>
see inline
Am Di., 23. Juli 2019 um 14:39 Uhr schrieb Ahmed Essam <
theartful...@gmail.com>:
> Hi Fernando,
>
> I think Heiko's point was regarding the global Shogun object you mentioned
>> in the first e-mail.
>
>
> Any logging function in SGIO will be thread safe and non-blocking.
> Changing
Hey Ahmed,
On Mon, 22 Jul 2019 at 23:33, Ahmed Essam wrote:
> Thanks for the feedback!
>
> spdlog is friendly with multi threaded code. In fact, I currently use in
> the PR (as viktor suggested) an async logger, which does the logging in a
> different thread altogether.
>
I think Heiko's point
Thanks for the feedback!
spdlog is friendly with multi threaded code. In fact, I currently use in
the PR (as viktor suggested) an async logger, which does the logging in a
different thread altogether.
Regarding the exposure of spdlog, I can add the functionality for directing
streams to files,
