Re: [sigrok-devel] [PATCH 1/4] Change arguments of gpif_make_delay_state() to remove layering violation

On 07/15/2016 10:19 PM, Paul Fertser wrote: > This function is called only for adding delay states to the waveform > so OPCODE is always the same. > > While at it, fix confusing comments. > LGTM /Benjamin -- What

[sigrok-devel] [PATCH 4/4] Refactor and bugfix the delay adding code for analog capture

There're two essential modifications in this change: 1. Fix timing for capture frequencies less than 200 kHz; 2. Sample ADC output after CLK is set low, as per the TLC5510 datasheet. The second point is also important as the capture state sets CLK low, so with the previous code there might have

[sigrok-devel] [PATCH 3/4] Remove bogus part of OUTPUT used for analog sampling

Since TRICTL = 0, FX2 always either pushes or pulls the CTLx pins. Signed-off-by: Paul Fertser --- gpif-acquisition.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gpif-acquisition.c b/gpif-acquisition.c index 57e852b..09a56ca 100644 ---