Hi Rudolf,
On Fri, Sep 16, 2016 at 01:39:14PM +0200, Rudolf Reuter wrote:
> I have developed a new sigrok decoder - gpib.
> The project is hosted on Github, see:
> https://github.com/rudi48/sigrok-gpib
>
> It would be helpful, if somebody could please test it, and give me feedback.
Looks good, thanks a lot for working on this.
I've done some cleanups and fixes on the decoder itself and then merged it:
- Fixed channel names ('id' fields all-lowercase, use GPIB standard
naming such as "DIO1" etc.)
- All channels are required (non-optional) for now, not entirely sure
how many of them are *actually* optional in real-life (for the
decoder). Maybe REN?
- I dropped various debug prints and such, those don't belong upstream
in the PD (but can be useful during development, it's one method to
simplify PD development or to debug issues).
- Dropped/simplified some random other stuff, mostly unused chunks of
the 'parallel' PD this one was based on. Specifically, the CLK pin
is now also gone, there's no CLK in GPIB.
- There's a few more things that could be simplified or clarified in
the PD, I might have another look at some later point at those maybe.
- I kept the 'sample_total' for now as a temporary workaround, but we'll
eventually have a more generic method to handle this kind of stuff
in libsigrokdecode (end of stream).
- Both .py files are now (C) Copyright Rudolf Reuter <reute...@arcor.de>,
there's pretty much nothing left of the 'parallel' PD which would
warrant having my Copyright lines in the GPIB decoder.
I've also added your *.sr example file to our sigrok-dumps repo with a
small additional README (and some renaming of the channels for better
readability).
Finally, I've added a test-case in our sigrok-test repo so we can verify
that the PD works as intended, and keeps doing so when we change
libsigrokdecode later on.
Details here:
http://sigrok.org/gitweb/?p=libsigrokdecode.git;a=commit;h=ffd58b683fc200c3bfb96a274dd2bc5c4cea7dcc
http://sigrok.org/gitweb/?p=sigrok-dumps.git;a=commit;h=55aca15dd789daa407244173a0fdb52ed099b164
http://sigrok.org/gitweb/?p=sigrok-test.git;a=commit;h=0c804ea53c3057e728f98fa9d4264b449333ee6e
If you could provide some more files for sigrok-dumps / sigrok-test with
more GPIB traffic in them (different devices, different GPIB commands and
such) that would be great! It'll surely prove very useful to
test/improve the decoder some more.
Cheers, Uwe.
--
http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
