Re: [Simulavr-devel] Extended python interface: SetAnalog

2010-07-23 Thread ThomasK
Hi Sebastian, I don't have any ideas what to improve. Would it do any harm to push the change to the main branch, so you don't need to merge updates? fyi: your patch is now uploaded to master branch. cu, Thomas ___ Simulavr-devel mailing list Simu

Re: [Simulavr-devel] Extended python interface: SetAnalog

2010-07-17 Thread Thomas Klepp
Hi Sebastian, I don't plan to do more on ADC stuff - what I've done seems to be good enough for my use-case (test an AVR application by a python script), so I don't have any ideas what to improve. Would it do any harm to push the change to the main branch, so you don't need to merge updates? O

Re: [Simulavr-devel] Extended python interface: SetAnalog

2010-07-16 Thread Raphaël Martin
Le dimanche 11 jui 2010 à 22:15:28 (+0200), Sebastian écrivait : > Has anyone thought about implementing TWI, yet? Any hints where to > start, whats missing, what the difficult bits are? > > Or is someone already working on TWI and just needs some help in > testing? I'd like to do that :-) Well,

Re: [Simulavr-devel] Extended python interface: SetAnalog

2010-07-11 Thread Petr Hluzín
Hi Sebastian and list On 11 July 2010 22:15, Sebastian wrote: > Maybe I'll try to implement TWI. But I've no plans yet, when to start - > so don't expect results too soon (or at all). This is my style of contributing, too. > Has anyone thought about implementing TWI, yet? Any hints where to > s

Re: [Simulavr-devel] Extended python interface: SetAnalog

2010-07-11 Thread Sebastian
Hi Thomas, > > Can I get commit rights or do you prefer to push it yourself? > > If you plan to do more, then it could be a good idea to become a project > member. In this case I would create a topic branch for your changes on > adc stuff. I don't plan to do more on ADC stuff - what I've done

Re: [Simulavr-devel] Extended python interface: SetAnalog

2010-07-09 Thread ThomasK
Hi Sebastian, last days I've tried your patch. I think the output of "Pin::operator char" was inconsistent with "Pin::operator=", so i swapped "A" and "a" there. Is this ok? Or should the swap be done in "Pin::operator="? Or was the inconsistency deliberate? Yes, this is a bug. I (!!) would p

Re: [Simulavr-devel] Extended python interface: SetAnalog

2010-07-04 Thread ThomasK
Hi sebastian, thanks for this change. I'll check it, but it could take some time. Sebastian schrieb: Hi, I extended the python interface so that you can simulate ADC inputs. Can you please review the attached commit? Can I get commit rights or do you prefer to push it yourself? I think, I'll

[Simulavr-devel] Extended python interface: SetAnalog

2010-07-03 Thread Sebastian
Hi, I extended the python interface so that you can simulate ADC inputs. Can you please review the attached commit? Can I get commit rights or do you prefer to push it yourself? Some questions for the review: I think the output of "Pin::operator char" was inconsistent with "Pin::operator=", so i