Modified: websites/production/maven/components/plugins-archives/maven-pmd-plugin-LATEST/xref-test/org/apache/maven/plugin/pmd/PmdReportTest.html ============================================================================== --- websites/production/maven/components/plugins-archives/maven-pmd-plugin-LATEST/xref-test/org/apache/maven/plugin/pmd/PmdReportTest.html (original) +++ websites/production/maven/components/plugins-archives/maven-pmd-plugin-LATEST/xref-test/org/apache/maven/plugin/pmd/PmdReportTest.html Mon May 1 07:24:19 2017 @@ -99,232 +99,232 @@ <a class="jxr_linenumber" name="L91" href="#L91">91</a> assertTrue( str.contains( <span class="jxr_string">"/xref/def/configuration/AppSample.html#L45"</span> ) ); <a class="jxr_linenumber" name="L92" href="#L92">92</a> } <a class="jxr_linenumber" name="L93" href="#L93">93</a> -<a class="jxr_linenumber" name="L94" href="#L94">94</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testJavascriptConfiguration() -<a class="jxr_linenumber" name="L95" href="#L95">95</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L94" href="#L94">94</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testDefaultConfigurationWithAnalysisCache() +<a class="jxr_linenumber" name="L95" href="#L95">95</a> <strong class="jxr_keyword">throws</strong> Exception <a class="jxr_linenumber" name="L96" href="#L96">96</a> { -<a class="jxr_linenumber" name="L97" href="#L97">97</a> File testPom = -<a class="jxr_linenumber" name="L98" href="#L98">98</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L99" href="#L99">99</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/javascript-configuration-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L100" href="#L100">100</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L101" href="#L101">101</a> mojo.execute(); -<a class="jxr_linenumber" name="L102" href="#L102">102</a> -<a class="jxr_linenumber" name="L103" href="#L103">103</a> <em class="jxr_comment">// check if the PMD files were generated</em> -<a class="jxr_linenumber" name="L104" href="#L104">104</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L105" href="#L105">105</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L97" href="#L97">97</a> FileUtils.copyDirectoryStructure( <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L98" href="#L98">98</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/jxr-files"</span> ), +<a class="jxr_linenumber" name="L99" href="#L99">99</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/pmd-with-analysis-cache-plugin-config/target/site"</span> ) ); +<a class="jxr_linenumber" name="L100" href="#L100">100</a> +<a class="jxr_linenumber" name="L101" href="#L101">101</a> File testPom = +<a class="jxr_linenumber" name="L102" href="#L102">102</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L103" href="#L103">103</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/pmd-with-analysis-cache-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L104" href="#L104">104</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L105" href="#L105">105</a> mojo.execute(); <a class="jxr_linenumber" name="L106" href="#L106">106</a> -<a class="jxr_linenumber" name="L107" href="#L107">107</a> <em class="jxr_comment">// these are the rulesets, that have been applied...</em> -<a class="jxr_linenumber" name="L108" href="#L108">108</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/ecmascript-basic.xml"</span> ); -<a class="jxr_linenumber" name="L109" href="#L109">109</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L110" href="#L110">110</a> -<a class="jxr_linenumber" name="L111" href="#L111">111</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/ecmascript-braces.xml"</span> ); -<a class="jxr_linenumber" name="L112" href="#L112">112</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L113" href="#L113">113</a> -<a class="jxr_linenumber" name="L114" href="#L114">114</a> generatedFile = -<a class="jxr_linenumber" name="L115" href="#L115">115</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/ecmascript-unnecessary.xml"</span> ); -<a class="jxr_linenumber" name="L116" href="#L116">116</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L117" href="#L117">117</a> -<a class="jxr_linenumber" name="L118" href="#L118">118</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L119" href="#L119">119</a> renderer( mojo, generatedFile ); -<a class="jxr_linenumber" name="L120" href="#L120">120</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L121" href="#L121">121</a> -<a class="jxr_linenumber" name="L122" href="#L122">122</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L123" href="#L123">123</a> assertTrue( str.contains( <span class="jxr_string">"Avoid using global variables"</span> ) ); -<a class="jxr_linenumber" name="L124" href="#L124">124</a> } -<a class="jxr_linenumber" name="L125" href="#L125">125</a> -<a class="jxr_linenumber" name="L126" href="#L126">126</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testFileURL() -<a class="jxr_linenumber" name="L127" href="#L127">127</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L128" href="#L128">128</a> { -<a class="jxr_linenumber" name="L129" href="#L129">129</a> FileUtils.copyDirectoryStructure( <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L130" href="#L130">130</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/jxr-files"</span> ), -<a class="jxr_linenumber" name="L131" href="#L131">131</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site"</span> ) ); -<a class="jxr_linenumber" name="L132" href="#L132">132</a> -<a class="jxr_linenumber" name="L133" href="#L133">133</a> File testPom = -<a class="jxr_linenumber" name="L134" href="#L134">134</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L135" href="#L135">135</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/default-configuration-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L136" href="#L136">136</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L137" href="#L137">137</a> -<a class="jxr_linenumber" name="L138" href="#L138">138</a> <em class="jxr_comment">// Additional test case for MPMD-174 (http://jira.codehaus.org/browse/MPMD-174).</em> -<a class="jxr_linenumber" name="L139" href="#L139">139</a> WireMockServer mockServer = <strong class="jxr_keyword">new</strong> WireMockServer( 3456 ); -<a class="jxr_linenumber" name="L140" href="#L140">140</a> mockServer.start(); -<a class="jxr_linenumber" name="L141" href="#L141">141</a> -<a class="jxr_linenumber" name="L142" href="#L142">142</a> String sonarRuleset = -<a class="jxr_linenumber" name="L143" href="#L143">143</a> IOUtils.toString( getClass().getClassLoader().getResourceAsStream( <span class="jxr_string">"unit/default-configuration/rulesets/sonar-way-ruleset.xml"</span> ), -<a class="jxr_linenumber" name="L144" href="#L144">144</a> StandardCharsets.UTF_8 ); -<a class="jxr_linenumber" name="L145" href="#L145">145</a> -<a class="jxr_linenumber" name="L146" href="#L146">146</a> String sonarMainPageHtml = -<a class="jxr_linenumber" name="L147" href="#L147">147</a> IOUtils.toString( getClass().getClassLoader().getResourceAsStream( <span class="jxr_string">"unit/default-configuration/rulesets/sonar-main-page.html"</span> ), -<a class="jxr_linenumber" name="L148" href="#L148">148</a> StandardCharsets.UTF_8 ); -<a class="jxr_linenumber" name="L149" href="#L149">149</a> -<a class="jxr_linenumber" name="L150" href="#L150">150</a> <strong class="jxr_keyword">final</strong> String sonarBaseUrl = <span class="jxr_string">"/profiles"</span>; -<a class="jxr_linenumber" name="L151" href="#L151">151</a> <strong class="jxr_keyword">final</strong> String sonarProfileUrl = sonarBaseUrl + <span class="jxr_string">"/export?format=pmd&language=java&name=Sonar%2520way"</span>; -<a class="jxr_linenumber" name="L152" href="#L152">152</a> <strong class="jxr_keyword">final</strong> String sonarExportRulesetUrl = <span class="jxr_string">"http://localhost:"</span> + mockServer.port() + sonarProfileUrl; -<a class="jxr_linenumber" name="L153" href="#L153">153</a> -<a class="jxr_linenumber" name="L154" href="#L154">154</a> mockServer.stubFor( WireMock.get( WireMock.urlEqualTo( sonarBaseUrl ) ).willReturn( WireMock.aResponse().withStatus( 200 ).withHeader( <span class="jxr_string">"Content-Type"</span>, -<a class="jxr_linenumber" name="L155" href="#L155">155</a> <span class="jxr_string">"text/html"</span> ).withBody( sonarMainPageHtml ) ) ); -<a class="jxr_linenumber" name="L156" href="#L156">156</a> -<a class="jxr_linenumber" name="L157" href="#L157">157</a> mockServer.stubFor( WireMock.get( WireMock.urlEqualTo( sonarProfileUrl ) ).willReturn( WireMock.aResponse().withStatus( 200 ).withHeader( <span class="jxr_string">"Content-Type"</span>, -<a class="jxr_linenumber" name="L158" href="#L158">158</a> <span class="jxr_string">"text/xml"</span> ).withBody( sonarRuleset ) ) ); +<a class="jxr_linenumber" name="L107" href="#L107">107</a> <em class="jxr_comment">// check if the PMD analysis cache file has been generated</em> +<a class="jxr_linenumber" name="L108" href="#L108">108</a> File cacheFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/pmd-with-analysis-cache-plugin-config/target/pmd/pmd.cache"</span> ); +<a class="jxr_linenumber" name="L109" href="#L109">109</a> assertTrue( FileUtils.fileExists( cacheFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L110" href="#L110">110</a> } +<a class="jxr_linenumber" name="L111" href="#L111">111</a> +<a class="jxr_linenumber" name="L112" href="#L112">112</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testJavascriptConfiguration() +<a class="jxr_linenumber" name="L113" href="#L113">113</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L114" href="#L114">114</a> { +<a class="jxr_linenumber" name="L115" href="#L115">115</a> File testPom = +<a class="jxr_linenumber" name="L116" href="#L116">116</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L117" href="#L117">117</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/javascript-configuration-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L118" href="#L118">118</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L119" href="#L119">119</a> mojo.execute(); +<a class="jxr_linenumber" name="L120" href="#L120">120</a> +<a class="jxr_linenumber" name="L121" href="#L121">121</a> <em class="jxr_comment">// check if the PMD files were generated</em> +<a class="jxr_linenumber" name="L122" href="#L122">122</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); +<a class="jxr_linenumber" name="L123" href="#L123">123</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L124" href="#L124">124</a> +<a class="jxr_linenumber" name="L125" href="#L125">125</a> <em class="jxr_comment">// these are the rulesets, that have been applied...</em> +<a class="jxr_linenumber" name="L126" href="#L126">126</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/ecmascript-basic.xml"</span> ); +<a class="jxr_linenumber" name="L127" href="#L127">127</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L128" href="#L128">128</a> +<a class="jxr_linenumber" name="L129" href="#L129">129</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/ecmascript-braces.xml"</span> ); +<a class="jxr_linenumber" name="L130" href="#L130">130</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L131" href="#L131">131</a> +<a class="jxr_linenumber" name="L132" href="#L132">132</a> generatedFile = +<a class="jxr_linenumber" name="L133" href="#L133">133</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/ecmascript-unnecessary.xml"</span> ); +<a class="jxr_linenumber" name="L134" href="#L134">134</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L135" href="#L135">135</a> +<a class="jxr_linenumber" name="L136" href="#L136">136</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L137" href="#L137">137</a> renderer( mojo, generatedFile ); +<a class="jxr_linenumber" name="L138" href="#L138">138</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L139" href="#L139">139</a> +<a class="jxr_linenumber" name="L140" href="#L140">140</a> String str = readFile( generatedFile ); +<a class="jxr_linenumber" name="L141" href="#L141">141</a> assertTrue( str.contains( <span class="jxr_string">"Avoid using global variables"</span> ) ); +<a class="jxr_linenumber" name="L142" href="#L142">142</a> } +<a class="jxr_linenumber" name="L143" href="#L143">143</a> +<a class="jxr_linenumber" name="L144" href="#L144">144</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testFileURL() +<a class="jxr_linenumber" name="L145" href="#L145">145</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L146" href="#L146">146</a> { +<a class="jxr_linenumber" name="L147" href="#L147">147</a> FileUtils.copyDirectoryStructure( <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L148" href="#L148">148</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/jxr-files"</span> ), +<a class="jxr_linenumber" name="L149" href="#L149">149</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site"</span> ) ); +<a class="jxr_linenumber" name="L150" href="#L150">150</a> +<a class="jxr_linenumber" name="L151" href="#L151">151</a> File testPom = +<a class="jxr_linenumber" name="L152" href="#L152">152</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L153" href="#L153">153</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/default-configuration-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L154" href="#L154">154</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L155" href="#L155">155</a> +<a class="jxr_linenumber" name="L156" href="#L156">156</a> <em class="jxr_comment">// Additional test case for MPMD-174 (https://issues.apache.org/jira/browse/MPMD-174).</em> +<a class="jxr_linenumber" name="L157" href="#L157">157</a> WireMockServer mockServer = <strong class="jxr_keyword">new</strong> WireMockServer( 3456 ); +<a class="jxr_linenumber" name="L158" href="#L158">158</a> mockServer.start(); <a class="jxr_linenumber" name="L159" href="#L159">159</a> -<a class="jxr_linenumber" name="L160" href="#L160">160</a> URL url = getClass().getClassLoader().getResource( <span class="jxr_string">"rulesets/java/basic.xml"</span> ); -<a class="jxr_linenumber" name="L161" href="#L161">161</a> URL url2 = getClass().getClassLoader().getResource( <span class="jxr_string">"rulesets/java/unusedcode.xml"</span> ); -<a class="jxr_linenumber" name="L162" href="#L162">162</a> URL url3 = getClass().getClassLoader().getResource( <span class="jxr_string">"rulesets/java/imports.xml"</span> ); -<a class="jxr_linenumber" name="L163" href="#L163">163</a> mojo.setRulesets( <strong class="jxr_keyword">new</strong> String[] { url.toString(), url2.toString(), url3.toString(), sonarExportRulesetUrl } ); -<a class="jxr_linenumber" name="L164" href="#L164">164</a> -<a class="jxr_linenumber" name="L165" href="#L165">165</a> mojo.execute(); -<a class="jxr_linenumber" name="L166" href="#L166">166</a> -<a class="jxr_linenumber" name="L167" href="#L167">167</a> <em class="jxr_comment">// check if the PMD files were generated</em> -<a class="jxr_linenumber" name="L168" href="#L168">168</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L169" href="#L169">169</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L170" href="#L170">170</a> -<a class="jxr_linenumber" name="L171" href="#L171">171</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/basic.xml"</span> ); -<a class="jxr_linenumber" name="L172" href="#L172">172</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L173" href="#L173">173</a> -<a class="jxr_linenumber" name="L174" href="#L174">174</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/imports.xml"</span> ); -<a class="jxr_linenumber" name="L175" href="#L175">175</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L176" href="#L176">176</a> -<a class="jxr_linenumber" name="L177" href="#L177">177</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/unusedcode.xml"</span> ); -<a class="jxr_linenumber" name="L178" href="#L178">178</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L179" href="#L179">179</a> -<a class="jxr_linenumber" name="L180" href="#L180">180</a> generatedFile = -<a class="jxr_linenumber" name="L181" href="#L181">181</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L182" href="#L182">182</a> <span class="jxr_string">"target/test/unit/default-configuration/target/export_format_pmd_language_java_name_Sonar_2520way.xml"</span> ); -<a class="jxr_linenumber" name="L183" href="#L183">183</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L160" href="#L160">160</a> String sonarRuleset = +<a class="jxr_linenumber" name="L161" href="#L161">161</a> IOUtils.toString( getClass().getClassLoader().getResourceAsStream( <span class="jxr_string">"unit/default-configuration/rulesets/sonar-way-ruleset.xml"</span> ), +<a class="jxr_linenumber" name="L162" href="#L162">162</a> StandardCharsets.UTF_8 ); +<a class="jxr_linenumber" name="L163" href="#L163">163</a> +<a class="jxr_linenumber" name="L164" href="#L164">164</a> String sonarMainPageHtml = +<a class="jxr_linenumber" name="L165" href="#L165">165</a> IOUtils.toString( getClass().getClassLoader().getResourceAsStream( <span class="jxr_string">"unit/default-configuration/rulesets/sonar-main-page.html"</span> ), +<a class="jxr_linenumber" name="L166" href="#L166">166</a> StandardCharsets.UTF_8 ); +<a class="jxr_linenumber" name="L167" href="#L167">167</a> +<a class="jxr_linenumber" name="L168" href="#L168">168</a> <strong class="jxr_keyword">final</strong> String sonarBaseUrl = <span class="jxr_string">"/profiles"</span>; +<a class="jxr_linenumber" name="L169" href="#L169">169</a> <strong class="jxr_keyword">final</strong> String sonarProfileUrl = sonarBaseUrl + <span class="jxr_string">"/export?format=pmd&language=java&name=Sonar%2520way"</span>; +<a class="jxr_linenumber" name="L170" href="#L170">170</a> <strong class="jxr_keyword">final</strong> String sonarExportRulesetUrl = <span class="jxr_string">"http://localhost:"</span> + mockServer.port() + sonarProfileUrl; +<a class="jxr_linenumber" name="L171" href="#L171">171</a> +<a class="jxr_linenumber" name="L172" href="#L172">172</a> mockServer.stubFor( WireMock.get( WireMock.urlEqualTo( sonarBaseUrl ) ).willReturn( WireMock.aResponse().withStatus( 200 ).withHeader( <span class="jxr_string">"Content-Type"</span>, +<a class="jxr_linenumber" name="L173" href="#L173">173</a> <span class="jxr_string">"text/html"</span> ).withBody( sonarMainPageHtml ) ) ); +<a class="jxr_linenumber" name="L174" href="#L174">174</a> +<a class="jxr_linenumber" name="L175" href="#L175">175</a> mockServer.stubFor( WireMock.get( WireMock.urlEqualTo( sonarProfileUrl ) ).willReturn( WireMock.aResponse().withStatus( 200 ).withHeader( <span class="jxr_string">"Content-Type"</span>, +<a class="jxr_linenumber" name="L176" href="#L176">176</a> <span class="jxr_string">"text/xml"</span> ).withBody( sonarRuleset ) ) ); +<a class="jxr_linenumber" name="L177" href="#L177">177</a> +<a class="jxr_linenumber" name="L178" href="#L178">178</a> URL url = getClass().getClassLoader().getResource( <span class="jxr_string">"rulesets/java/basic.xml"</span> ); +<a class="jxr_linenumber" name="L179" href="#L179">179</a> URL url2 = getClass().getClassLoader().getResource( <span class="jxr_string">"rulesets/java/unusedcode.xml"</span> ); +<a class="jxr_linenumber" name="L180" href="#L180">180</a> URL url3 = getClass().getClassLoader().getResource( <span class="jxr_string">"rulesets/java/imports.xml"</span> ); +<a class="jxr_linenumber" name="L181" href="#L181">181</a> mojo.setRulesets( <strong class="jxr_keyword">new</strong> String[] { url.toString(), url2.toString(), url3.toString(), sonarExportRulesetUrl } ); +<a class="jxr_linenumber" name="L182" href="#L182">182</a> +<a class="jxr_linenumber" name="L183" href="#L183">183</a> mojo.execute(); <a class="jxr_linenumber" name="L184" href="#L184">184</a> -<a class="jxr_linenumber" name="L185" href="#L185">185</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L186" href="#L186">186</a> renderer( mojo, generatedFile ); +<a class="jxr_linenumber" name="L185" href="#L185">185</a> <em class="jxr_comment">// check if the PMD files were generated</em> +<a class="jxr_linenumber" name="L186" href="#L186">186</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); <a class="jxr_linenumber" name="L187" href="#L187">187</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L188" href="#L188">188</a> -<a class="jxr_linenumber" name="L189" href="#L189">189</a> <em class="jxr_comment">// check if there's a link to the JXR files</em> -<a class="jxr_linenumber" name="L190" href="#L190">190</a> String str = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ) ); +<a class="jxr_linenumber" name="L189" href="#L189">189</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/basic.xml"</span> ); +<a class="jxr_linenumber" name="L190" href="#L190">190</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L191" href="#L191">191</a> -<a class="jxr_linenumber" name="L192" href="#L192">192</a> assertTrue( str.contains( <span class="jxr_string">"/xref/def/configuration/App.html#L31"</span> ) ); -<a class="jxr_linenumber" name="L193" href="#L193">193</a> -<a class="jxr_linenumber" name="L194" href="#L194">194</a> assertTrue( str.contains( <span class="jxr_string">"/xref/def/configuration/AppSample.html#L45"</span> ) ); -<a class="jxr_linenumber" name="L195" href="#L195">195</a> -<a class="jxr_linenumber" name="L196" href="#L196">196</a> mockServer.stop(); -<a class="jxr_linenumber" name="L197" href="#L197">197</a> } -<a class="jxr_linenumber" name="L198" href="#L198">198</a> -<a class="jxr_linenumber" name="L199" href="#L199">199</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L200" href="#L200">200</a> <em class="jxr_javadoccomment"> * With custom rulesets</em> -<a class="jxr_linenumber" name="L201" href="#L201">201</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L202" href="#L202">202</a> <em class="jxr_javadoccomment"> * @throws Exception</em> -<a class="jxr_linenumber" name="L203" href="#L203">203</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L204" href="#L204">204</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testCustomConfiguration() -<a class="jxr_linenumber" name="L205" href="#L205">205</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L206" href="#L206">206</a> { -<a class="jxr_linenumber" name="L207" href="#L207">207</a> File testPom = -<a class="jxr_linenumber" name="L208" href="#L208">208</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L209" href="#L209">209</a> <span class="jxr_string">"src/test/resources/unit/custom-configuration/custom-configuration-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L210" href="#L210">210</a> -<a class="jxr_linenumber" name="L211" href="#L211">211</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L212" href="#L212">212</a> mojo.execute(); +<a class="jxr_linenumber" name="L192" href="#L192">192</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/imports.xml"</span> ); +<a class="jxr_linenumber" name="L193" href="#L193">193</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L194" href="#L194">194</a> +<a class="jxr_linenumber" name="L195" href="#L195">195</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/unusedcode.xml"</span> ); +<a class="jxr_linenumber" name="L196" href="#L196">196</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L197" href="#L197">197</a> +<a class="jxr_linenumber" name="L198" href="#L198">198</a> generatedFile = +<a class="jxr_linenumber" name="L199" href="#L199">199</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L200" href="#L200">200</a> <span class="jxr_string">"target/test/unit/default-configuration/target/export_format_pmd_language_java_name_Sonar_2520way.xml"</span> ); +<a class="jxr_linenumber" name="L201" href="#L201">201</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L202" href="#L202">202</a> +<a class="jxr_linenumber" name="L203" href="#L203">203</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L204" href="#L204">204</a> renderer( mojo, generatedFile ); +<a class="jxr_linenumber" name="L205" href="#L205">205</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L206" href="#L206">206</a> +<a class="jxr_linenumber" name="L207" href="#L207">207</a> <em class="jxr_comment">// check if there's a link to the JXR files</em> +<a class="jxr_linenumber" name="L208" href="#L208">208</a> String str = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ) ); +<a class="jxr_linenumber" name="L209" href="#L209">209</a> +<a class="jxr_linenumber" name="L210" href="#L210">210</a> assertTrue( str.contains( <span class="jxr_string">"/xref/def/configuration/App.html#L31"</span> ) ); +<a class="jxr_linenumber" name="L211" href="#L211">211</a> +<a class="jxr_linenumber" name="L212" href="#L212">212</a> assertTrue( str.contains( <span class="jxr_string">"/xref/def/configuration/AppSample.html#L45"</span> ) ); <a class="jxr_linenumber" name="L213" href="#L213">213</a> -<a class="jxr_linenumber" name="L214" href="#L214">214</a> <em class="jxr_comment">// check the generated files</em> -<a class="jxr_linenumber" name="L215" href="#L215">215</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/pmd.csv"</span> ); -<a class="jxr_linenumber" name="L216" href="#L216">216</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L217" href="#L217">217</a> -<a class="jxr_linenumber" name="L218" href="#L218">218</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/custom.xml"</span> ); -<a class="jxr_linenumber" name="L219" href="#L219">219</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L220" href="#L220">220</a> -<a class="jxr_linenumber" name="L221" href="#L221">221</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L222" href="#L222">222</a> renderer( mojo, generatedFile ); -<a class="jxr_linenumber" name="L223" href="#L223">223</a> renderer( mojo, generatedFile ); -<a class="jxr_linenumber" name="L224" href="#L224">224</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L225" href="#L225">225</a> -<a class="jxr_linenumber" name="L226" href="#L226">226</a> <em class="jxr_comment">// check if custom ruleset was applied</em> -<a class="jxr_linenumber" name="L227" href="#L227">227</a> String str = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ) ); -<a class="jxr_linenumber" name="L228" href="#L228">228</a> assertTrue( lowerCaseContains( str, <span class="jxr_string">"Avoid using if statements without curly braces"</span> ) ); -<a class="jxr_linenumber" name="L229" href="#L229">229</a> -<a class="jxr_linenumber" name="L230" href="#L230">230</a> <em class="jxr_comment">// Must be false as IfElseStmtsMustUseBraces is excluded!</em> -<a class="jxr_linenumber" name="L231" href="#L231">231</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"Avoid using if...else statements without curly braces"</span> ) ); -<a class="jxr_linenumber" name="L232" href="#L232">232</a> -<a class="jxr_linenumber" name="L233" href="#L233">233</a> assertFalse( <span class="jxr_string">"unnecessary constructor should not be triggered because of low priority"</span>, -<a class="jxr_linenumber" name="L234" href="#L234">234</a> lowerCaseContains( str, <span class="jxr_string">"Avoid unnecessary constructors - the compiler will generate these for you"</span> ) ); +<a class="jxr_linenumber" name="L214" href="#L214">214</a> mockServer.stop(); +<a class="jxr_linenumber" name="L215" href="#L215">215</a> } +<a class="jxr_linenumber" name="L216" href="#L216">216</a> +<a class="jxr_linenumber" name="L217" href="#L217">217</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L218" href="#L218">218</a> <em class="jxr_javadoccomment"> * With custom rulesets</em> +<a class="jxr_linenumber" name="L219" href="#L219">219</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L220" href="#L220">220</a> <em class="jxr_javadoccomment"> * @throws Exception</em> +<a class="jxr_linenumber" name="L221" href="#L221">221</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L222" href="#L222">222</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testCustomConfiguration() +<a class="jxr_linenumber" name="L223" href="#L223">223</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L224" href="#L224">224</a> { +<a class="jxr_linenumber" name="L225" href="#L225">225</a> File testPom = +<a class="jxr_linenumber" name="L226" href="#L226">226</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L227" href="#L227">227</a> <span class="jxr_string">"src/test/resources/unit/custom-configuration/custom-configuration-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L228" href="#L228">228</a> +<a class="jxr_linenumber" name="L229" href="#L229">229</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L230" href="#L230">230</a> mojo.execute(); +<a class="jxr_linenumber" name="L231" href="#L231">231</a> +<a class="jxr_linenumber" name="L232" href="#L232">232</a> <em class="jxr_comment">// check the generated files</em> +<a class="jxr_linenumber" name="L233" href="#L233">233</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/pmd.csv"</span> ); +<a class="jxr_linenumber" name="L234" href="#L234">234</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L235" href="#L235">235</a> -<a class="jxr_linenumber" name="L236" href="#L236">236</a> <em class="jxr_comment">// veryLongVariableNameWithViolation is really too long</em> -<a class="jxr_linenumber" name="L237" href="#L237">237</a> assertTrue( lowerCaseContains( str, <span class="jxr_string">"veryLongVariableNameWithViolation"</span> ) ); -<a class="jxr_linenumber" name="L238" href="#L238">238</a> <em class="jxr_comment">// notSoLongVariableName should not be reported</em> -<a class="jxr_linenumber" name="L239" href="#L239">239</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"notSoLongVariableName"</span> ) ); -<a class="jxr_linenumber" name="L240" href="#L240">240</a> } -<a class="jxr_linenumber" name="L241" href="#L241">241</a> -<a class="jxr_linenumber" name="L242" href="#L242">242</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L243" href="#L243">243</a> <em class="jxr_javadoccomment"> * Verify skip parameter</em> -<a class="jxr_linenumber" name="L244" href="#L244">244</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L245" href="#L245">245</a> <em class="jxr_javadoccomment"> * @throws Exception</em> -<a class="jxr_linenumber" name="L246" href="#L246">246</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L247" href="#L247">247</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSkipConfiguration() -<a class="jxr_linenumber" name="L248" href="#L248">248</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L249" href="#L249">249</a> { -<a class="jxr_linenumber" name="L250" href="#L250">250</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/custom-configuration/skip-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L251" href="#L251">251</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L252" href="#L252">252</a> mojo.execute(); +<a class="jxr_linenumber" name="L236" href="#L236">236</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/custom.xml"</span> ); +<a class="jxr_linenumber" name="L237" href="#L237">237</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L238" href="#L238">238</a> +<a class="jxr_linenumber" name="L239" href="#L239">239</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L240" href="#L240">240</a> renderer( mojo, generatedFile ); +<a class="jxr_linenumber" name="L241" href="#L241">241</a> renderer( mojo, generatedFile ); +<a class="jxr_linenumber" name="L242" href="#L242">242</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L243" href="#L243">243</a> +<a class="jxr_linenumber" name="L244" href="#L244">244</a> <em class="jxr_comment">// check if custom ruleset was applied</em> +<a class="jxr_linenumber" name="L245" href="#L245">245</a> String str = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ) ); +<a class="jxr_linenumber" name="L246" href="#L246">246</a> assertTrue( lowerCaseContains( str, <span class="jxr_string">"Avoid using if statements without curly braces"</span> ) ); +<a class="jxr_linenumber" name="L247" href="#L247">247</a> +<a class="jxr_linenumber" name="L248" href="#L248">248</a> <em class="jxr_comment">// Must be false as IfElseStmtsMustUseBraces is excluded!</em> +<a class="jxr_linenumber" name="L249" href="#L249">249</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"Avoid using if...else statements without curly braces"</span> ) ); +<a class="jxr_linenumber" name="L250" href="#L250">250</a> +<a class="jxr_linenumber" name="L251" href="#L251">251</a> assertFalse( <span class="jxr_string">"unnecessary constructor should not be triggered because of low priority"</span>, +<a class="jxr_linenumber" name="L252" href="#L252">252</a> lowerCaseContains( str, <span class="jxr_string">"Avoid unnecessary constructors - the compiler will generate these for you"</span> ) ); <a class="jxr_linenumber" name="L253" href="#L253">253</a> -<a class="jxr_linenumber" name="L254" href="#L254">254</a> <em class="jxr_comment">// verify the generated files do not exist because PMD was skipped</em> -<a class="jxr_linenumber" name="L255" href="#L255">255</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/skip-configuration/target/pmd.csv"</span> ); -<a class="jxr_linenumber" name="L256" href="#L256">256</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L257" href="#L257">257</a> -<a class="jxr_linenumber" name="L258" href="#L258">258</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/custom.xml"</span> ); -<a class="jxr_linenumber" name="L259" href="#L259">259</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L260" href="#L260">260</a> -<a class="jxr_linenumber" name="L261" href="#L261">261</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L262" href="#L262">262</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L263" href="#L263">263</a> } -<a class="jxr_linenumber" name="L264" href="#L264">264</a> -<a class="jxr_linenumber" name="L265" href="#L265">265</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSkipEmptyReportConfiguration() +<a class="jxr_linenumber" name="L254" href="#L254">254</a> <em class="jxr_comment">// veryLongVariableNameWithViolation is really too long</em> +<a class="jxr_linenumber" name="L255" href="#L255">255</a> assertTrue( lowerCaseContains( str, <span class="jxr_string">"veryLongVariableNameWithViolation"</span> ) ); +<a class="jxr_linenumber" name="L256" href="#L256">256</a> <em class="jxr_comment">// notSoLongVariableName should not be reported</em> +<a class="jxr_linenumber" name="L257" href="#L257">257</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"notSoLongVariableName"</span> ) ); +<a class="jxr_linenumber" name="L258" href="#L258">258</a> } +<a class="jxr_linenumber" name="L259" href="#L259">259</a> +<a class="jxr_linenumber" name="L260" href="#L260">260</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L261" href="#L261">261</a> <em class="jxr_javadoccomment"> * Verify skip parameter</em> +<a class="jxr_linenumber" name="L262" href="#L262">262</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L263" href="#L263">263</a> <em class="jxr_javadoccomment"> * @throws Exception</em> +<a class="jxr_linenumber" name="L264" href="#L264">264</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L265" href="#L265">265</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSkipConfiguration() <a class="jxr_linenumber" name="L266" href="#L266">266</a> <strong class="jxr_keyword">throws</strong> Exception <a class="jxr_linenumber" name="L267" href="#L267">267</a> { -<a class="jxr_linenumber" name="L268" href="#L268">268</a> File testPom = -<a class="jxr_linenumber" name="L269" href="#L269">269</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/empty-report/skip-empty-report-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L270" href="#L270">270</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L271" href="#L271">271</a> mojo.execute(); -<a class="jxr_linenumber" name="L272" href="#L272">272</a> -<a class="jxr_linenumber" name="L273" href="#L273">273</a> <em class="jxr_comment">// verify the generated files do not exist because PMD was skipped</em> -<a class="jxr_linenumber" name="L274" href="#L274">274</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L275" href="#L275">275</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L276" href="#L276">276</a> } -<a class="jxr_linenumber" name="L277" href="#L277">277</a> -<a class="jxr_linenumber" name="L278" href="#L278">278</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testEmptyReportConfiguration() -<a class="jxr_linenumber" name="L279" href="#L279">279</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L280" href="#L280">280</a> { -<a class="jxr_linenumber" name="L281" href="#L281">281</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/empty-report/empty-report-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L282" href="#L282">282</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L283" href="#L283">283</a> mojo.execute(); -<a class="jxr_linenumber" name="L284" href="#L284">284</a> -<a class="jxr_linenumber" name="L285" href="#L285">285</a> <em class="jxr_comment">// verify the generated files do exist, even if there are no violations</em> -<a class="jxr_linenumber" name="L286" href="#L286">286</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L287" href="#L287">287</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L288" href="#L288">288</a> String str = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ) ); -<a class="jxr_linenumber" name="L289" href="#L289">289</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"Hello.java"</span> ) ); -<a class="jxr_linenumber" name="L290" href="#L290">290</a> } -<a class="jxr_linenumber" name="L291" href="#L291">291</a> -<a class="jxr_linenumber" name="L292" href="#L292">292</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testInvalidFormat() -<a class="jxr_linenumber" name="L293" href="#L293">293</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L294" href="#L294">294</a> { -<a class="jxr_linenumber" name="L295" href="#L295">295</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L296" href="#L296">296</a> { -<a class="jxr_linenumber" name="L297" href="#L297">297</a> File testPom = -<a class="jxr_linenumber" name="L298" href="#L298">298</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/invalid-format/invalid-format-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L299" href="#L299">299</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L300" href="#L300">300</a> setVariableValueToObject( mojo, <span class="jxr_string">"compileSourceRoots"</span>, mojo.project.getCompileSourceRoots() ); -<a class="jxr_linenumber" name="L301" href="#L301">301</a> mojo.executeReport( Locale.ENGLISH ); +<a class="jxr_linenumber" name="L268" href="#L268">268</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/custom-configuration/skip-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L269" href="#L269">269</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L270" href="#L270">270</a> mojo.execute(); +<a class="jxr_linenumber" name="L271" href="#L271">271</a> +<a class="jxr_linenumber" name="L272" href="#L272">272</a> <em class="jxr_comment">// verify the generated files do not exist because PMD was skipped</em> +<a class="jxr_linenumber" name="L273" href="#L273">273</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/skip-configuration/target/pmd.csv"</span> ); +<a class="jxr_linenumber" name="L274" href="#L274">274</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L275" href="#L275">275</a> +<a class="jxr_linenumber" name="L276" href="#L276">276</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/custom.xml"</span> ); +<a class="jxr_linenumber" name="L277" href="#L277">277</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L278" href="#L278">278</a> +<a class="jxr_linenumber" name="L279" href="#L279">279</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L280" href="#L280">280</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L281" href="#L281">281</a> } +<a class="jxr_linenumber" name="L282" href="#L282">282</a> +<a class="jxr_linenumber" name="L283" href="#L283">283</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSkipEmptyReportConfiguration() +<a class="jxr_linenumber" name="L284" href="#L284">284</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L285" href="#L285">285</a> { +<a class="jxr_linenumber" name="L286" href="#L286">286</a> File testPom = +<a class="jxr_linenumber" name="L287" href="#L287">287</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/empty-report/skip-empty-report-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L288" href="#L288">288</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L289" href="#L289">289</a> mojo.execute(); +<a class="jxr_linenumber" name="L290" href="#L290">290</a> +<a class="jxr_linenumber" name="L291" href="#L291">291</a> <em class="jxr_comment">// verify the generated files do not exist because PMD was skipped</em> +<a class="jxr_linenumber" name="L292" href="#L292">292</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L293" href="#L293">293</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L294" href="#L294">294</a> } +<a class="jxr_linenumber" name="L295" href="#L295">295</a> +<a class="jxr_linenumber" name="L296" href="#L296">296</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testEmptyReportConfiguration() +<a class="jxr_linenumber" name="L297" href="#L297">297</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L298" href="#L298">298</a> { +<a class="jxr_linenumber" name="L299" href="#L299">299</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/empty-report/empty-report-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L300" href="#L300">300</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L301" href="#L301">301</a> mojo.execute(); <a class="jxr_linenumber" name="L302" href="#L302">302</a> -<a class="jxr_linenumber" name="L303" href="#L303">303</a> fail( <span class="jxr_string">"Must throw MavenReportException."</span> ); -<a class="jxr_linenumber" name="L304" href="#L304">304</a> } -<a class="jxr_linenumber" name="L305" href="#L305">305</a> <strong class="jxr_keyword">catch</strong> ( Exception e ) -<a class="jxr_linenumber" name="L306" href="#L306">306</a> { -<a class="jxr_linenumber" name="L307" href="#L307">307</a> assertTrue( <strong class="jxr_keyword">true</strong> ); -<a class="jxr_linenumber" name="L308" href="#L308">308</a> } -<a class="jxr_linenumber" name="L309" href="#L309">309</a> } -<a class="jxr_linenumber" name="L310" href="#L310">310</a> -<a class="jxr_linenumber" name="L311" href="#L311">311</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testInvalidTargetJdk() -<a class="jxr_linenumber" name="L312" href="#L312">312</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L313" href="#L313">313</a> { -<a class="jxr_linenumber" name="L314" href="#L314">314</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L315" href="#L315">315</a> { -<a class="jxr_linenumber" name="L316" href="#L316">316</a> File testPom = -<a class="jxr_linenumber" name="L317" href="#L317">317</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/invalid-format/invalid-target-jdk-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L318" href="#L318">318</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L319" href="#L319">319</a> mojo.execute(); +<a class="jxr_linenumber" name="L303" href="#L303">303</a> <em class="jxr_comment">// verify the generated files do exist, even if there are no violations</em> +<a class="jxr_linenumber" name="L304" href="#L304">304</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L305" href="#L305">305</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L306" href="#L306">306</a> String str = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ) ); +<a class="jxr_linenumber" name="L307" href="#L307">307</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"Hello.java"</span> ) ); +<a class="jxr_linenumber" name="L308" href="#L308">308</a> } +<a class="jxr_linenumber" name="L309" href="#L309">309</a> +<a class="jxr_linenumber" name="L310" href="#L310">310</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testInvalidFormat() +<a class="jxr_linenumber" name="L311" href="#L311">311</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L312" href="#L312">312</a> { +<a class="jxr_linenumber" name="L313" href="#L313">313</a> <strong class="jxr_keyword">try</strong> +<a class="jxr_linenumber" name="L314" href="#L314">314</a> { +<a class="jxr_linenumber" name="L315" href="#L315">315</a> File testPom = +<a class="jxr_linenumber" name="L316" href="#L316">316</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/invalid-format/invalid-format-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L317" href="#L317">317</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L318" href="#L318">318</a> setVariableValueToObject( mojo, <span class="jxr_string">"compileSourceRoots"</span>, mojo.project.getCompileSourceRoots() ); +<a class="jxr_linenumber" name="L319" href="#L319">319</a> mojo.executeReport( Locale.ENGLISH ); <a class="jxr_linenumber" name="L320" href="#L320">320</a> <a class="jxr_linenumber" name="L321" href="#L321">321</a> fail( <span class="jxr_string">"Must throw MavenReportException."</span> ); <a class="jxr_linenumber" name="L322" href="#L322">322</a> } @@ -334,78 +334,78 @@ <a class="jxr_linenumber" name="L326" href="#L326">326</a> } <a class="jxr_linenumber" name="L327" href="#L327">327</a> } <a class="jxr_linenumber" name="L328" href="#L328">328</a> -<a class="jxr_linenumber" name="L329" href="#L329">329</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L330" href="#L330">330</a> <em class="jxr_javadoccomment"> * Read the contents of the specified file object into a string</em> -<a class="jxr_linenumber" name="L331" href="#L331">331</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L332" href="#L332">332</a> <em class="jxr_javadoccomment"> * @param file the file to be read</em> -<a class="jxr_linenumber" name="L333" href="#L333">333</a> <em class="jxr_javadoccomment"> * @return a String object that contains the contents of the file</em> -<a class="jxr_linenumber" name="L334" href="#L334">334</a> <em class="jxr_javadoccomment"> * @throws java.io.IOException</em> -<a class="jxr_linenumber" name="L335" href="#L335">335</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L336" href="#L336">336</a> <strong class="jxr_keyword">private</strong> String readFile( File file ) -<a class="jxr_linenumber" name="L337" href="#L337">337</a> <strong class="jxr_keyword">throws</strong> IOException -<a class="jxr_linenumber" name="L338" href="#L338">338</a> { -<a class="jxr_linenumber" name="L339" href="#L339">339</a> <strong class="jxr_keyword">try</strong> ( BufferedReader reader = <strong class="jxr_keyword">new</strong> BufferedReader( <strong class="jxr_keyword">new</strong> FileReader( file ) ) ) -<a class="jxr_linenumber" name="L340" href="#L340">340</a> { -<a class="jxr_linenumber" name="L341" href="#L341">341</a> <strong class="jxr_keyword">final</strong> StringBuilder str = <strong class="jxr_keyword">new</strong> StringBuilder( (<strong class="jxr_keyword">int</strong>) file.length() ); -<a class="jxr_linenumber" name="L342" href="#L342">342</a> -<a class="jxr_linenumber" name="L343" href="#L343">343</a> <strong class="jxr_keyword">for</strong> ( String line = reader.readLine(); line != <strong class="jxr_keyword">null</strong>; line = reader.readLine() ) -<a class="jxr_linenumber" name="L344" href="#L344">344</a> { -<a class="jxr_linenumber" name="L345" href="#L345">345</a> str.append( ' ' ); -<a class="jxr_linenumber" name="L346" href="#L346">346</a> str.append( line ); -<a class="jxr_linenumber" name="L347" href="#L347">347</a> } -<a class="jxr_linenumber" name="L348" href="#L348">348</a> <strong class="jxr_keyword">return</strong> str.toString(); -<a class="jxr_linenumber" name="L349" href="#L349">349</a> } -<a class="jxr_linenumber" name="L350" href="#L350">350</a> } -<a class="jxr_linenumber" name="L351" href="#L351">351</a> -<a class="jxr_linenumber" name="L352" href="#L352">352</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L353" href="#L353">353</a> <em class="jxr_javadoccomment"> * Verify the correct working of the localtionTemp method</em> -<a class="jxr_linenumber" name="L354" href="#L354">354</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L355" href="#L355">355</a> <em class="jxr_javadoccomment"> * @throws Exception</em> -<a class="jxr_linenumber" name="L356" href="#L356">356</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L357" href="#L357">357</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testLocationTemp() -<a class="jxr_linenumber" name="L358" href="#L358">358</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L359" href="#L359">359</a> { +<a class="jxr_linenumber" name="L329" href="#L329">329</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testInvalidTargetJdk() +<a class="jxr_linenumber" name="L330" href="#L330">330</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L331" href="#L331">331</a> { +<a class="jxr_linenumber" name="L332" href="#L332">332</a> <strong class="jxr_keyword">try</strong> +<a class="jxr_linenumber" name="L333" href="#L333">333</a> { +<a class="jxr_linenumber" name="L334" href="#L334">334</a> File testPom = +<a class="jxr_linenumber" name="L335" href="#L335">335</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/invalid-format/invalid-target-jdk-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L336" href="#L336">336</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L337" href="#L337">337</a> mojo.execute(); +<a class="jxr_linenumber" name="L338" href="#L338">338</a> +<a class="jxr_linenumber" name="L339" href="#L339">339</a> fail( <span class="jxr_string">"Must throw MavenReportException."</span> ); +<a class="jxr_linenumber" name="L340" href="#L340">340</a> } +<a class="jxr_linenumber" name="L341" href="#L341">341</a> <strong class="jxr_keyword">catch</strong> ( Exception e ) +<a class="jxr_linenumber" name="L342" href="#L342">342</a> { +<a class="jxr_linenumber" name="L343" href="#L343">343</a> assertTrue( <strong class="jxr_keyword">true</strong> ); +<a class="jxr_linenumber" name="L344" href="#L344">344</a> } +<a class="jxr_linenumber" name="L345" href="#L345">345</a> } +<a class="jxr_linenumber" name="L346" href="#L346">346</a> +<a class="jxr_linenumber" name="L347" href="#L347">347</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L348" href="#L348">348</a> <em class="jxr_javadoccomment"> * Read the contents of the specified file object into a string</em> +<a class="jxr_linenumber" name="L349" href="#L349">349</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L350" href="#L350">350</a> <em class="jxr_javadoccomment"> * @param file the file to be read</em> +<a class="jxr_linenumber" name="L351" href="#L351">351</a> <em class="jxr_javadoccomment"> * @return a String object that contains the contents of the file</em> +<a class="jxr_linenumber" name="L352" href="#L352">352</a> <em class="jxr_javadoccomment"> * @throws java.io.IOException</em> +<a class="jxr_linenumber" name="L353" href="#L353">353</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L354" href="#L354">354</a> <strong class="jxr_keyword">private</strong> String readFile( File file ) +<a class="jxr_linenumber" name="L355" href="#L355">355</a> <strong class="jxr_keyword">throws</strong> IOException +<a class="jxr_linenumber" name="L356" href="#L356">356</a> { +<a class="jxr_linenumber" name="L357" href="#L357">357</a> <strong class="jxr_keyword">try</strong> ( BufferedReader reader = <strong class="jxr_keyword">new</strong> BufferedReader( <strong class="jxr_keyword">new</strong> FileReader( file ) ) ) +<a class="jxr_linenumber" name="L358" href="#L358">358</a> { +<a class="jxr_linenumber" name="L359" href="#L359">359</a> <strong class="jxr_keyword">final</strong> StringBuilder str = <strong class="jxr_keyword">new</strong> StringBuilder( (<strong class="jxr_keyword">int</strong>) file.length() ); <a class="jxr_linenumber" name="L360" href="#L360">360</a> -<a class="jxr_linenumber" name="L361" href="#L361">361</a> File testPom = -<a class="jxr_linenumber" name="L362" href="#L362">362</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L363" href="#L363">363</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/default-configuration-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L364" href="#L364">364</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L365" href="#L365">365</a> -<a class="jxr_linenumber" name="L366" href="#L366">366</a> assertEquals( <span class="jxr_string">"locationTemp is not correctly encoding filename"</span>, -<a class="jxr_linenumber" name="L367" href="#L367">367</a> <span class="jxr_string">"export_format_pmd_language_java_name_some_2520name.xml"</span>, -<a class="jxr_linenumber" name="L368" href="#L368">368</a> mojo.getLocationTemp( <span class="jxr_string">"http://nemo.sonarsource.org/sonar/profiles/export?format=pmd&language=java&name=some%2520name"</span> ) ); +<a class="jxr_linenumber" name="L361" href="#L361">361</a> <strong class="jxr_keyword">for</strong> ( String line = reader.readLine(); line != <strong class="jxr_keyword">null</strong>; line = reader.readLine() ) +<a class="jxr_linenumber" name="L362" href="#L362">362</a> { +<a class="jxr_linenumber" name="L363" href="#L363">363</a> str.append( ' ' ); +<a class="jxr_linenumber" name="L364" href="#L364">364</a> str.append( line ); +<a class="jxr_linenumber" name="L365" href="#L365">365</a> } +<a class="jxr_linenumber" name="L366" href="#L366">366</a> <strong class="jxr_keyword">return</strong> str.toString(); +<a class="jxr_linenumber" name="L367" href="#L367">367</a> } +<a class="jxr_linenumber" name="L368" href="#L368">368</a> } <a class="jxr_linenumber" name="L369" href="#L369">369</a> -<a class="jxr_linenumber" name="L370" href="#L370">370</a> } -<a class="jxr_linenumber" name="L371" href="#L371">371</a> -<a class="jxr_linenumber" name="L372" href="#L372">372</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L373" href="#L373">373</a> <em class="jxr_javadoccomment"> * Verify that suppressMarker works</em> -<a class="jxr_linenumber" name="L374" href="#L374">374</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L375" href="#L375">375</a> <em class="jxr_javadoccomment"> * @throws Exception</em> -<a class="jxr_linenumber" name="L376" href="#L376">376</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L377" href="#L377">377</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSuppressMarkerConfiguration() -<a class="jxr_linenumber" name="L378" href="#L378">378</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L379" href="#L379">379</a> { -<a class="jxr_linenumber" name="L380" href="#L380">380</a> File testPom = -<a class="jxr_linenumber" name="L381" href="#L381">381</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L382" href="#L382">382</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/pmd-with-suppressMarker-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L383" href="#L383">383</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L384" href="#L384">384</a> mojo.execute(); -<a class="jxr_linenumber" name="L385" href="#L385">385</a> -<a class="jxr_linenumber" name="L386" href="#L386">386</a> <em class="jxr_comment">// check if the PMD files were generated</em> -<a class="jxr_linenumber" name="L387" href="#L387">387</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L388" href="#L388">388</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L370" href="#L370">370</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L371" href="#L371">371</a> <em class="jxr_javadoccomment"> * Verify the correct working of the localtionTemp method</em> +<a class="jxr_linenumber" name="L372" href="#L372">372</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L373" href="#L373">373</a> <em class="jxr_javadoccomment"> * @throws Exception</em> +<a class="jxr_linenumber" name="L374" href="#L374">374</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L375" href="#L375">375</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testLocationTemp() +<a class="jxr_linenumber" name="L376" href="#L376">376</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L377" href="#L377">377</a> { +<a class="jxr_linenumber" name="L378" href="#L378">378</a> +<a class="jxr_linenumber" name="L379" href="#L379">379</a> File testPom = +<a class="jxr_linenumber" name="L380" href="#L380">380</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L381" href="#L381">381</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/default-configuration-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L382" href="#L382">382</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L383" href="#L383">383</a> +<a class="jxr_linenumber" name="L384" href="#L384">384</a> assertEquals( <span class="jxr_string">"locationTemp is not correctly encoding filename"</span>, +<a class="jxr_linenumber" name="L385" href="#L385">385</a> <span class="jxr_string">"export_format_pmd_language_java_name_some_2520name.xml"</span>, +<a class="jxr_linenumber" name="L386" href="#L386">386</a> mojo.getLocationTemp( <span class="jxr_string">"http://nemo.sonarsource.org/sonar/profiles/export?format=pmd&language=java&name=some%2520name"</span> ) ); +<a class="jxr_linenumber" name="L387" href="#L387">387</a> +<a class="jxr_linenumber" name="L388" href="#L388">388</a> } <a class="jxr_linenumber" name="L389" href="#L389">389</a> -<a class="jxr_linenumber" name="L390" href="#L390">390</a> String str = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ) ); -<a class="jxr_linenumber" name="L391" href="#L391">391</a> -<a class="jxr_linenumber" name="L392" href="#L392">392</a> <em class="jxr_comment">// check that there is no violation reported for "unusedVar2" - as it is suppressed</em> -<a class="jxr_linenumber" name="L393" href="#L393">393</a> assertFalse( str.contains( <span class="jxr_string">"Avoid unused private fields such as 'unusedVar2'."</span> ) ); -<a class="jxr_linenumber" name="L394" href="#L394">394</a> } -<a class="jxr_linenumber" name="L395" href="#L395">395</a> -<a class="jxr_linenumber" name="L396" href="#L396">396</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testJspConfiguration() -<a class="jxr_linenumber" name="L397" href="#L397">397</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L398" href="#L398">398</a> { -<a class="jxr_linenumber" name="L399" href="#L399">399</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L400" href="#L400">400</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/jsp-configuration-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L390" href="#L390">390</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L391" href="#L391">391</a> <em class="jxr_javadoccomment"> * Verify that suppressMarker works</em> +<a class="jxr_linenumber" name="L392" href="#L392">392</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L393" href="#L393">393</a> <em class="jxr_javadoccomment"> * @throws Exception</em> +<a class="jxr_linenumber" name="L394" href="#L394">394</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L395" href="#L395">395</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSuppressMarkerConfiguration() +<a class="jxr_linenumber" name="L396" href="#L396">396</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L397" href="#L397">397</a> { +<a class="jxr_linenumber" name="L398" href="#L398">398</a> File testPom = +<a class="jxr_linenumber" name="L399" href="#L399">399</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L400" href="#L400">400</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/pmd-with-suppressMarker-plugin-config.xml"</span> ); <a class="jxr_linenumber" name="L401" href="#L401">401</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); <a class="jxr_linenumber" name="L402" href="#L402">402</a> mojo.execute(); <a class="jxr_linenumber" name="L403" href="#L403">403</a> @@ -413,66 +413,84 @@ <a class="jxr_linenumber" name="L405" href="#L405">405</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); <a class="jxr_linenumber" name="L406" href="#L406">406</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L407" href="#L407">407</a> -<a class="jxr_linenumber" name="L408" href="#L408">408</a> <em class="jxr_comment">// these are the rulesets, that have been applied...</em> -<a class="jxr_linenumber" name="L409" href="#L409">409</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/jsp-basic.xml"</span> ); -<a class="jxr_linenumber" name="L410" href="#L410">410</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L411" href="#L411">411</a> -<a class="jxr_linenumber" name="L412" href="#L412">412</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L413" href="#L413">413</a> renderer( mojo, generatedFile ); -<a class="jxr_linenumber" name="L414" href="#L414">414</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L415" href="#L415">415</a> -<a class="jxr_linenumber" name="L416" href="#L416">416</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L417" href="#L417">417</a> assertTrue(str.contains(<span class="jxr_string">"JSP file should use UTF-8 encoding"</span>)); -<a class="jxr_linenumber" name="L418" href="#L418">418</a> assertTrue(str.contains(<span class="jxr_string">"Using unsanitized JSP expression can lead to Cross Site Scripting (XSS) attacks"</span>)); -<a class="jxr_linenumber" name="L419" href="#L419">419</a> assertTrue(str.contains(<span class="jxr_string">"Avoid having style information in JSP files."</span>)); -<a class="jxr_linenumber" name="L420" href="#L420">420</a> } +<a class="jxr_linenumber" name="L408" href="#L408">408</a> String str = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ) ); +<a class="jxr_linenumber" name="L409" href="#L409">409</a> +<a class="jxr_linenumber" name="L410" href="#L410">410</a> <em class="jxr_comment">// check that there is no violation reported for "unusedVar2" - as it is suppressed</em> +<a class="jxr_linenumber" name="L411" href="#L411">411</a> assertFalse( str.contains( <span class="jxr_string">"Avoid unused private fields such as 'unusedVar2'."</span> ) ); +<a class="jxr_linenumber" name="L412" href="#L412">412</a> } +<a class="jxr_linenumber" name="L413" href="#L413">413</a> +<a class="jxr_linenumber" name="L414" href="#L414">414</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testJspConfiguration() +<a class="jxr_linenumber" name="L415" href="#L415">415</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L416" href="#L416">416</a> { +<a class="jxr_linenumber" name="L417" href="#L417">417</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L418" href="#L418">418</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/jsp-configuration-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L419" href="#L419">419</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L420" href="#L420">420</a> mojo.execute(); <a class="jxr_linenumber" name="L421" href="#L421">421</a> -<a class="jxr_linenumber" name="L422" href="#L422">422</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPMDProcessingError() -<a class="jxr_linenumber" name="L423" href="#L423">423</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L424" href="#L424">424</a> { -<a class="jxr_linenumber" name="L425" href="#L425">425</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L426" href="#L426">426</a> <span class="jxr_string">"src/test/resources/unit/processing-error/pmd-processing-error-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L427" href="#L427">427</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L428" href="#L428">428</a> <strong class="jxr_keyword">try</strong> { -<a class="jxr_linenumber" name="L429" href="#L429">429</a> mojo.execute(); -<a class="jxr_linenumber" name="L430" href="#L430">430</a> fail(<span class="jxr_string">"Expected exception"</span>); -<a class="jxr_linenumber" name="L431" href="#L431">431</a> } <strong class="jxr_keyword">catch</strong> (RuntimeException e) { -<a class="jxr_linenumber" name="L432" href="#L432">432</a> assertTrue( e.getMessage().endsWith( <span class="jxr_string">"Found 1 PMD processing errors"</span> ) ); -<a class="jxr_linenumber" name="L433" href="#L433">433</a> } -<a class="jxr_linenumber" name="L434" href="#L434">434</a> } -<a class="jxr_linenumber" name="L435" href="#L435">435</a> -<a class="jxr_linenumber" name="L436" href="#L436">436</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPMDExcludeRootsShouldExcludeSubdirectories() <strong class="jxr_keyword">throws</strong> Exception { -<a class="jxr_linenumber" name="L437" href="#L437">437</a> File testPom = <strong class="jxr_keyword">new</strong> File(getBasedir(), <span class="jxr_string">"src/test/resources/unit/exclude-roots/pmd-exclude-roots-plugin-config.xml"</span>); -<a class="jxr_linenumber" name="L438" href="#L438">438</a> PmdReport mojo = (PmdReport) lookupMojo (<span class="jxr_string">"pmd"</span>, testPom); -<a class="jxr_linenumber" name="L439" href="#L439">439</a> mojo.execute(); -<a class="jxr_linenumber" name="L440" href="#L440">440</a> -<a class="jxr_linenumber" name="L441" href="#L441">441</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/exclude-roots/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L442" href="#L442">442</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L443" href="#L443">443</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L444" href="#L444">444</a> -<a class="jxr_linenumber" name="L445" href="#L445">445</a> assertTrue( <span class="jxr_string">"Seems like all directories are excluded now"</span>, str.contains(<span class="jxr_string">"ForLoopShouldBeWhileLoop"</span>) ); -<a class="jxr_linenumber" name="L446" href="#L446">446</a> assertFalse( <span class="jxr_string">"Exclusion of an exact source directory not working"</span>, str.contains( <span class="jxr_string">"OverrideBothEqualsAndHashcode"</span> ) ); -<a class="jxr_linenumber" name="L447" href="#L447">447</a> assertFalse( <span class="jxr_string">"Exclusion of basedirectory with subdirectories not working (MPMD-178)"</span>, str.contains( <span class="jxr_string">"JumbledIncrementer"</span>) ); -<a class="jxr_linenumber" name="L448" href="#L448">448</a> } -<a class="jxr_linenumber" name="L449" href="#L449">449</a> -<a class="jxr_linenumber" name="L450" href="#L450">450</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testViolationExclusion() -<a class="jxr_linenumber" name="L451" href="#L451">451</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L452" href="#L452">452</a> { -<a class="jxr_linenumber" name="L453" href="#L453">453</a> File testPom = -<a class="jxr_linenumber" name="L454" href="#L454">454</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L455" href="#L455">455</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/pmd-report-pmd-exclusions-configuration-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L456" href="#L456">456</a> <strong class="jxr_keyword">final</strong> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L457" href="#L457">457</a> mojo.execute(); +<a class="jxr_linenumber" name="L422" href="#L422">422</a> <em class="jxr_comment">// check if the PMD files were generated</em> +<a class="jxr_linenumber" name="L423" href="#L423">423</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); +<a class="jxr_linenumber" name="L424" href="#L424">424</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L425" href="#L425">425</a> +<a class="jxr_linenumber" name="L426" href="#L426">426</a> <em class="jxr_comment">// these are the rulesets, that have been applied...</em> +<a class="jxr_linenumber" name="L427" href="#L427">427</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/jsp-basic.xml"</span> ); +<a class="jxr_linenumber" name="L428" href="#L428">428</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L429" href="#L429">429</a> +<a class="jxr_linenumber" name="L430" href="#L430">430</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L431" href="#L431">431</a> renderer( mojo, generatedFile ); +<a class="jxr_linenumber" name="L432" href="#L432">432</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L433" href="#L433">433</a> +<a class="jxr_linenumber" name="L434" href="#L434">434</a> String str = readFile( generatedFile ); +<a class="jxr_linenumber" name="L435" href="#L435">435</a> assertTrue(str.contains(<span class="jxr_string">"JSP file should use UTF-8 encoding"</span>)); +<a class="jxr_linenumber" name="L436" href="#L436">436</a> assertTrue(str.contains(<span class="jxr_string">"Using unsanitized JSP expression can lead to Cross Site Scripting (XSS) attacks"</span>));
[... 61 lines stripped ...]