Modified: maven/website/components/plugins-archives/maven-pmd-plugin-LATEST/xref-test/org/apache/maven/plugins/pmd/PmdReportTest.html ============================================================================== --- maven/website/components/plugins-archives/maven-pmd-plugin-LATEST/xref-test/org/apache/maven/plugins/pmd/PmdReportTest.html (original) +++ maven/website/components/plugins-archives/maven-pmd-plugin-LATEST/xref-test/org/apache/maven/plugins/pmd/PmdReportTest.html Sat Jan 25 10:56:40 2020 @@ -82,7 +82,7 @@ <a class="jxr_linenumber" name="L74" href="#L74">74</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L75" href="#L75">75</a> <a class="jxr_linenumber" name="L76" href="#L76">76</a> <em class="jxr_comment">// check if the rulesets, that have been applied, have been copied</em> -<a class="jxr_linenumber" name="L77" href="#L77">77</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/maven-pmd-plugin-default.xml"</span> ); +<a class="jxr_linenumber" name="L77" href="#L77">77</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd/rulesets/maven-pmd-plugin-default.xml"</span> ); <a class="jxr_linenumber" name="L78" href="#L78">78</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L79" href="#L79">79</a> <a class="jxr_linenumber" name="L80" href="#L80">80</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); @@ -195,13 +195,13 @@ <a class="jxr_linenumber" name="L187" href="#L187">187</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L188" href="#L188">188</a> <a class="jxr_linenumber" name="L189" href="#L189">189</a> <em class="jxr_comment">// these are the rulesets, that have been applied...</em> -<a class="jxr_linenumber" name="L190" href="#L190">190</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/bestpractices.xml"</span> ); +<a class="jxr_linenumber" name="L190" href="#L190">190</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd/rulesets/bestpractices.xml"</span> ); <a class="jxr_linenumber" name="L191" href="#L191">191</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L192" href="#L192">192</a> -<a class="jxr_linenumber" name="L193" href="#L193">193</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/codestyle.xml"</span> ); +<a class="jxr_linenumber" name="L193" href="#L193">193</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd/rulesets/codestyle.xml"</span> ); <a class="jxr_linenumber" name="L194" href="#L194">194</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L195" href="#L195">195</a> -<a class="jxr_linenumber" name="L196" href="#L196">196</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/errorprone.xml"</span> ); +<a class="jxr_linenumber" name="L196" href="#L196">196</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd/rulesets/errorprone.xml"</span> ); <a class="jxr_linenumber" name="L197" href="#L197">197</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L198" href="#L198">198</a> <a class="jxr_linenumber" name="L199" href="#L199">199</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); @@ -258,427 +258,428 @@ <a class="jxr_linenumber" name="L250" href="#L250">250</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); <a class="jxr_linenumber" name="L251" href="#L251">251</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); <a class="jxr_linenumber" name="L252" href="#L252">252</a> -<a class="jxr_linenumber" name="L253" href="#L253">253</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/basic.xml"</span> ); -<a class="jxr_linenumber" name="L254" href="#L254">254</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L255" href="#L255">255</a> -<a class="jxr_linenumber" name="L256" href="#L256">256</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/imports.xml"</span> ); -<a class="jxr_linenumber" name="L257" href="#L257">257</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L258" href="#L258">258</a> -<a class="jxr_linenumber" name="L259" href="#L259">259</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/unusedcode.xml"</span> ); -<a class="jxr_linenumber" name="L260" href="#L260">260</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L261" href="#L261">261</a> -<a class="jxr_linenumber" name="L262" href="#L262">262</a> generatedFile = -<a class="jxr_linenumber" name="L263" href="#L263">263</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L264" href="#L264">264</a> <span class="jxr_string">"target/test/unit/default-configuration/target/export_format_pmd_language_java_name_Sonar_2520way.xml"</span> ); -<a class="jxr_linenumber" name="L265" href="#L265">265</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L266" href="#L266">266</a> -<a class="jxr_linenumber" name="L267" href="#L267">267</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L268" href="#L268">268</a> renderer( mojo, generatedFile ); -<a class="jxr_linenumber" name="L269" href="#L269">269</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L270" href="#L270">270</a> -<a class="jxr_linenumber" name="L271" href="#L271">271</a> <em class="jxr_comment">// check if there's a link to the JXR files</em> -<a class="jxr_linenumber" name="L272" href="#L272">272</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L273" href="#L273">273</a> -<a class="jxr_linenumber" name="L274" href="#L274">274</a> assertTrue( str.contains( <span class="jxr_string">"/xref/def/configuration/App.html#L31"</span> ) ); -<a class="jxr_linenumber" name="L275" href="#L275">275</a> -<a class="jxr_linenumber" name="L276" href="#L276">276</a> assertTrue( str.contains( <span class="jxr_string">"/xref/def/configuration/AppSample.html#L45"</span> ) ); -<a class="jxr_linenumber" name="L277" href="#L277">277</a> -<a class="jxr_linenumber" name="L278" href="#L278">278</a> mockServer.stop(); -<a class="jxr_linenumber" name="L279" href="#L279">279</a> } -<a class="jxr_linenumber" name="L280" href="#L280">280</a> -<a class="jxr_linenumber" name="L281" href="#L281">281</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">int</strong> determineFreePort() -<a class="jxr_linenumber" name="L282" href="#L282">282</a> { -<a class="jxr_linenumber" name="L283" href="#L283">283</a> <strong class="jxr_keyword">try</strong> (ServerSocket socket = <strong class="jxr_keyword">new</strong> ServerSocket(0)) { -<a class="jxr_linenumber" name="L284" href="#L284">284</a> <strong class="jxr_keyword">return</strong> socket.getLocalPort(); -<a class="jxr_linenumber" name="L285" href="#L285">285</a> } <strong class="jxr_keyword">catch</strong> (IOException e) { -<a class="jxr_linenumber" name="L286" href="#L286">286</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> RuntimeException( <span class="jxr_string">"Couldn't find a free port."</span>, e ); -<a class="jxr_linenumber" name="L287" href="#L287">287</a> } -<a class="jxr_linenumber" name="L288" href="#L288">288</a> } -<a class="jxr_linenumber" name="L289" href="#L289">289</a> -<a class="jxr_linenumber" name="L290" href="#L290">290</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L291" href="#L291">291</a> <em class="jxr_javadoccomment"> * With custom rulesets</em> -<a class="jxr_linenumber" name="L292" href="#L292">292</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L293" href="#L293">293</a> <em class="jxr_javadoccomment"> * @throws Exception</em> -<a class="jxr_linenumber" name="L294" href="#L294">294</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L295" href="#L295">295</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testCustomConfiguration() -<a class="jxr_linenumber" name="L296" href="#L296">296</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L297" href="#L297">297</a> { -<a class="jxr_linenumber" name="L298" href="#L298">298</a> File testPom = -<a class="jxr_linenumber" name="L299" href="#L299">299</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L300" href="#L300">300</a> <span class="jxr_string">"src/test/resources/unit/custom-configuration/custom-configuration-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L301" href="#L301">301</a> -<a class="jxr_linenumber" name="L302" href="#L302">302</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L303" href="#L303">303</a> mojo.execute(); -<a class="jxr_linenumber" name="L304" href="#L304">304</a> -<a class="jxr_linenumber" name="L305" href="#L305">305</a> <em class="jxr_comment">// check the generated files</em> -<a class="jxr_linenumber" name="L306" href="#L306">306</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/pmd.csv"</span> ); -<a class="jxr_linenumber" name="L307" href="#L307">307</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L308" href="#L308">308</a> -<a class="jxr_linenumber" name="L309" href="#L309">309</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/custom.xml"</span> ); -<a class="jxr_linenumber" name="L310" href="#L310">310</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L311" href="#L311">311</a> -<a class="jxr_linenumber" name="L312" href="#L312">312</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L313" href="#L313">313</a> renderer( mojo, generatedFile ); -<a class="jxr_linenumber" name="L314" href="#L314">314</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L315" href="#L315">315</a> -<a class="jxr_linenumber" name="L316" href="#L316">316</a> <em class="jxr_comment">// check if custom ruleset was applied</em> -<a class="jxr_linenumber" name="L317" href="#L317">317</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L318" href="#L318">318</a> -<a class="jxr_linenumber" name="L319" href="#L319">319</a> <em class="jxr_comment">// codestyle.xml/ControlStatementBraces:</em> -<a class="jxr_linenumber" name="L320" href="#L320">320</a> assertTrue( lowerCaseContains( str, <span class="jxr_string">"This statement should have braces"</span> ) ); -<a class="jxr_linenumber" name="L321" href="#L321">321</a> -<a class="jxr_linenumber" name="L322" href="#L322">322</a> <em class="jxr_comment">// Must be false as codestyle.xml/ControlStatementBraces with checkIfElseStmt=false is used</em> -<a class="jxr_linenumber" name="L323" href="#L323">323</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"Avoid using if...else statements without curly braces"</span> ) ); -<a class="jxr_linenumber" name="L324" href="#L324">324</a> -<a class="jxr_linenumber" name="L325" href="#L325">325</a> assertFalse( <span class="jxr_string">"unnecessary constructor should not be triggered because of low priority"</span>, -<a class="jxr_linenumber" name="L326" href="#L326">326</a> lowerCaseContains( str, <span class="jxr_string">"Avoid unnecessary constructors - the compiler will generate these for you"</span> ) ); -<a class="jxr_linenumber" name="L327" href="#L327">327</a> -<a class="jxr_linenumber" name="L328" href="#L328">328</a> <em class="jxr_comment">// veryLongVariableNameWithViolation is really too long</em> -<a class="jxr_linenumber" name="L329" href="#L329">329</a> assertTrue( lowerCaseContains( str, <span class="jxr_string">"veryLongVariableNameWithViolation"</span> ) ); -<a class="jxr_linenumber" name="L330" href="#L330">330</a> <em class="jxr_comment">// notSoLongVariableName should not be reported</em> -<a class="jxr_linenumber" name="L331" href="#L331">331</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"notSoLongVariableName"</span> ) ); -<a class="jxr_linenumber" name="L332" href="#L332">332</a> } -<a class="jxr_linenumber" name="L333" href="#L333">333</a> -<a class="jxr_linenumber" name="L334" href="#L334">334</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L335" href="#L335">335</a> <em class="jxr_javadoccomment"> * Verify skip parameter</em> -<a class="jxr_linenumber" name="L336" href="#L336">336</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L337" href="#L337">337</a> <em class="jxr_javadoccomment"> * @throws Exception</em> -<a class="jxr_linenumber" name="L338" href="#L338">338</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L339" href="#L339">339</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSkipConfiguration() -<a class="jxr_linenumber" name="L340" href="#L340">340</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L341" href="#L341">341</a> { -<a class="jxr_linenumber" name="L342" href="#L342">342</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/custom-configuration/skip-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L343" href="#L343">343</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L344" href="#L344">344</a> mojo.execute(); -<a class="jxr_linenumber" name="L345" href="#L345">345</a> -<a class="jxr_linenumber" name="L346" href="#L346">346</a> <em class="jxr_comment">// verify the generated files do not exist because PMD was skipped</em> -<a class="jxr_linenumber" name="L347" href="#L347">347</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/skip-configuration/target/pmd.csv"</span> ); -<a class="jxr_linenumber" name="L348" href="#L348">348</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L349" href="#L349">349</a> -<a class="jxr_linenumber" name="L350" href="#L350">350</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/custom.xml"</span> ); -<a class="jxr_linenumber" name="L351" href="#L351">351</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L352" href="#L352">352</a> -<a class="jxr_linenumber" name="L353" href="#L353">353</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L354" href="#L354">354</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L355" href="#L355">355</a> } -<a class="jxr_linenumber" name="L356" href="#L356">356</a> -<a class="jxr_linenumber" name="L357" href="#L357">357</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSkipEmptyReportConfiguration() -<a class="jxr_linenumber" name="L358" href="#L358">358</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L359" href="#L359">359</a> { -<a class="jxr_linenumber" name="L360" href="#L360">360</a> File testPom = -<a class="jxr_linenumber" name="L361" href="#L361">361</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/empty-report/skip-empty-report-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L362" href="#L362">362</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L363" href="#L363">363</a> mojo.execute(); -<a class="jxr_linenumber" name="L364" href="#L364">364</a> -<a class="jxr_linenumber" name="L365" href="#L365">365</a> <em class="jxr_comment">// verify the generated files do not exist because PMD was skipped</em> -<a class="jxr_linenumber" name="L366" href="#L366">366</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L367" href="#L367">367</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L368" href="#L368">368</a> } -<a class="jxr_linenumber" name="L369" href="#L369">369</a> -<a class="jxr_linenumber" name="L370" href="#L370">370</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testEmptyReportConfiguration() -<a class="jxr_linenumber" name="L371" href="#L371">371</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L372" href="#L372">372</a> { -<a class="jxr_linenumber" name="L373" href="#L373">373</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/empty-report/empty-report-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L374" href="#L374">374</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L375" href="#L375">375</a> mojo.execute(); -<a class="jxr_linenumber" name="L376" href="#L376">376</a> -<a class="jxr_linenumber" name="L377" href="#L377">377</a> <em class="jxr_comment">// verify the generated files do exist, even if there are no violations</em> -<a class="jxr_linenumber" name="L378" href="#L378">378</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L379" href="#L379">379</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L380" href="#L380">380</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L381" href="#L381">381</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"Hello.java"</span> ) ); -<a class="jxr_linenumber" name="L382" href="#L382">382</a> assertEquals( 1, StringUtils.countMatches( str, <span class="jxr_string">"PMD found no problems in your source code."</span> ) ); -<a class="jxr_linenumber" name="L383" href="#L383">383</a> <em class="jxr_comment">// no sections files or violations by priority</em> -<a class="jxr_linenumber" name="L384" href="#L384">384</a> assertFalse( str.contains( <span class="jxr_string">"Files</h2>"</span> ) ); -<a class="jxr_linenumber" name="L385" href="#L385">385</a> assertFalse( str.contains( <span class="jxr_string">"Violations By Priority</h2>"</span> ) ); -<a class="jxr_linenumber" name="L386" href="#L386">386</a> } -<a class="jxr_linenumber" name="L387" href="#L387">387</a> -<a class="jxr_linenumber" name="L388" href="#L388">388</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testInvalidFormat() -<a class="jxr_linenumber" name="L389" href="#L389">389</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L390" href="#L390">390</a> { -<a class="jxr_linenumber" name="L391" href="#L391">391</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L392" href="#L392">392</a> { -<a class="jxr_linenumber" name="L393" href="#L393">393</a> File testPom = -<a class="jxr_linenumber" name="L394" href="#L394">394</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/invalid-format/invalid-format-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L395" href="#L395">395</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L396" href="#L396">396</a> setVariableValueToObject( mojo, <span class="jxr_string">"compileSourceRoots"</span>, mojo.project.getCompileSourceRoots() ); -<a class="jxr_linenumber" name="L397" href="#L397">397</a> mojo.executeReport( Locale.ENGLISH ); -<a class="jxr_linenumber" name="L398" href="#L398">398</a> -<a class="jxr_linenumber" name="L399" href="#L399">399</a> fail( <span class="jxr_string">"Must throw MavenReportException."</span> ); -<a class="jxr_linenumber" name="L400" href="#L400">400</a> } -<a class="jxr_linenumber" name="L401" href="#L401">401</a> <strong class="jxr_keyword">catch</strong> ( Exception e ) -<a class="jxr_linenumber" name="L402" href="#L402">402</a> { -<a class="jxr_linenumber" name="L403" href="#L403">403</a> assertTrue( <strong class="jxr_keyword">true</strong> ); -<a class="jxr_linenumber" name="L404" href="#L404">404</a> } -<a class="jxr_linenumber" name="L405" href="#L405">405</a> } -<a class="jxr_linenumber" name="L406" href="#L406">406</a> -<a class="jxr_linenumber" name="L407" href="#L407">407</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testInvalidTargetJdk() -<a class="jxr_linenumber" name="L408" href="#L408">408</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L409" href="#L409">409</a> { -<a class="jxr_linenumber" name="L410" href="#L410">410</a> <strong class="jxr_keyword">try</strong> -<a class="jxr_linenumber" name="L411" href="#L411">411</a> { -<a class="jxr_linenumber" name="L412" href="#L412">412</a> File testPom = -<a class="jxr_linenumber" name="L413" href="#L413">413</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/invalid-format/invalid-target-jdk-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L414" href="#L414">414</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L415" href="#L415">415</a> mojo.execute(); -<a class="jxr_linenumber" name="L416" href="#L416">416</a> -<a class="jxr_linenumber" name="L417" href="#L417">417</a> fail( <span class="jxr_string">"Must throw MavenReportException."</span> ); -<a class="jxr_linenumber" name="L418" href="#L418">418</a> } -<a class="jxr_linenumber" name="L419" href="#L419">419</a> <strong class="jxr_keyword">catch</strong> ( Exception e ) -<a class="jxr_linenumber" name="L420" href="#L420">420</a> { -<a class="jxr_linenumber" name="L421" href="#L421">421</a> assertTrue( <strong class="jxr_keyword">true</strong> ); -<a class="jxr_linenumber" name="L422" href="#L422">422</a> } -<a class="jxr_linenumber" name="L423" href="#L423">423</a> } -<a class="jxr_linenumber" name="L424" href="#L424">424</a> -<a class="jxr_linenumber" name="L425" href="#L425">425</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L426" href="#L426">426</a> <em class="jxr_javadoccomment"> * verify the pmd.xml file is included in the site when requested.</em> -<a class="jxr_linenumber" name="L427" href="#L427">427</a> <em class="jxr_javadoccomment"> * @throws Exception</em> -<a class="jxr_linenumber" name="L428" href="#L428">428</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L429" href="#L429">429</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testIncludeXmlInSite() -<a class="jxr_linenumber" name="L430" href="#L430">430</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L431" href="#L431">431</a> { -<a class="jxr_linenumber" name="L432" href="#L432">432</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/default-configuration/pmd-report-include-xml-in-site-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L433" href="#L433">433</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L434" href="#L434">434</a> mojo.execute(); -<a class="jxr_linenumber" name="L435" href="#L435">435</a> -<a class="jxr_linenumber" name="L436" href="#L436">436</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L437" href="#L437">437</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L438" href="#L438">438</a> <em class="jxr_comment">// verify the pmd file is included in site</em> -<a class="jxr_linenumber" name="L439" href="#L439">439</a> File generatedXmlFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L440" href="#L440">440</a> assertTrue( FileUtils.fileExists( generatedXmlFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L441" href="#L441">441</a> -<a class="jxr_linenumber" name="L442" href="#L442">442</a> String pmdXmlTarget = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ) ); -<a class="jxr_linenumber" name="L443" href="#L443">443</a> assertTrue( pmdXmlTarget.contains( <span class="jxr_string">"</pmd>"</span> ) ); -<a class="jxr_linenumber" name="L444" href="#L444">444</a> -<a class="jxr_linenumber" name="L445" href="#L445">445</a> <em class="jxr_comment">// check that pmd.xml file has the closing element</em> -<a class="jxr_linenumber" name="L446" href="#L446">446</a> String pmdXml = readFile( generatedXmlFile ); -<a class="jxr_linenumber" name="L447" href="#L447">447</a> assertTrue( pmdXml.contains( <span class="jxr_string">"</pmd>"</span> ) ); -<a class="jxr_linenumber" name="L448" href="#L448">448</a> } -<a class="jxr_linenumber" name="L449" href="#L449">449</a> -<a class="jxr_linenumber" name="L450" href="#L450">450</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L451" href="#L451">451</a> <em class="jxr_javadoccomment"> * Read the contents of the specified file object into a string</em> -<a class="jxr_linenumber" name="L452" href="#L452">452</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L453" href="#L453">453</a> <em class="jxr_javadoccomment"> * @param file the file to be read</em> -<a class="jxr_linenumber" name="L454" href="#L454">454</a> <em class="jxr_javadoccomment"> * @return a String object that contains the contents of the file</em> -<a class="jxr_linenumber" name="L455" href="#L455">455</a> <em class="jxr_javadoccomment"> * @throws java.io.IOException</em> -<a class="jxr_linenumber" name="L456" href="#L456">456</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L457" href="#L457">457</a> <strong class="jxr_keyword">private</strong> String readFile( File file ) -<a class="jxr_linenumber" name="L458" href="#L458">458</a> <strong class="jxr_keyword">throws</strong> IOException -<a class="jxr_linenumber" name="L459" href="#L459">459</a> { -<a class="jxr_linenumber" name="L460" href="#L460">460</a> <strong class="jxr_keyword">try</strong> ( BufferedReader reader = <strong class="jxr_keyword">new</strong> BufferedReader( <strong class="jxr_keyword">new</strong> FileReader( file ) ) ) -<a class="jxr_linenumber" name="L461" href="#L461">461</a> { -<a class="jxr_linenumber" name="L462" href="#L462">462</a> <strong class="jxr_keyword">final</strong> StringBuilder str = <strong class="jxr_keyword">new</strong> StringBuilder( (<strong class="jxr_keyword">int</strong>) file.length() ); -<a class="jxr_linenumber" name="L463" href="#L463">463</a> -<a class="jxr_linenumber" name="L464" href="#L464">464</a> <strong class="jxr_keyword">for</strong> ( String line = reader.readLine(); line != <strong class="jxr_keyword">null</strong>; line = reader.readLine() ) -<a class="jxr_linenumber" name="L465" href="#L465">465</a> { -<a class="jxr_linenumber" name="L466" href="#L466">466</a> str.append( ' ' ); -<a class="jxr_linenumber" name="L467" href="#L467">467</a> str.append( line ); -<a class="jxr_linenumber" name="L468" href="#L468">468</a> str.append( '\n' ); -<a class="jxr_linenumber" name="L469" href="#L469">469</a> } -<a class="jxr_linenumber" name="L470" href="#L470">470</a> <strong class="jxr_keyword">return</strong> str.toString(); -<a class="jxr_linenumber" name="L471" href="#L471">471</a> } -<a class="jxr_linenumber" name="L472" href="#L472">472</a> } -<a class="jxr_linenumber" name="L473" href="#L473">473</a> -<a class="jxr_linenumber" name="L474" href="#L474">474</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L475" href="#L475">475</a> <em class="jxr_javadoccomment"> * Verify the correct working of the locationTemp method</em> -<a class="jxr_linenumber" name="L476" href="#L476">476</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L477" href="#L477">477</a> <em class="jxr_javadoccomment"> * @throws Exception</em> -<a class="jxr_linenumber" name="L478" href="#L478">478</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L479" href="#L479">479</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testLocationTemp() -<a class="jxr_linenumber" name="L480" href="#L480">480</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L481" href="#L481">481</a> { -<a class="jxr_linenumber" name="L482" href="#L482">482</a> -<a class="jxr_linenumber" name="L483" href="#L483">483</a> File testPom = -<a class="jxr_linenumber" name="L484" href="#L484">484</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L485" href="#L485">485</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/default-configuration-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L486" href="#L486">486</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L487" href="#L487">487</a> -<a class="jxr_linenumber" name="L488" href="#L488">488</a> assertEquals( <span class="jxr_string">"locationTemp is not correctly encoding filename"</span>, -<a class="jxr_linenumber" name="L489" href="#L489">489</a> <span class="jxr_string">"export_format_pmd_language_java_name_some_2520name.xml"</span>, -<a class="jxr_linenumber" name="L490" href="#L490">490</a> mojo.getLocationTemp( <span class="jxr_string">"http://nemo.sonarsource.org/sonar/profiles/export?format=pmd&language=java&name=some%2520name"</span> ) ); -<a class="jxr_linenumber" name="L491" href="#L491">491</a> -<a class="jxr_linenumber" name="L492" href="#L492">492</a> } -<a class="jxr_linenumber" name="L493" href="#L493">493</a> -<a class="jxr_linenumber" name="L494" href="#L494">494</a> <em class="jxr_javadoccomment">/**</em> -<a class="jxr_linenumber" name="L495" href="#L495">495</a> <em class="jxr_javadoccomment"> * Verify that suppressMarker works</em> -<a class="jxr_linenumber" name="L496" href="#L496">496</a> <em class="jxr_javadoccomment"> *</em> -<a class="jxr_linenumber" name="L497" href="#L497">497</a> <em class="jxr_javadoccomment"> * @throws Exception</em> -<a class="jxr_linenumber" name="L498" href="#L498">498</a> <em class="jxr_javadoccomment"> */</em> -<a class="jxr_linenumber" name="L499" href="#L499">499</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSuppressMarkerConfiguration() -<a class="jxr_linenumber" name="L500" href="#L500">500</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L501" href="#L501">501</a> { -<a class="jxr_linenumber" name="L502" href="#L502">502</a> File testPom = -<a class="jxr_linenumber" name="L503" href="#L503">503</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L504" href="#L504">504</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/pmd-with-suppressMarker-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L505" href="#L505">505</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L506" href="#L506">506</a> mojo.execute(); -<a class="jxr_linenumber" name="L507" href="#L507">507</a> -<a class="jxr_linenumber" name="L508" href="#L508">508</a> <em class="jxr_comment">// check if the PMD files were generated</em> -<a class="jxr_linenumber" name="L509" href="#L509">509</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L510" href="#L510">510</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L511" href="#L511">511</a> -<a class="jxr_linenumber" name="L512" href="#L512">512</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L513" href="#L513">513</a> -<a class="jxr_linenumber" name="L514" href="#L514">514</a> <em class="jxr_comment">// check that there is no violation reported for "unusedVar2" - as it is suppressed</em> -<a class="jxr_linenumber" name="L515" href="#L515">515</a> assertFalse( str.contains( <span class="jxr_string">"Avoid unused private fields such as 'unusedVar2'."</span> ) ); -<a class="jxr_linenumber" name="L516" href="#L516">516</a> } -<a class="jxr_linenumber" name="L517" href="#L517">517</a> -<a class="jxr_linenumber" name="L518" href="#L518">518</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testJspConfiguration() -<a class="jxr_linenumber" name="L519" href="#L519">519</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L520" href="#L520">520</a> { -<a class="jxr_linenumber" name="L521" href="#L521">521</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L522" href="#L522">522</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/jsp-configuration-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L523" href="#L523">523</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L524" href="#L524">524</a> mojo.execute(); -<a class="jxr_linenumber" name="L525" href="#L525">525</a> -<a class="jxr_linenumber" name="L526" href="#L526">526</a> <em class="jxr_comment">// check if the PMD files were generated</em> -<a class="jxr_linenumber" name="L527" href="#L527">527</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L528" href="#L528">528</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L529" href="#L529">529</a> -<a class="jxr_linenumber" name="L530" href="#L530">530</a> <em class="jxr_comment">// these are the rulesets, that have been applied...</em> -<a class="jxr_linenumber" name="L531" href="#L531">531</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/bestpractices.xml"</span> ); -<a class="jxr_linenumber" name="L532" href="#L532">532</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L533" href="#L533">533</a> -<a class="jxr_linenumber" name="L534" href="#L534">534</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/codestyle.xml"</span> ); -<a class="jxr_linenumber" name="L535" href="#L535">535</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L536" href="#L536">536</a> -<a class="jxr_linenumber" name="L537" href="#L537">537</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/design.xml"</span> ); -<a class="jxr_linenumber" name="L538" href="#L538">538</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L539" href="#L539">539</a> -<a class="jxr_linenumber" name="L540" href="#L540">540</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/errorprone.xml"</span> ); -<a class="jxr_linenumber" name="L541" href="#L541">541</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L542" href="#L542">542</a> -<a class="jxr_linenumber" name="L543" href="#L543">543</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/security.xml"</span> ); -<a class="jxr_linenumber" name="L544" href="#L544">544</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L545" href="#L545">545</a> -<a class="jxr_linenumber" name="L546" href="#L546">546</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L547" href="#L547">547</a> renderer( mojo, generatedFile ); -<a class="jxr_linenumber" name="L548" href="#L548">548</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L549" href="#L549">549</a> -<a class="jxr_linenumber" name="L550" href="#L550">550</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L551" href="#L551">551</a> assertTrue(str.contains(<span class="jxr_string">"JSP file should use UTF-8 encoding"</span>)); -<a class="jxr_linenumber" name="L552" href="#L552">552</a> assertTrue(str.contains(<span class="jxr_string">"Using unsanitized JSP expression can lead to Cross Site Scripting (XSS) attacks"</span>)); -<a class="jxr_linenumber" name="L553" href="#L553">553</a> assertTrue(str.contains(<span class="jxr_string">"Avoid having style information in JSP files."</span>)); -<a class="jxr_linenumber" name="L554" href="#L554">554</a> } -<a class="jxr_linenumber" name="L555" href="#L555">555</a> -<a class="jxr_linenumber" name="L556" href="#L556">556</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPMDProcessingError() -<a class="jxr_linenumber" name="L557" href="#L557">557</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L558" href="#L558">558</a> { -<a class="jxr_linenumber" name="L559" href="#L559">559</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L560" href="#L560">560</a> <span class="jxr_string">"src/test/resources/unit/processing-error/pmd-processing-error-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L561" href="#L561">561</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L562" href="#L562">562</a> <strong class="jxr_keyword">try</strong> { -<a class="jxr_linenumber" name="L563" href="#L563">563</a> mojo.execute(); -<a class="jxr_linenumber" name="L564" href="#L564">564</a> fail(<span class="jxr_string">"Expected exception"</span>); -<a class="jxr_linenumber" name="L565" href="#L565">565</a> } <strong class="jxr_keyword">catch</strong> (RuntimeException e) { -<a class="jxr_linenumber" name="L566" href="#L566">566</a> assertTrue( e.getMessage().endsWith( <span class="jxr_string">"Found 1 PMD processing errors"</span> ) ); -<a class="jxr_linenumber" name="L567" href="#L567">567</a> } -<a class="jxr_linenumber" name="L568" href="#L568">568</a> } -<a class="jxr_linenumber" name="L569" href="#L569">569</a> -<a class="jxr_linenumber" name="L570" href="#L570">570</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPMDProcessingErrorWithDetailsSkipped() -<a class="jxr_linenumber" name="L571" href="#L571">571</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L572" href="#L572">572</a> { -<a class="jxr_linenumber" name="L573" href="#L573">573</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L574" href="#L574">574</a> <span class="jxr_string">"src/test/resources/unit/processing-error/pmd-processing-error-skip-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L575" href="#L575">575</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L576" href="#L576">576</a> -<a class="jxr_linenumber" name="L577" href="#L577">577</a> PrintStream originalOut = System.out; -<a class="jxr_linenumber" name="L578" href="#L578">578</a> ByteArrayOutputStream logging = <strong class="jxr_keyword">new</strong> ByteArrayOutputStream(); -<a class="jxr_linenumber" name="L579" href="#L579">579</a> System.setOut( <strong class="jxr_keyword">new</strong> PrintStream( logging ) ); -<a class="jxr_linenumber" name="L580" href="#L580">580</a> -<a class="jxr_linenumber" name="L581" href="#L581">581</a> <strong class="jxr_keyword">try</strong> { -<a class="jxr_linenumber" name="L582" href="#L582">582</a> mojo.execute(); -<a class="jxr_linenumber" name="L583" href="#L583">583</a> String output = logging.toString(); -<a class="jxr_linenumber" name="L584" href="#L584">584</a> assertTrue ( output.contains( <span class="jxr_string">"There are 1 PMD processing errors:"</span> ) ); -<a class="jxr_linenumber" name="L585" href="#L585">585</a> -<a class="jxr_linenumber" name="L586" href="#L586">586</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/parse-error/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L587" href="#L587">587</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L588" href="#L588">588</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L589" href="#L589">589</a> assertTrue( str.contains( <span class="jxr_string">"Error while parsing"</span> ) ); -<a class="jxr_linenumber" name="L590" href="#L590">590</a> <em class="jxr_comment">// The parse exception must be in the XML report</em> -<a class="jxr_linenumber" name="L591" href="#L591">591</a> assertTrue( str.contains( <span class="jxr_string">"ParseException: Encountered \"\" at line 23, column 5."</span> ) ); -<a class="jxr_linenumber" name="L592" href="#L592">592</a> -<a class="jxr_linenumber" name="L593" href="#L593">593</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L594" href="#L594">594</a> renderer( mojo, generatedFile ); -<a class="jxr_linenumber" name="L595" href="#L595">595</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L596" href="#L596">596</a> str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L597" href="#L597">597</a> <em class="jxr_comment">// The parse exception must also be in the HTML report</em> -<a class="jxr_linenumber" name="L598" href="#L598">598</a> assertTrue( str.contains( <span class="jxr_string">"ParseException: Encountered \"\" at line 23, column 5."</span> ) ); -<a class="jxr_linenumber" name="L599" href="#L599">599</a> -<a class="jxr_linenumber" name="L600" href="#L600">600</a> } <strong class="jxr_keyword">finally</strong> { -<a class="jxr_linenumber" name="L601" href="#L601">601</a> System.setOut( originalOut ); -<a class="jxr_linenumber" name="L602" href="#L602">602</a> System.out.println( logging.toString() ); -<a class="jxr_linenumber" name="L603" href="#L603">603</a> } -<a class="jxr_linenumber" name="L604" href="#L604">604</a> } -<a class="jxr_linenumber" name="L605" href="#L605">605</a> -<a class="jxr_linenumber" name="L606" href="#L606">606</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPMDProcessingErrorWithDetailsNoReport() -<a class="jxr_linenumber" name="L607" href="#L607">607</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L608" href="#L608">608</a> { -<a class="jxr_linenumber" name="L609" href="#L609">609</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L610" href="#L610">610</a> <span class="jxr_string">"src/test/resources/unit/processing-error/pmd-processing-error-no-report-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L611" href="#L611">611</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L612" href="#L612">612</a> -<a class="jxr_linenumber" name="L613" href="#L613">613</a> PrintStream originalOut = System.out; -<a class="jxr_linenumber" name="L614" href="#L614">614</a> ByteArrayOutputStream logging = <strong class="jxr_keyword">new</strong> ByteArrayOutputStream(); -<a class="jxr_linenumber" name="L615" href="#L615">615</a> System.setOut( <strong class="jxr_keyword">new</strong> PrintStream( logging ) ); -<a class="jxr_linenumber" name="L616" href="#L616">616</a> -<a class="jxr_linenumber" name="L617" href="#L617">617</a> <strong class="jxr_keyword">try</strong> { -<a class="jxr_linenumber" name="L618" href="#L618">618</a> mojo.execute(); -<a class="jxr_linenumber" name="L619" href="#L619">619</a> String output = logging.toString(); -<a class="jxr_linenumber" name="L620" href="#L620">620</a> assertTrue ( output.contains( <span class="jxr_string">"There are 1 PMD processing errors:"</span> ) ); -<a class="jxr_linenumber" name="L621" href="#L621">621</a> -<a class="jxr_linenumber" name="L622" href="#L622">622</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/parse-error/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L623" href="#L623">623</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L624" href="#L624">624</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L625" href="#L625">625</a> assertTrue( str.contains( <span class="jxr_string">"Error while parsing"</span> ) ); -<a class="jxr_linenumber" name="L626" href="#L626">626</a> <em class="jxr_comment">// The parse exception must be in the XML report</em> -<a class="jxr_linenumber" name="L627" href="#L627">627</a> assertTrue( str.contains( <span class="jxr_string">"ParseException: Encountered \"\" at line 23, column 5."</span> ) ); -<a class="jxr_linenumber" name="L628" href="#L628">628</a> -<a class="jxr_linenumber" name="L629" href="#L629">629</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); -<a class="jxr_linenumber" name="L630" href="#L630">630</a> renderer( mojo, generatedFile ); -<a class="jxr_linenumber" name="L631" href="#L631">631</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L632" href="#L632">632</a> str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L633" href="#L633">633</a> <em class="jxr_comment">// The parse exception must NOT be in the HTML report, since reportProcessingErrors is false</em> -<a class="jxr_linenumber" name="L634" href="#L634">634</a> assertFalse( str.contains( <span class="jxr_string">"ParseException: Encountered \"\" at line 23, column 5."</span> ) ); -<a class="jxr_linenumber" name="L635" href="#L635">635</a> -<a class="jxr_linenumber" name="L636" href="#L636">636</a> } <strong class="jxr_keyword">finally</strong> { -<a class="jxr_linenumber" name="L637" href="#L637">637</a> System.setOut( originalOut ); -<a class="jxr_linenumber" name="L638" href="#L638">638</a> System.out.println( logging.toString() ); -<a class="jxr_linenumber" name="L639" href="#L639">639</a> } -<a class="jxr_linenumber" name="L640" href="#L640">640</a> } -<a class="jxr_linenumber" name="L641" href="#L641">641</a> -<a class="jxr_linenumber" name="L642" href="#L642">642</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPMDExcludeRootsShouldExcludeSubdirectories() <strong class="jxr_keyword">throws</strong> Exception { -<a class="jxr_linenumber" name="L643" href="#L643">643</a> File testPom = <strong class="jxr_keyword">new</strong> File(getBasedir(), <span class="jxr_string">"src/test/resources/unit/exclude-roots/pmd-exclude-roots-plugin-config.xml"</span>); -<a class="jxr_linenumber" name="L644" href="#L644">644</a> PmdReport mojo = (PmdReport) lookupMojo (<span class="jxr_string">"pmd"</span>, testPom); -<a class="jxr_linenumber" name="L645" href="#L645">645</a> mojo.execute(); -<a class="jxr_linenumber" name="L646" href="#L646">646</a> -<a class="jxr_linenumber" name="L647" href="#L647">647</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/exclude-roots/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L648" href="#L648">648</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L649" href="#L649">649</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L650" href="#L650">650</a> -<a class="jxr_linenumber" name="L651" href="#L651">651</a> assertTrue( <span class="jxr_string">"Seems like all directories are excluded now"</span>, str.contains(<span class="jxr_string">"ForLoopShouldBeWhileLoop"</span>) ); -<a class="jxr_linenumber" name="L652" href="#L652">652</a> assertFalse( <span class="jxr_string">"Exclusion of an exact source directory not working"</span>, str.contains( <span class="jxr_string">"OverrideBothEqualsAndHashcode"</span> ) ); -<a class="jxr_linenumber" name="L653" href="#L653">653</a> assertFalse( <span class="jxr_string">"Exclusion of basedirectory with subdirectories not working (MPMD-178)"</span>, str.contains( <span class="jxr_string">"JumbledIncrementer"</span>) ); -<a class="jxr_linenumber" name="L654" href="#L654">654</a> } -<a class="jxr_linenumber" name="L655" href="#L655">655</a> -<a class="jxr_linenumber" name="L656" href="#L656">656</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testViolationExclusion() -<a class="jxr_linenumber" name="L657" href="#L657">657</a> <strong class="jxr_keyword">throws</strong> Exception -<a class="jxr_linenumber" name="L658" href="#L658">658</a> { -<a class="jxr_linenumber" name="L659" href="#L659">659</a> File testPom = -<a class="jxr_linenumber" name="L660" href="#L660">660</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), -<a class="jxr_linenumber" name="L661" href="#L661">661</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/pmd-report-pmd-exclusions-configuration-plugin-config.xml"</span> ); -<a class="jxr_linenumber" name="L662" href="#L662">662</a> <strong class="jxr_keyword">final</strong> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); -<a class="jxr_linenumber" name="L663" href="#L663">663</a> mojo.execute(); -<a class="jxr_linenumber" name="L664" href="#L664">664</a> -<a class="jxr_linenumber" name="L665" href="#L665">665</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ); -<a class="jxr_linenumber" name="L666" href="#L666">666</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); -<a class="jxr_linenumber" name="L667" href="#L667">667</a> String str = readFile( generatedFile ); -<a class="jxr_linenumber" name="L668" href="#L668">668</a> -<a class="jxr_linenumber" name="L669" href="#L669">669</a> assertEquals(0, StringUtils.countMatches(str, <span class="jxr_string">"<violation"</span>)); -<a class="jxr_linenumber" name="L670" href="#L670">670</a> } -<a class="jxr_linenumber" name="L671" href="#L671">671</a> } +<a class="jxr_linenumber" name="L253" href="#L253">253</a> <em class="jxr_comment">// the resolved and extracted rulesets</em> +<a class="jxr_linenumber" name="L254" href="#L254">254</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd/rulesets/basic.xml"</span> ); +<a class="jxr_linenumber" name="L255" href="#L255">255</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L256" href="#L256">256</a> +<a class="jxr_linenumber" name="L257" href="#L257">257</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd/rulesets/imports.xml"</span> ); +<a class="jxr_linenumber" name="L258" href="#L258">258</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L259" href="#L259">259</a> +<a class="jxr_linenumber" name="L260" href="#L260">260</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd/rulesets/unusedcode.xml"</span> ); +<a class="jxr_linenumber" name="L261" href="#L261">261</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L262" href="#L262">262</a> +<a class="jxr_linenumber" name="L263" href="#L263">263</a> generatedFile = +<a class="jxr_linenumber" name="L264" href="#L264">264</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L265" href="#L265">265</a> <span class="jxr_string">"target/test/unit/default-configuration/target/pmd/rulesets/export_format_pmd_language_java_name_Sonar_2520way.xml"</span> ); +<a class="jxr_linenumber" name="L266" href="#L266">266</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L267" href="#L267">267</a> +<a class="jxr_linenumber" name="L268" href="#L268">268</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L269" href="#L269">269</a> renderer( mojo, generatedFile ); +<a class="jxr_linenumber" name="L270" href="#L270">270</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L271" href="#L271">271</a> +<a class="jxr_linenumber" name="L272" href="#L272">272</a> <em class="jxr_comment">// check if there's a link to the JXR files</em> +<a class="jxr_linenumber" name="L273" href="#L273">273</a> String str = readFile( generatedFile ); +<a class="jxr_linenumber" name="L274" href="#L274">274</a> +<a class="jxr_linenumber" name="L275" href="#L275">275</a> assertTrue( str.contains( <span class="jxr_string">"/xref/def/configuration/App.html#L31"</span> ) ); +<a class="jxr_linenumber" name="L276" href="#L276">276</a> +<a class="jxr_linenumber" name="L277" href="#L277">277</a> assertTrue( str.contains( <span class="jxr_string">"/xref/def/configuration/AppSample.html#L45"</span> ) ); +<a class="jxr_linenumber" name="L278" href="#L278">278</a> +<a class="jxr_linenumber" name="L279" href="#L279">279</a> mockServer.stop(); +<a class="jxr_linenumber" name="L280" href="#L280">280</a> } +<a class="jxr_linenumber" name="L281" href="#L281">281</a> +<a class="jxr_linenumber" name="L282" href="#L282">282</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">int</strong> determineFreePort() +<a class="jxr_linenumber" name="L283" href="#L283">283</a> { +<a class="jxr_linenumber" name="L284" href="#L284">284</a> <strong class="jxr_keyword">try</strong> (ServerSocket socket = <strong class="jxr_keyword">new</strong> ServerSocket(0)) { +<a class="jxr_linenumber" name="L285" href="#L285">285</a> <strong class="jxr_keyword">return</strong> socket.getLocalPort(); +<a class="jxr_linenumber" name="L286" href="#L286">286</a> } <strong class="jxr_keyword">catch</strong> (IOException e) { +<a class="jxr_linenumber" name="L287" href="#L287">287</a> <strong class="jxr_keyword">throw</strong> <strong class="jxr_keyword">new</strong> RuntimeException( <span class="jxr_string">"Couldn't find a free port."</span>, e ); +<a class="jxr_linenumber" name="L288" href="#L288">288</a> } +<a class="jxr_linenumber" name="L289" href="#L289">289</a> } +<a class="jxr_linenumber" name="L290" href="#L290">290</a> +<a class="jxr_linenumber" name="L291" href="#L291">291</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L292" href="#L292">292</a> <em class="jxr_javadoccomment"> * With custom rulesets</em> +<a class="jxr_linenumber" name="L293" href="#L293">293</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L294" href="#L294">294</a> <em class="jxr_javadoccomment"> * @throws Exception</em> +<a class="jxr_linenumber" name="L295" href="#L295">295</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L296" href="#L296">296</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testCustomConfiguration() +<a class="jxr_linenumber" name="L297" href="#L297">297</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L298" href="#L298">298</a> { +<a class="jxr_linenumber" name="L299" href="#L299">299</a> File testPom = +<a class="jxr_linenumber" name="L300" href="#L300">300</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L301" href="#L301">301</a> <span class="jxr_string">"src/test/resources/unit/custom-configuration/custom-configuration-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L302" href="#L302">302</a> +<a class="jxr_linenumber" name="L303" href="#L303">303</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L304" href="#L304">304</a> mojo.execute(); +<a class="jxr_linenumber" name="L305" href="#L305">305</a> +<a class="jxr_linenumber" name="L306" href="#L306">306</a> <em class="jxr_comment">// check the generated files</em> +<a class="jxr_linenumber" name="L307" href="#L307">307</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/pmd.csv"</span> ); +<a class="jxr_linenumber" name="L308" href="#L308">308</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L309" href="#L309">309</a> +<a class="jxr_linenumber" name="L310" href="#L310">310</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/pmd/rulesets/custom.xml"</span> ); +<a class="jxr_linenumber" name="L311" href="#L311">311</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L312" href="#L312">312</a> +<a class="jxr_linenumber" name="L313" href="#L313">313</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L314" href="#L314">314</a> renderer( mojo, generatedFile ); +<a class="jxr_linenumber" name="L315" href="#L315">315</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L316" href="#L316">316</a> +<a class="jxr_linenumber" name="L317" href="#L317">317</a> <em class="jxr_comment">// check if custom ruleset was applied</em> +<a class="jxr_linenumber" name="L318" href="#L318">318</a> String str = readFile( generatedFile ); +<a class="jxr_linenumber" name="L319" href="#L319">319</a> +<a class="jxr_linenumber" name="L320" href="#L320">320</a> <em class="jxr_comment">// codestyle.xml/ControlStatementBraces:</em> +<a class="jxr_linenumber" name="L321" href="#L321">321</a> assertTrue( lowerCaseContains( str, <span class="jxr_string">"This statement should have braces"</span> ) ); +<a class="jxr_linenumber" name="L322" href="#L322">322</a> +<a class="jxr_linenumber" name="L323" href="#L323">323</a> <em class="jxr_comment">// Must be false as codestyle.xml/ControlStatementBraces with checkIfElseStmt=false is used</em> +<a class="jxr_linenumber" name="L324" href="#L324">324</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"Avoid using if...else statements without curly braces"</span> ) ); +<a class="jxr_linenumber" name="L325" href="#L325">325</a> +<a class="jxr_linenumber" name="L326" href="#L326">326</a> assertFalse( <span class="jxr_string">"unnecessary constructor should not be triggered because of low priority"</span>, +<a class="jxr_linenumber" name="L327" href="#L327">327</a> lowerCaseContains( str, <span class="jxr_string">"Avoid unnecessary constructors - the compiler will generate these for you"</span> ) ); +<a class="jxr_linenumber" name="L328" href="#L328">328</a> +<a class="jxr_linenumber" name="L329" href="#L329">329</a> <em class="jxr_comment">// veryLongVariableNameWithViolation is really too long</em> +<a class="jxr_linenumber" name="L330" href="#L330">330</a> assertTrue( lowerCaseContains( str, <span class="jxr_string">"veryLongVariableNameWithViolation"</span> ) ); +<a class="jxr_linenumber" name="L331" href="#L331">331</a> <em class="jxr_comment">// notSoLongVariableName should not be reported</em> +<a class="jxr_linenumber" name="L332" href="#L332">332</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"notSoLongVariableName"</span> ) ); +<a class="jxr_linenumber" name="L333" href="#L333">333</a> } +<a class="jxr_linenumber" name="L334" href="#L334">334</a> +<a class="jxr_linenumber" name="L335" href="#L335">335</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L336" href="#L336">336</a> <em class="jxr_javadoccomment"> * Verify skip parameter</em> +<a class="jxr_linenumber" name="L337" href="#L337">337</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L338" href="#L338">338</a> <em class="jxr_javadoccomment"> * @throws Exception</em> +<a class="jxr_linenumber" name="L339" href="#L339">339</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L340" href="#L340">340</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSkipConfiguration() +<a class="jxr_linenumber" name="L341" href="#L341">341</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L342" href="#L342">342</a> { +<a class="jxr_linenumber" name="L343" href="#L343">343</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/custom-configuration/skip-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L344" href="#L344">344</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L345" href="#L345">345</a> mojo.execute(); +<a class="jxr_linenumber" name="L346" href="#L346">346</a> +<a class="jxr_linenumber" name="L347" href="#L347">347</a> <em class="jxr_comment">// verify the generated files do not exist because PMD was skipped</em> +<a class="jxr_linenumber" name="L348" href="#L348">348</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/skip-configuration/target/pmd.csv"</span> ); +<a class="jxr_linenumber" name="L349" href="#L349">349</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L350" href="#L350">350</a> +<a class="jxr_linenumber" name="L351" href="#L351">351</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/custom.xml"</span> ); +<a class="jxr_linenumber" name="L352" href="#L352">352</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L353" href="#L353">353</a> +<a class="jxr_linenumber" name="L354" href="#L354">354</a> generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/custom-configuration/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L355" href="#L355">355</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L356" href="#L356">356</a> } +<a class="jxr_linenumber" name="L357" href="#L357">357</a> +<a class="jxr_linenumber" name="L358" href="#L358">358</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSkipEmptyReportConfiguration() +<a class="jxr_linenumber" name="L359" href="#L359">359</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L360" href="#L360">360</a> { +<a class="jxr_linenumber" name="L361" href="#L361">361</a> File testPom = +<a class="jxr_linenumber" name="L362" href="#L362">362</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/empty-report/skip-empty-report-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L363" href="#L363">363</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L364" href="#L364">364</a> mojo.execute(); +<a class="jxr_linenumber" name="L365" href="#L365">365</a> +<a class="jxr_linenumber" name="L366" href="#L366">366</a> <em class="jxr_comment">// verify the generated files do not exist because PMD was skipped</em> +<a class="jxr_linenumber" name="L367" href="#L367">367</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L368" href="#L368">368</a> assertFalse( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L369" href="#L369">369</a> } +<a class="jxr_linenumber" name="L370" href="#L370">370</a> +<a class="jxr_linenumber" name="L371" href="#L371">371</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testEmptyReportConfiguration() +<a class="jxr_linenumber" name="L372" href="#L372">372</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L373" href="#L373">373</a> { +<a class="jxr_linenumber" name="L374" href="#L374">374</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/empty-report/empty-report-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L375" href="#L375">375</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L376" href="#L376">376</a> mojo.execute(); +<a class="jxr_linenumber" name="L377" href="#L377">377</a> +<a class="jxr_linenumber" name="L378" href="#L378">378</a> <em class="jxr_comment">// verify the generated files do exist, even if there are no violations</em> +<a class="jxr_linenumber" name="L379" href="#L379">379</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/empty-report/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L380" href="#L380">380</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L381" href="#L381">381</a> String str = readFile( generatedFile ); +<a class="jxr_linenumber" name="L382" href="#L382">382</a> assertFalse( lowerCaseContains( str, <span class="jxr_string">"Hello.java"</span> ) ); +<a class="jxr_linenumber" name="L383" href="#L383">383</a> assertEquals( 1, StringUtils.countMatches( str, <span class="jxr_string">"PMD found no problems in your source code."</span> ) ); +<a class="jxr_linenumber" name="L384" href="#L384">384</a> <em class="jxr_comment">// no sections files or violations by priority</em> +<a class="jxr_linenumber" name="L385" href="#L385">385</a> assertFalse( str.contains( <span class="jxr_string">"Files</h2>"</span> ) ); +<a class="jxr_linenumber" name="L386" href="#L386">386</a> assertFalse( str.contains( <span class="jxr_string">"Violations By Priority</h2>"</span> ) ); +<a class="jxr_linenumber" name="L387" href="#L387">387</a> } +<a class="jxr_linenumber" name="L388" href="#L388">388</a> +<a class="jxr_linenumber" name="L389" href="#L389">389</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testInvalidFormat() +<a class="jxr_linenumber" name="L390" href="#L390">390</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L391" href="#L391">391</a> { +<a class="jxr_linenumber" name="L392" href="#L392">392</a> <strong class="jxr_keyword">try</strong> +<a class="jxr_linenumber" name="L393" href="#L393">393</a> { +<a class="jxr_linenumber" name="L394" href="#L394">394</a> File testPom = +<a class="jxr_linenumber" name="L395" href="#L395">395</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/invalid-format/invalid-format-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L396" href="#L396">396</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L397" href="#L397">397</a> setVariableValueToObject( mojo, <span class="jxr_string">"compileSourceRoots"</span>, mojo.project.getCompileSourceRoots() ); +<a class="jxr_linenumber" name="L398" href="#L398">398</a> mojo.executeReport( Locale.ENGLISH ); +<a class="jxr_linenumber" name="L399" href="#L399">399</a> +<a class="jxr_linenumber" name="L400" href="#L400">400</a> fail( <span class="jxr_string">"Must throw MavenReportException."</span> ); +<a class="jxr_linenumber" name="L401" href="#L401">401</a> } +<a class="jxr_linenumber" name="L402" href="#L402">402</a> <strong class="jxr_keyword">catch</strong> ( Exception e ) +<a class="jxr_linenumber" name="L403" href="#L403">403</a> { +<a class="jxr_linenumber" name="L404" href="#L404">404</a> assertTrue( <strong class="jxr_keyword">true</strong> ); +<a class="jxr_linenumber" name="L405" href="#L405">405</a> } +<a class="jxr_linenumber" name="L406" href="#L406">406</a> } +<a class="jxr_linenumber" name="L407" href="#L407">407</a> +<a class="jxr_linenumber" name="L408" href="#L408">408</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testInvalidTargetJdk() +<a class="jxr_linenumber" name="L409" href="#L409">409</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L410" href="#L410">410</a> { +<a class="jxr_linenumber" name="L411" href="#L411">411</a> <strong class="jxr_keyword">try</strong> +<a class="jxr_linenumber" name="L412" href="#L412">412</a> { +<a class="jxr_linenumber" name="L413" href="#L413">413</a> File testPom = +<a class="jxr_linenumber" name="L414" href="#L414">414</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/invalid-format/invalid-target-jdk-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L415" href="#L415">415</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L416" href="#L416">416</a> mojo.execute(); +<a class="jxr_linenumber" name="L417" href="#L417">417</a> +<a class="jxr_linenumber" name="L418" href="#L418">418</a> fail( <span class="jxr_string">"Must throw MavenReportException."</span> ); +<a class="jxr_linenumber" name="L419" href="#L419">419</a> } +<a class="jxr_linenumber" name="L420" href="#L420">420</a> <strong class="jxr_keyword">catch</strong> ( Exception e ) +<a class="jxr_linenumber" name="L421" href="#L421">421</a> { +<a class="jxr_linenumber" name="L422" href="#L422">422</a> assertTrue( <strong class="jxr_keyword">true</strong> ); +<a class="jxr_linenumber" name="L423" href="#L423">423</a> } +<a class="jxr_linenumber" name="L424" href="#L424">424</a> } +<a class="jxr_linenumber" name="L425" href="#L425">425</a> +<a class="jxr_linenumber" name="L426" href="#L426">426</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L427" href="#L427">427</a> <em class="jxr_javadoccomment"> * verify the pmd.xml file is included in the site when requested.</em> +<a class="jxr_linenumber" name="L428" href="#L428">428</a> <em class="jxr_javadoccomment"> * @throws Exception</em> +<a class="jxr_linenumber" name="L429" href="#L429">429</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L430" href="#L430">430</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testIncludeXmlInSite() +<a class="jxr_linenumber" name="L431" href="#L431">431</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L432" href="#L432">432</a> { +<a class="jxr_linenumber" name="L433" href="#L433">433</a> File testPom = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"src/test/resources/unit/default-configuration/pmd-report-include-xml-in-site-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L434" href="#L434">434</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L435" href="#L435">435</a> mojo.execute(); +<a class="jxr_linenumber" name="L436" href="#L436">436</a> +<a class="jxr_linenumber" name="L437" href="#L437">437</a> File generatedFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.html"</span> ); +<a class="jxr_linenumber" name="L438" href="#L438">438</a> assertTrue( FileUtils.fileExists( generatedFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L439" href="#L439">439</a> <em class="jxr_comment">// verify the pmd file is included in site</em> +<a class="jxr_linenumber" name="L440" href="#L440">440</a> File generatedXmlFile = <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/site/pmd.xml"</span> ); +<a class="jxr_linenumber" name="L441" href="#L441">441</a> assertTrue( FileUtils.fileExists( generatedXmlFile.getAbsolutePath() ) ); +<a class="jxr_linenumber" name="L442" href="#L442">442</a> +<a class="jxr_linenumber" name="L443" href="#L443">443</a> String pmdXmlTarget = readFile( <strong class="jxr_keyword">new</strong> File( getBasedir(), <span class="jxr_string">"target/test/unit/default-configuration/target/pmd.xml"</span> ) ); +<a class="jxr_linenumber" name="L444" href="#L444">444</a> assertTrue( pmdXmlTarget.contains( <span class="jxr_string">"</pmd>"</span> ) ); +<a class="jxr_linenumber" name="L445" href="#L445">445</a> +<a class="jxr_linenumber" name="L446" href="#L446">446</a> <em class="jxr_comment">// check that pmd.xml file has the closing element</em> +<a class="jxr_linenumber" name="L447" href="#L447">447</a> String pmdXml = readFile( generatedXmlFile ); +<a class="jxr_linenumber" name="L448" href="#L448">448</a> assertTrue( pmdXml.contains( <span class="jxr_string">"</pmd>"</span> ) ); +<a class="jxr_linenumber" name="L449" href="#L449">449</a> } +<a class="jxr_linenumber" name="L450" href="#L450">450</a> +<a class="jxr_linenumber" name="L451" href="#L451">451</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L452" href="#L452">452</a> <em class="jxr_javadoccomment"> * Read the contents of the specified file object into a string</em> +<a class="jxr_linenumber" name="L453" href="#L453">453</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L454" href="#L454">454</a> <em class="jxr_javadoccomment"> * @param file the file to be read</em> +<a class="jxr_linenumber" name="L455" href="#L455">455</a> <em class="jxr_javadoccomment"> * @return a String object that contains the contents of the file</em> +<a class="jxr_linenumber" name="L456" href="#L456">456</a> <em class="jxr_javadoccomment"> * @throws java.io.IOException</em> +<a class="jxr_linenumber" name="L457" href="#L457">457</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L458" href="#L458">458</a> <strong class="jxr_keyword">private</strong> String readFile( File file ) +<a class="jxr_linenumber" name="L459" href="#L459">459</a> <strong class="jxr_keyword">throws</strong> IOException +<a class="jxr_linenumber" name="L460" href="#L460">460</a> { +<a class="jxr_linenumber" name="L461" href="#L461">461</a> <strong class="jxr_keyword">try</strong> ( BufferedReader reader = <strong class="jxr_keyword">new</strong> BufferedReader( <strong class="jxr_keyword">new</strong> FileReader( file ) ) ) +<a class="jxr_linenumber" name="L462" href="#L462">462</a> { +<a class="jxr_linenumber" name="L463" href="#L463">463</a> <strong class="jxr_keyword">final</strong> StringBuilder str = <strong class="jxr_keyword">new</strong> StringBuilder( (<strong class="jxr_keyword">int</strong>) file.length() ); +<a class="jxr_linenumber" name="L464" href="#L464">464</a> +<a class="jxr_linenumber" name="L465" href="#L465">465</a> <strong class="jxr_keyword">for</strong> ( String line = reader.readLine(); line != <strong class="jxr_keyword">null</strong>; line = reader.readLine() ) +<a class="jxr_linenumber" name="L466" href="#L466">466</a> { +<a class="jxr_linenumber" name="L467" href="#L467">467</a> str.append( ' ' ); +<a class="jxr_linenumber" name="L468" href="#L468">468</a> str.append( line ); +<a class="jxr_linenumber" name="L469" href="#L469">469</a> str.append( '\n' ); +<a class="jxr_linenumber" name="L470" href="#L470">470</a> } +<a class="jxr_linenumber" name="L471" href="#L471">471</a> <strong class="jxr_keyword">return</strong> str.toString(); +<a class="jxr_linenumber" name="L472" href="#L472">472</a> } +<a class="jxr_linenumber" name="L473" href="#L473">473</a> } +<a class="jxr_linenumber" name="L474" href="#L474">474</a> +<a class="jxr_linenumber" name="L475" href="#L475">475</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L476" href="#L476">476</a> <em class="jxr_javadoccomment"> * Verify the correct working of the locationTemp method</em> +<a class="jxr_linenumber" name="L477" href="#L477">477</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L478" href="#L478">478</a> <em class="jxr_javadoccomment"> * @throws Exception</em> +<a class="jxr_linenumber" name="L479" href="#L479">479</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L480" href="#L480">480</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testLocationTemp() +<a class="jxr_linenumber" name="L481" href="#L481">481</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L482" href="#L482">482</a> { +<a class="jxr_linenumber" name="L483" href="#L483">483</a> +<a class="jxr_linenumber" name="L484" href="#L484">484</a> File testPom = +<a class="jxr_linenumber" name="L485" href="#L485">485</a> <strong class="jxr_keyword">new</strong> File( getBasedir(), +<a class="jxr_linenumber" name="L486" href="#L486">486</a> <span class="jxr_string">"src/test/resources/unit/default-configuration/default-configuration-plugin-config.xml"</span> ); +<a class="jxr_linenumber" name="L487" href="#L487">487</a> PmdReport mojo = (PmdReport) lookupMojo( <span class="jxr_string">"pmd"</span>, testPom ); +<a class="jxr_linenumber" name="L488" href="#L488">488</a> +<a class="jxr_linenumber" name="L489" href="#L489">489</a> assertEquals( <span class="jxr_string">"locationTemp is not correctly encoding filename"</span>, +<a class="jxr_linenumber" name="L490" href="#L490">490</a> <span class="jxr_string">"export_format_pmd_language_java_name_some_2520name.xml"</span>, +<a class="jxr_linenumber" name="L491" href="#L491">491</a> mojo.getLocationTemp( <span class="jxr_string">"http://nemo.sonarsource.org/sonar/profiles/export?format=pmd&language=java&name=some%2520name"</span> ) ); +<a class="jxr_linenumber" name="L492" href="#L492">492</a> +<a class="jxr_linenumber" name="L493" href="#L493">493</a> } +<a class="jxr_linenumber" name="L494" href="#L494">494</a> +<a class="jxr_linenumber" name="L495" href="#L495">495</a> <em class="jxr_javadoccomment">/**</em> +<a class="jxr_linenumber" name="L496" href="#L496">496</a> <em class="jxr_javadoccomment"> * Verify that suppressMarker works</em> +<a class="jxr_linenumber" name="L497" href="#L497">497</a> <em class="jxr_javadoccomment"> *</em> +<a class="jxr_linenumber" name="L498" href="#L498">498</a> <em class="jxr_javadoccomment"> * @throws Exception</em> +<a class="jxr_linenumber" name="L499" href="#L499">499</a> <em class="jxr_javadoccomment"> */</em> +<a class="jxr_linenumber" name="L500" href="#L500">500</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSuppressMarkerConfiguration() +<a class="jxr_linenumber" name="L501" href="#L501">501</a> <strong class="jxr_keyword">throws</strong> Exception +<a class="jxr_linenumber" name="L502" href="#L502">502</a> {
[... 178 lines stripped ...]