Re: Bug in ucspilogd v2.2.0.0

2015-08-09 Thread Colin Booth
On Sun, Aug 9, 2015 at 12:17 PM, Laurent Bercot wrote: > On 09/08/2015 20:13, Colin Booth wrote: >> >> Ok, I was wrong. I set up a little netcat /dev/log reader and there's >> no separator at all between messages. At least not one that made it to >> netcat. It also looks like the new logger stops

Re: Bug in ucspilogd v2.2.0.0

2015-08-09 Thread Laurent Bercot
On 09/08/2015 20:13, Colin Booth wrote: Ok, I was wrong. I set up a little netcat /dev/log reader and there's no separator at all between messages. At least not one that made it to netcat. It also looks like the new logger stops reading after the first \0, and strips all newlines. ... wat.

Re: Bug in ucspilogd v2.2.0.0

2015-08-09 Thread Colin Booth
On Sun, Aug 9, 2015 at 10:23 AM, Laurent Bercot wrote: > On 09/08/2015 19:12, Colin Booth wrote: >> >> I haven't experimented with it yet, but I think the messages from >> long-running logger processes are null-separated, just not the last >> line. I'll take a look later today when I have time. >

Re: Bug in ucspilogd v2.2.0.0

2015-08-09 Thread Laurent Bercot
On 09/08/2015 19:12, Colin Booth wrote: I haven't experimented with it yet, but I think the messages from long-running logger processes are null-separated, just not the last line. I'll take a look later today when I have time. Ah, that's easy enough to fix. Please try with the latest s6 git an

Re: Bug in ucspilogd v2.2.0.0

2015-08-09 Thread Colin Booth
On Sun, Aug 9, 2015 at 6:20 AM, Olivier Brunel wrote: > On 08/09/15 10:44, Laurent Bercot wrote: >> The path leading to the first invocation of readv() hasn't changed, >> but readv() gives different results. My first suspicion is that "logger" >> isn't sending the last character (newline or \0) i

Re: Bug in ucspilogd v2.2.0.0

2015-08-09 Thread Olivier Brunel
On 08/09/15 10:44, Laurent Bercot wrote: > The path leading to the first invocation of readv() hasn't changed, > but readv() gives different results. My first suspicion is that "logger" > isn't sending the last character (newline or \0) in the second case > before exiting, which skagetlnsep() inte

Re: Bug in ucspilogd v2.2.0.0

2015-08-09 Thread Laurent Bercot
On 09/08/2015 09:27, Colin Booth wrote: I haven't yet dug into the skalibs code to see what changed between those tags, or started bisecting it to find out which commit broke. The git diff between 2.3.5.1 and current HEAD is pretty small, and there's really nothing that changed in the graph of

Bug in ucspilogd v2.2.0.0

2015-08-09 Thread Colin Booth
Hi Laurent, I'm pretty sure some change in skalibs v2.3.6.0 broke some types of message handling in ucspilogd. Specifically, a computer I have running skalibs v2.3.5.1 and s6 v2.1.6.0 is able to read messages sent via the logger command, whereas a computer I have running skalibs v2.3.6.0 and s6 v2