Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Guillermo
El jue., 17 oct. 2019 a las 16:51, Laurent Bercot escribió: > > Hurd should return -1 ENXIO, > unless there is a real problem with the underlying file system - and the > test your patch comments exists to catch such problems. …or an error in the underlying operating system. POSIX open() seems to

Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Guillermo
El jue., 17 oct. 2019 a las 17:02, Laurent Bercot escribió: > > >__gnu_hurd__ > > That's perfect. I replaced __GLIBC__ with this. I think __GNU__ is still preferred over __gnu_hurd__, judging by the "Preprocessor Define" and "GNU specific #define" sections of the porting guidelines linked

Re: skarnet software license files

2019-10-17 Thread Laurent Bercot
AFAIU skarnet software released under ISC License should include a license file in it's release tar files as ISC License expects to have a year and an owner mentioned in the license, isn't it? There is one. It's conventionally called COPYING. -- Laurent

skarnet software license files

2019-10-17 Thread Rodrigo Severo - Fábrica
Hi, AFAIU skarnet software released under ISC License should include a license file in it's release tar files as ISC License expects to have a year and an owner mentioned in the license, isn't it? Regards, Rodrigo Severo

Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Laurent Bercot
A reasonable detection in configure stage is definitively to prefer. Not necessarily. It would work, obviously, but would bloat the build. Compile-time generated headers are kinda painful to manage, and I'd like to keep their number in check. Also, using configure detection would make

Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Laurent Bercot
__gnu_hurd__ That's perfect. I replaced __GLIBC__ with this. So skalibs/nonposix.h will define _GNU_SOURCE on Linux and Hurd, i.e. the systems whose function visibility benefits the most from it. Testing kernel ftms is generally ugly, but it's the right thing for nonposix.h whose goal is

Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Laurent Bercot
The errno I got on Hurd is `EIEIO 1073741928 Computer bought the farm`... Seems a Hurd specific errno... That is really non-conformant, and deserves to be reported to the Hurd team. What is happening is that "control" is a named pipe, and the attempted operation is open(control, O_WRONLY |

Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Shengjing Zhu
On Thu, Oct 17, 2019 at 7:14 AM Guillermo wrote: > > If compiler predefined macros like __linux__ or __NetBSD__ are OK for > , how about #if defined(__linux__) || > defined(__GNU__)? GCC predefines both __GNU__ and __gnu_hurd__ (I > think, can be checked with 'cpp -dM - the Hurd, and I suppose

Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Shengjing Zhu
On Thu, Oct 17, 2019 at 1:10 AM Laurent Bercot wrote: > > What problems did you get with s6? It should be able to run without > trouble. To me that's a more important issue than the ones you listed > below. :) > with the following patch, s6 works...(tested some functions like s6-svscan). diff

Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Guillermo
El jue., 17 oct. 2019 a las 4:25, Laurent Bercot escribió: > > Do you mean __GNUC__ instead of __GNU__ ? No, I mean __GNU__ without the "C. __GNUC__ is a different predefined macro. G.

Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Jens Rehsack
> Am 17.10.2019 um 01:07 schrieb Guillermo : > > El mié., 16 oct. 2019 a las 14:02, Laurent Bercot escribió: >> >>> 1. In src/include/skalibs/nonposix.h, >>> >>> #if defined(__linux__) || defined(__GLIBC__) >>> The if condition seems not working. Of course it's not __linux__, but I am >>>

Re: Porting skalibs to GNU Hurd

2019-10-17 Thread Laurent Bercot
If compiler predefined macros like __linux__ or __NetBSD__ are OK for , how about #if defined(__linux__) || defined(__GNU__)? GCC predefines both __GNU__ and __gnu_hurd__ (I think, can be checked with 'cpp -dM - Do you mean __GNUC__ instead of __GNU__ ? Testing defined(__GNUC__) would yield