Re: [PATCH] Fix openreadnclose failing if errno was nonzero before

2017-05-24 Thread Laurent Bercot
Just to be sure, I released skalibs-2.5.1.1, so there's a stable version with that bug fixed. Update: the 2.5.1.0 bug breaks s6-rc-update pretty badly, so upgrading to skalibs-2.5.1.1 is highly recommended. -- Laurent

Re: [PATCH] Fix openreadnclose failing if errno was nonzero before

2017-05-22 Thread Laurent Bercot
Just to be sure, I released skalibs-2.5.1.1, so there's a stable version with that bug fixed. -- Laurent

Re: [PATCH] Fix openreadnclose failing if errno was nonzero before

2017-05-22 Thread Olivier Brunel
On Mon, 22 May 2017 00:44:28 + "Laurent Bercot" wrote: > Does this bug manifest in serious ways, for instance making a s6 > program > fail when it should not? If it does, I'll need to release a new > skalibs version just for this >.> I didn't notice it from a s6 program, but from anopa wh

Re: [PATCH] Fix openreadnclose failing if errno was nonzero before

2017-05-21 Thread Laurent Bercot
+ errno = 0 ; Ack! Of course. Applied with a minor style change. (I like to keep declaring variables at the start of a block.) Thanks! Does this bug manifest in serious ways, for instance making a s6 program fail when it should not? If it does, I'll need to release a new skalibs version

[PATCH] Fix openreadnclose failing if errno was nonzero before

2017-05-21 Thread Olivier Brunel
Signed-off-by: Olivier Brunel --- src/libstddjb/openreadnclose.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libstddjb/openreadnclose.c b/src/libstddjb/openreadnclose.c index aa61ece..39bb3b9 100644 --- a/src/libstddjb/openreadnclose.c +++ b/src/libstddjb/openreadnclose.c @@ -7,6 +7,7