Re: s6-envdir bug/behavior change

2017-05-21 Thread Laurent Bercot 

This change is intended. Laurent had never meant for s6-envdir to
ignore directories, the previous behaviour was just a coincidence.
When I made him asked him about this last week, he immediately made the
parsing code in skalibs stricter.


 To be more precise: the fact that directories were being ignored was
a consequence of a bug in the implementation of openreadnclose. Fixing
the bug changed the behaviour of s6-envdir, but the new behaviour is the
one that had always been intended. Sorry if you relied on the previous
behaviour.

 I will add a note about the contents of an envdir.

--
 Laurent

Re: s6-envdir bug/behavior change

2017-05-21 Thread Luis Ressel 
On Sun, 21 May 2017 22:59:42 +0200
Olivier Brunel  wrote:

> Doc says that "s6-envdir reads files in DIR"; And before, if DIR
> contained one or more directories they were simply ignored. Now
> however, it will fail (111) :
> s6-envdir: fatal: unable to envdir: Is a directory

This change is intended. Laurent had never meant for s6-envdir to
ignore directories, the previous behaviour was just a coincidence.
When I made him asked him about this last week, he immediately made the
parsing code in skalibs stricter.

Cheers,
Luis


pgpqEhs2Ri6y0.pgp
Description: OpenPGP digital signature

s6-envdir bug/behavior change

2017-05-21 Thread Olivier Brunel 
Hey,

Not sure if this was intended or not, but the latest s6-envdir has some
behavior change that at the very least would need to be documented:

Doc says that "s6-envdir reads files in DIR"; And before, if DIR
contained one or more directories they were simply ignored. Now however,
it will fail (111) :
s6-envdir: fatal: unable to envdir: Is a directory

(I think this might be linked to the changes in skalibs, specifically
openreadnclose and error handling.)

Cheers,