Re: [Slackbuilds-users] RFC: patch for cfitsio for some astronomy software
On 03/03/2018 09:59 AM, Dominik Drobek wrote: > Hi again, > > Turns out you don't need to compile libindi to reproduce the issue. It's > sufficient to simply attempt to compile anything with gcc using -lcfitsio. > --snip--- > > I prefer to fix this issue with my SlackBuild by simply removing > --with-bzip2 option from ./configure. And I will do it this way, unless > you will tell me that you need bzip2 support in cfitsio. :) > > I naively assumed that simply adding --with-bzip2 will enable this > feature without any further problems. Sorry for the inconvenience. > > Regards, > Dominik > Dominik, success. with your new cfitsio, and a few other new and SBo deps, I have libindi running and working via a indi client to connect to my ASI camera and collect FITS and SER data. I left "export LDFLAGS="-lbz2" in my script just in case.'.can't hurt. I'll post the indi stuff soonest. Unfortunately, 14.2 Kstars is too old, so I'll have to wait until 15.0 and KDE 5. signature.asc Description: OpenPGP digital signature ___ SlackBuilds-users mailing list SlackBuilds-users@slackbuilds.org https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/ FAQ - https://slackbuilds.org/faq/
Re: [Slackbuilds-users] RFC: patch for cfitsio for some astronomy software
On 03/03/2018 09:59 AM, Dominik Drobek wrote:
> Hi again,
>
> Turns out you don't need to compile libindi to reproduce the issue. It's
> sufficient to simply attempt to compile anything with gcc using -lcfitsio.
>
> The problem is in the way configure script in cfitsio handles
> --with-bzip2 option. It has an "optional" argument, which is supposed to
> be a path to where libbz2.so resides. Notice this snippet from
> configure.in:
>
> # BZIP2 flags:
> if test "x$BZIP2_PATH" != x; then
> CFLAGS="$CFLAGS -I${BZIP2_PATH}/include"
> LDFLAGS="$LDFLAGS -L${BZIP2_PATH}/lib -lbz2"
> fi
>
> If "optional" argument to --with-bzip2 is not supplied then $BZIP2_PATH
> is empty, and -lbz2 doesn't get added to LDFLAGS. If $BZIP2_PATH is not
> empty then -lbz2 will be added to LDFLAGS. Additionally, -L option will
> be added. This will not have a correct path in Slackware64 (because it
> always ends with "/lib"), but it actually doesn't matter, since system
> libbz2.so is in the default search location.
>
> I prefer to fix this issue with my SlackBuild by simply removing
> --with-bzip2 option from ./configure. And I will do it this way, unless
> you will tell me that you need bzip2 support in cfitsio. :)
>
> I naively assumed that simply adding --with-bzip2 will enable this
> feature without any further problems. Sorry for the inconvenience.
>
> Regards,
> Dominik
>
Dominik,
So far so good. libindi compiled OK. I'm till sifting through
dependenices for the driver script. Once that's working I'll see if it
all works!
Thanks
Ed
signature.asc
Description: OpenPGP digital signature
___
SlackBuilds-users mailing list
SlackBuilds-users@slackbuilds.org
https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/
FAQ - https://slackbuilds.org/faq/
Re: [Slackbuilds-users] RFC: patch for cfitsio for some astronomy software
Hi again,
Turns out you don't need to compile libindi to reproduce the issue. It's
sufficient to simply attempt to compile anything with gcc using -lcfitsio.
The problem is in the way configure script in cfitsio handles
--with-bzip2 option. It has an "optional" argument, which is supposed to
be a path to where libbz2.so resides. Notice this snippet from configure.in:
# BZIP2 flags:
if test "x$BZIP2_PATH" != x; then
CFLAGS="$CFLAGS -I${BZIP2_PATH}/include"
LDFLAGS="$LDFLAGS -L${BZIP2_PATH}/lib -lbz2"
fi
If "optional" argument to --with-bzip2 is not supplied then $BZIP2_PATH
is empty, and -lbz2 doesn't get added to LDFLAGS. If $BZIP2_PATH is not
empty then -lbz2 will be added to LDFLAGS. Additionally, -L option will
be added. This will not have a correct path in Slackware64 (because it
always ends with "/lib"), but it actually doesn't matter, since system
libbz2.so is in the default search location.
I prefer to fix this issue with my SlackBuild by simply removing
--with-bzip2 option from ./configure. And I will do it this way, unless
you will tell me that you need bzip2 support in cfitsio. :)
I naively assumed that simply adding --with-bzip2 will enable this
feature without any further problems. Sorry for the inconvenience.
Regards,
Dominik
___
SlackBuilds-users mailing list
SlackBuilds-users@slackbuilds.org
https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/
FAQ - https://slackbuilds.org/faq/
Re: [Slackbuilds-users] RFC: patch for cfitsio for some astronomy software
W dniu 03.03.2018 o 00:40, King Beowulf pisze: I wasn't aware that the patch also removes the bundled zlib. Since zlib (and bzip2) are part of Slackware, would there be any unintended consequences? I have some doubts about that as well. I suppose that cfitsio authors have a good reason to include zlib in their source tarball. Apart from that, removing bundled zlib would violate the SlackBuilds.org recommendation "No custom patches unless absolutely necessary". I'm still sorting out libindi and drivers compilation and so have not yet tested if anything works. Could you test something for me, Ed? In my cfitsio.SlackBuild ./configure has an option --with-bzip2. Could you remove --with-bzip2, recompile cfitsio (without applying any patches), reinstall, and then try to compile libindi once more? Will it report any linking errors? Regards, Dominik ___ SlackBuilds-users mailing list SlackBuilds-users@slackbuilds.org https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/ FAQ - https://slackbuilds.org/faq/
Re: [Slackbuilds-users] RFC: patch for cfitsio for some astronomy software
W dniu 02.03.2018 o 03:54, King Beowulf pisze: I recommend applying the Fedora patch to cfitsio to fix underlinking to bzip2 for some astronomy software. Hi, Thanks for notifying me. I'd like to clarify one thing. Ed's suggested modification to cfitsio.SlackBuild removes most of the bundled zlib sources. I'm not sure this step is necessary, as the Fedora patch removes these source files from ZLIB_SOURCES variable in Makefile.in. Applying the patch seems to be enough to avoid compilation of these files. By the way, cfitsio has just been updated to version 3.430. Fedora patch still applies, so I can include it in the next update. Regards, Dominik ___ SlackBuilds-users mailing list SlackBuilds-users@slackbuilds.org https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/ FAQ - https://slackbuilds.org/faq/
Re: [Slackbuilds-users] RFC: patch for cfitsio for some astronomy software
On 03/02/2018 01:55 PM, Dominik Drobek wrote: > W dniu 02.03.2018 o 03:54, King Beowulf pisze: >> I recommend applying the Fedora patch to cfitsio to fix underlinking to >> bzip2 for some astronomy software. > > Hi, > > Thanks for notifying me. > > I'd like to clarify one thing. Ed's suggested modification to > cfitsio.SlackBuild removes most of the bundled zlib sources. I'm not > sure this step is necessary, as the Fedora patch removes these source > files from ZLIB_SOURCES variable in Makefile.in. Applying the patch > seems to be enough to avoid compilation of these files. > > By the way, cfitsio has just been updated to version 3.430. Fedora patch > still applies, so I can include it in the next update. > > Regards, > Dominik > I wasn't aware that the patch also removes the bundled zlib. Since zlib (and bzip2) are part of Slackware, would there be any unintended consequences? I'm still sorting out libindi and drivers compilation and so have not yet tested if anything works. -Ed signature.asc Description: OpenPGP digital signature ___ SlackBuilds-users mailing list SlackBuilds-users@slackbuilds.org https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/ FAQ - https://slackbuilds.org/faq/
