Re: [smartos-discuss] inotify issues

2014-12-11 Thread Bryan Cantrill via smartos-discuss
Just wanted to let you know that I fixed this; commit is here: https://github.com/joyent/illumos-joyent/commit/af6c46b5dae7a37d78d71546df5045236cd48994 This doesn't address the IN_CREATE issue, which is a much more involved issue -- but should solve the FIONREAD problems... - Bryan

Re: [smartos-discuss] inotify issues

2014-12-11 Thread Youzhong Yang via smartos-discuss
Thanks Bryan for your attentions to these issues and providing fixes so quickly. I really appreciate it. This morning I built new image with your fix and confirmed that now samba works smoothly providing change notification using inotify in a smartos OS zone. It's the first time we no longer

Re: [smartos-discuss] inotify issues

2014-12-11 Thread Bryan Cantrill via smartos-discuss
Youzhong, Awesome -- that's great news! And that's exactly what I wanted to know with respect to IN_CREATE, thank you! I think it's worth keeping track of that issue, but any fix is going to be pretty ugly, so I'm just as happy to not fix it. ;) Thanks again for the issues and test cases --