Re: [soci-users] RFD: Using CATCH for tests

2015-04-16 Thread Mateusz Loskot
On 1 April 2015 at 14:59, Vadim Zeitlin wrote: > On Fri, 27 Mar 2015 18:25:04 +0100 Mateusz Loskot wrote: > > ML> On 27 March 2015 at 17:53, Vadim Zeitlin wrote: > ML> > ML> > My favourite solution would be to just move the tests one level up in > the > ML> > file system, i.e. get rid of the su

Re: [soci-users] RFD: Using CATCH for tests

2015-04-01 Thread Vadim Zeitlin
On Fri, 27 Mar 2015 18:25:04 +0100 Mateusz Loskot wrote: ML> On 27 March 2015 at 17:53, Vadim Zeitlin wrote: ML> ML> > My favourite solution would be to just move the tests one level up in the ML> > file system, i.e. get rid of the subdirectory completely. But we could also ML> > keep the hiera

Re: [soci-users] RFD: Using CATCH for tests

2015-03-27 Thread Mateusz Loskot
On 27 March 2015 at 17:53, Vadim Zeitlin wrote: > On Fri, 27 Mar 2015 10:05:32 +0100 Mateusz Loskot wrote: > > ML> > OK, thanks for your support! I won't be able to finish this today, but > ML> > I'll try to do it tomorrow or, if this fails too, early next week. One > way > ML> > or the other,

Re: [soci-users] RFD: Using CATCH for tests

2015-03-27 Thread Vadim Zeitlin
On Fri, 27 Mar 2015 10:05:32 +0100 Mateusz Loskot wrote: ML> > OK, thanks for your support! I won't be able to finish this today, but ML> > I'll try to do it tomorrow or, if this fails too, early next week. One way ML> > or the other, I really want to get CATCH in. ML> ML> No problem, sounds go

Re: [soci-users] RFD: Using CATCH for tests

2015-03-27 Thread Mateusz Loskot
On 27 March 2015 at 01:56, Vadim Zeitlin wrote: > On Thu, 26 Mar 2015 23:46:18 +0100 Mateusz Loskot wrote: > > ML> I agree and I'm supportive about merging your efforts. > ... > ML> > 2. Complete the work done for Firebird on catch-tests branch for the > other > ML> >backends and merge it. >

Re: [soci-users] RFD: Using CATCH for tests

2015-03-26 Thread Vadim Zeitlin
On Thu, 26 Mar 2015 23:46:18 +0100 Mateusz Loskot wrote: ML> Not litreally, I meant single assert as testing one thing per test routine. ML> Currently, tests are bundled together around test data/table. Ah, yes, I certainly agree with this, sorry for the misunderstanding. ML> > What would be

Re: [soci-users] RFD: Using CATCH for tests

2015-03-26 Thread Mateusz Loskot
On 26 March 2015 at 22:56, Vadim Zeitlin wrote: > On Thu, 26 Mar 2015 20:17:27 +0100 Mateusz Loskot wrote: > > ML> > I am less sure about how to handle the transition from assert() to > CATCH. > ML> > One possibility would be to just globally replace all asserts with > ML> > REQUIRE() macros. T

Re: [soci-users] RFD: Using CATCH for tests

2015-03-26 Thread Vadim Zeitlin
On Thu, 26 Mar 2015 20:17:27 +0100 Mateusz Loskot wrote: ML> > Assuming there are no objections to using it, I'd like to add catch.hpp ML> > (https://github.com/philsquared/Catch/blob/master/single_include/catch.hpp) ML> > directly to SOCI repository, e.g. as tests/catch.hpp. I don't think it's

Re: [soci-users] RFD: Using CATCH for tests

2015-03-26 Thread Mateusz Loskot
On 25 March 2015 at 17:30, Vadim Zeitlin wrote: > > While we're discussing other "strategic" things, I'd like to also return > to something that was mentioned a couple of times in the past but without > any definitive conclusion, unless I missed it: could we start using CATCH > (http://catch-lib.