Re: svn commit: r818816 - /lucene/solr/trunk/src/java/org/apache/solr/search/SolrFieldCacheMBean.java

2009-09-27 Thread Shalin Shekhar Mangar
On Sun, Sep 27, 2009 at 1:50 AM, Chris Hostetter hossman_luc...@fucit.orgwrote: FWIW: adding the whitespaces makes these key names inconcsistant with every other stat name in solr ... none of them use whitespace In cases where the lack of spaces makes things hard to read other mbeans use _

Re: DebugLogger oddity

2009-09-27 Thread Shalin Shekhar Mangar
On Sun, Sep 27, 2009 at 9:41 AM, Mark Miller markrmil...@gmail.com wrote: DebugLogger has the following code: public DebugInfo(String name, int type, DebugInfo parent) { this.name = name; this.type = type; this.parent = parent; lst = new NamedList(); if (parent

[jira] Commented: (SOLR-1466) Fix File descriptor leak in SnapPuller

2009-09-27 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12759992#action_12759992 ] Shalin Shekhar Mangar commented on SOLR-1466: - Yep, there is a leak alright.

Solr nightly build failure

2009-09-27 Thread solr-dev
init-forrest-entities: [mkdir] Created dir: /tmp/apache-solr-nightly/build [mkdir] Created dir: /tmp/apache-solr-nightly/build/web compile-solrj: [mkdir] Created dir: /tmp/apache-solr-nightly/build/solrj [javac] Compiling 86 source files to /tmp/apache-solr-nightly/build/solrj

Hudson build is back to normal: Solr-trunk #937

2009-09-27 Thread Apache Hudson Server
See http://hudson.zones.apache.org/hudson/job/Solr-trunk/937/changes

[jira] Resolved: (SOLR-1466) Fix File descriptor leak in SnapPuller

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller resolved SOLR-1466. --- Resolution: Fixed Assignee: Mark Miller Thanks for the review! Fix File descriptor leak in

[jira] Resolved: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller resolved SOLR-1221. --- Resolution: Fixed Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by

[jira] Updated: (SOLR-1314) Upgrade Carrot2 to version 3.1.0

2009-09-27 Thread Stanislaw Osinski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislaw Osinski updated SOLR-1314: Attachment: SOLR-1314.patch Hi Grant, I've built Carrot2 3.1.0 binaries and tested them

Re: svn commit: r819314 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java src/test/org/apache/solr/highlight/HighlighterTest.java

2009-09-27 Thread Koji Sekiguchi
Also make both options default to true. If so, isn't this line (from HighlightComponent) needed to be also true by default? boolean rewrite = !(Boolean.valueOf(req.getParams().get(HighlightParams.USE_PHRASE_HIGHLIGHTER))

Re: svn commit: r819314 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java src/test/org/apache/solr/highlight/HighlighterTest.java

2009-09-27 Thread Mark Miller
Thank you Koji! Indeed - those need to default true now. Nice eyes, and thanks for looking over! Koji Sekiguchi wrote: Also make both options default to true. If so, isn't this line (from HighlightComponent) needed to be also true by default? boolean rewrite =

Re: svn commit: r819314 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java src/test/org/apache/solr/highlight/HighlighterTest.java

2009-09-27 Thread Mark Miller
Turned up a bug to boot ... Mark Miller wrote: Thank you Koji! Indeed - those need to default true now. Nice eyes, and thanks for looking over! Koji Sekiguchi wrote: Also make both options default to true. If so, isn't this line (from HighlightComponent) needed to be also

[jira] Reopened: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller reopened SOLR-1221: --- There is a bug to take care of, and a missing piece that Koji pointed out. Change Solr Highlighting to

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760048#action_12760048 ] Mark Miller commented on SOLR-1221: --- Grrr ... darn it. Its at the Lucene level.

print junit test name

2009-09-27 Thread Yonik Seeley
Right now, if I see something funny (like an exception that doesn't cause a test failure) in a big junit test report, it's hard to tell what test it was in - the output for each test is simply catenated, with no separator. Is there a way to get junit to print this info, or do we need to do

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760057#action_12760057 ] Mark Miller commented on SOLR-1221: --- Easy enough to side step this bug in Lucene for now -

Re: print junit test name

2009-09-27 Thread Chris Hostetter
: Right now, if I see something funny (like an exception that doesn't : cause a test failure) in a big junit test report, it's hard to tell : what test it was in - the output for each test is simply catenated, : with no separator. what do you mean by output? System.out? System.err? messages

Re: print junit test name

2009-09-27 Thread Yonik Seeley
On Sun, Sep 27, 2009 at 1:13 PM, Chris Hostetter hossman_luc...@fucit.org wrote: : Right now, if I see something funny (like an exception that doesn't : cause a test failure) in a big junit test report, it's hard to tell : what test it was in - the output for each test is simply catenated, :

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760078#action_12760078 ] Mark Miller commented on SOLR-1221: --- What do people thing about putting in an updated

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760079#action_12760079 ] Yonik Seeley commented on SOLR-1221: bq. What do people thing about putting in an

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760080#action_12760080 ] Mark Miller commented on SOLR-1221: --- I don't see one - ugly options I can think of - 1.

Re: [jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Chris Hostetter
: 3. use an overridden version of NumericQuery in Solr that returns a placeholder term from getTerm on the surface that doesn't sound too horrific. just make it final and deprecated and open an issue to remove it when upgrading to Lucene 3.0. -Hoss

Re: [jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller
Chris Hostetter wrote: : 3. use an overridden version of NumericQuery in Solr that returns a placeholder term from getTerm on the surface that doesn't sound too horrific. just make it final and deprecated and open an issue to remove it when upgrading to Lucene 3.0. -Hoss Yeah, your

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760082#action_12760082 ] Yonik Seeley commented on SOLR-1221: How can one reproduce this bug? The query parser

[jira] Issue Comment Edited: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760083#action_12760083 ] Mark Miller edited comment on SOLR-1221 at 9/27/09 11:54 AM: -

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760083#action_12760083 ] Mark Miller commented on SOLR-1221: --- Sorry - should have been more clear. The bug is

Re: Fwd: 8 for 1.4

2009-09-27 Thread Chris Hostetter
: On S-1294, the SolrJS patch, I yet again have concerns about even including : this, given the lack of activity (from Matthias, the original author and ... : true for others too. At a minimum, I think S-1294 should be pushed to 1.5. : Next up, I think we consider pulling SolrJS from

[jira] Updated: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1221: -- Attachment: SOLR-1221.patch this patch needs to be applied to finish the issue - but for now it will

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760087#action_12760087 ] Mark Miller commented on SOLR-1221: --- bq. The query parser produces a normal term query for

[jira] Issue Comment Edited: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760083#action_12760083 ] Mark Miller edited comment on SOLR-1221 at 9/27/09 12:36 PM: -

[jira] Reopened: (SOLR-1447) Simple property injection

2009-09-27 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar reopened SOLR-1447: - Re-opening because the mergeScheduler and mergePolicy specified in the indexDefaults

[jira] Updated: (SOLR-1447) Simple property injection

2009-09-27 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-1447: Attachment: SOLR-1447-indexDefault-test.patch Here's a test case which fails.

[jira] Updated: (SOLR-1447) Simple property injection

2009-09-27 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-1447: Attachment: SOLR-1447-indexDefault-test.patch Fix which passes the test case posted

[jira] Resolved: (SOLR-1447) Simple property injection

2009-09-27 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar resolved SOLR-1447. - Resolution: Fixed Committed revision 819401. Simple property injection

[jira] Created: (SOLR-1467) SolrJ XML parser errors on null names in a NamedList

2009-09-27 Thread Yonik Seeley (JIRA)
SolrJ XML parser errors on null names in a NamedList Key: SOLR-1467 URL: https://issues.apache.org/jira/browse/SOLR-1467 Project: Solr Issue Type: Bug Components: clients - java

[jira] Created: (SOLR-1468) Solrj bug when using facet.missing

2009-09-27 Thread Tomasz Wrobel (JIRA)
Solrj bug when using facet.missing -- Key: SOLR-1468 URL: https://issues.apache.org/jira/browse/SOLR-1468 Project: Solr Issue Type: Bug Components: clients - java Affects Versions: 1.3

[jira] Deleted: (SOLR-1467) SolrJ XML parser errors on null names in a NamedList

2009-09-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley deleted SOLR-1467: --- SolrJ XML parser errors on null names in a NamedList

[jira] Resolved: (SOLR-1468) Solrj bug when using facet.missing

2009-09-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-1468. Resolution: Fixed I just committed a patch for this... thanks for the bug report! Solrj bug when

[jira] Updated: (SOLR-1449) solrconfig.xml syntax to add classpath elements from outside of instanceDir

2009-09-27 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-1449: --- Attachment: SOLR-1449.patch checkpoint patch, new additions... 1. updated TestConfig to also assert that the

[jira] Commented: (SOLR-1449) solrconfig.xml syntax to add classpath elements from outside of instanceDir

2009-09-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760107#action_12760107 ] Yonik Seeley commented on SOLR-1449: bq. lib dir=../../dist/ As you say, layout is a

solr hudson builds

2009-09-27 Thread Yonik Seeley
I've switched ant test to use the plain formatter rather than the XML formatter - I think this is a lot more sane for humans looking at the output. XML escaped failing assertions are no fun to read. And of course there is the buffering bug too - running any really large test that prodoces output

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760112#action_12760112 ] Mark Miller commented on SOLR-1221: --- bq. deprec ConstantScoreRangeQuery (if ever used in

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760114#action_12760114 ] Uwe Schindler commented on SOLR-1221: - Does RangeQuery really need to be highlighted? It

[jira] Updated: (SOLR-1449) solrconfig.xml syntax to add classpath elements from outside of instanceDir

2009-09-27 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-1449: --- Attachment: SOLR-1449.patch minor update to the previous patch... 1) the patch command didn't like the empty

[jira] Commented: (SOLR-1449) solrconfig.xml syntax to add classpath elements from outside of instanceDir

2009-09-27 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760124#action_12760124 ] Hoss Man commented on SOLR-1449: bq. should we reference the libs in contrib (where they are

[jira] Assigned: (SOLR-1449) solrconfig.xml syntax to add classpath elements from outside of instanceDir

2009-09-27 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man reassigned SOLR-1449: -- Assignee: Hoss Man solrconfig.xml syntax to add classpath elements from outside of instanceDir

[jira] Commented: (SOLR-1221) Change Solr Highlighting to use the SpanScorer with MultiTerm expansion by default

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760127#action_12760127 ] Mark Miller commented on SOLR-1221: --- bq. In Lucene, the fix would only be needed for

Re: solr hudson builds

2009-09-27 Thread Chris Hostetter
: I've switched ant test to use the plain formatter rather than the : XML formatter - I think this is a lot more sane for humans looking at : the output. XML escaped failing assertions are no fun to read. And ...although if you use ant test-reports you're going to want to add

[jira] Created: (SOLR-1469) TestReplicationHandler failure

2009-09-27 Thread Yonik Seeley (JIRA)
TestReplicationHandler failure -- Key: SOLR-1469 URL: https://issues.apache.org/jira/browse/SOLR-1469 Project: Solr Issue Type: Bug Reporter: Yonik Seeley TestReplicationHandler seems to fail often.

[jira] Updated: (SOLR-1469) TestReplicationHandler failure

2009-09-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-1469: --- Attachment: TestReplicationHandler.FAILED.210743 Attaching one particular worrying failure.

compound file format being used

2009-09-27 Thread Yonik Seeley
Hey, it seems like the compound file format is always being used now... even in the example, when the config says not to. Anyone notice when this started? -Yonik http://www.lucidimagination.com

[jira] Commented: (SOLR-1469) TestReplicationHandler failure

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760134#action_12760134 ] Mark Miller commented on SOLR-1469: --- Are you using Windows? Havn't gotten it to fail on

[jira] Created: (SOLR-1470) index formats always compound

2009-09-27 Thread Yonik Seeley (JIRA)
index formats always compound - Key: SOLR-1470 URL: https://issues.apache.org/jira/browse/SOLR-1470 Project: Solr Issue Type: Bug Reporter: Yonik Seeley Fix For: 1.4 Seems like the

Re: compound file format being used

2009-09-27 Thread Mark Miller
Mark Miller wrote: Yonik Seeley wrote: Hey, it seems like the compound file format is always being used now... even in the example, when the config says not to. Anyone notice when this started? -Yonik http://www.lucidimagination.com Its being set correctly. Something with the

[jira] Updated: (SOLR-1470) index formats always compound

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1470: -- Attachment: SOLR-1470.patch I think this will fix it index formats always compound

Re: compound file format being used

2009-09-27 Thread Mark Miller
Yonik Seeley wrote: Hey, it seems like the compound file format is always being used now... even in the example, when the config says not to. Anyone notice when this started? -Yonik http://www.lucidimagination.com Its being set correctly. Something with the mergepolicy? -- - Mark

[jira] Commented: (SOLR-1470) index formats always compound

2009-09-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760139#action_12760139 ] Mark Miller commented on SOLR-1470: --- You know, it says that only works with LogMergePolicy

[jira] Commented: (SOLR-1469) TestReplicationHandler failure

2009-09-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760146#action_12760146 ] Yonik Seeley commented on SOLR-1469: OK, I think this particular one might be a bug in