[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792855#action_12792855
]
Yonik Seeley commented on SOLR-1664:
I like the direction I think... the current split
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792885#action_12792885
]
Noble Paul commented on SOLR-1664:
--
yes. cleaner code is definitely a plus
Some Methods
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792498#action_12792498
]
Yonik Seeley commented on SOLR-1664:
bq. The point is , if we wish to go down this path
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792503#action_12792503
]
Noble Paul commented on SOLR-1664:
--
bq.this issue should stand on it's own and not be
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792780#action_12792780
]
Noble Paul commented on SOLR-1664:
--
* Are we in consensus that this is going in?
* Any
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791884#action_12791884
]
Grant Ingersoll commented on SOLR-1664:
---
createField is already just a pass through to
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791892#action_12791892
]
Noble Paul commented on SOLR-1664:
--
bq.It's cheaper than a dynamic field.
I cannot see
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791911#action_12791911
]
Grant Ingersoll commented on SOLR-1664:
---
I've got a new patch that reduces the string
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791927#action_12791927
]
Grant Ingersoll commented on SOLR-1664:
---
I think SchemaField needs to remain final. I
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791928#action_12791928
]
Noble Paul commented on SOLR-1664:
--
The questions I have are.
Is this a good enhancement
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791931#action_12791931
]
Noble Paul commented on SOLR-1664:
--
bq.I think SchemaField needs to remain final. I don't
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791934#action_12791934
]
Grant Ingersoll commented on SOLR-1664:
---
It is not correct b/c SchemaField should be
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791933#action_12791933
]
Yonik Seeley commented on SOLR-1664:
SchemaField is final and very light weight for a
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791935#action_12791935
]
Noble Paul commented on SOLR-1664:
--
bq.It's also the case that it can be safely published
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791937#action_12791937
]
Grant Ingersoll commented on SOLR-1664:
---
bq. Changing this design for the same of
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791942#action_12791942
]
Yonik Seeley commented on SOLR-1664:
bq. I agree with that. As long as any other
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791946#action_12791946
]
Noble Paul commented on SOLR-1664:
--
bq.it only makes sense to make it non-final if you
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792041#action_12792041
]
Yonik Seeley commented on SOLR-1664:
bq. It did not make any non-backcompat changes
[
https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792347#action_12792347
]
Noble Paul commented on SOLR-1664:
--
bq.Then everything must go through SchemaField and not
19 matches
Mail list logo
