[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man resolved SOLR-135.
---
Resolution: Fixed
Committed revision 547455.
> Restructure / Refactor codebase for shared libraries
> ---
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man reopened SOLR-135:
---
Whoops ... while banging my head against my desk trying ot figure out why i
couldn't see my changes, i discovered
Chris Hostetter wrote:
:
: 1. Using eclipse, refactor common classes and *move* them to the new
: 3. Add a @deprecated new class in the place of any moved class. The new
: class will have the same name and extend the old class. They will not
: have version history. These files will be deleted
:
: 1. Using eclipse, refactor common classes and *move* them to the new
: 3. Add a @deprecated new class in the place of any moved class. The new
: class will have the same name and extend the old class. They will not
: have version history. These files will be deleted when we have a
I'm curi
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan McKinley resolved SOLR-135.
Resolution: Fixed
phew! The changelog frenzy was successful. Thank you eclipse.
The moved files ha
Ryan McKinley (JIRA) wrote:
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan McKinley reassigned SOLR-135:
--
Assignee: Ryan McKinley
I plan to do this later this evening unles
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan McKinley reassigned SOLR-135:
--
Assignee: Ryan McKinley
> Restructure / Refactor codebase for shared libraries
>
For anyone not following SOLR-135... there is discussion of some
changes to the jar fiels and package layout. For SOLR-20, some classes
need to be extracted from the main jar. We have two options:
1. Keep the package names as is and create a two jar files each with
classes in o.a.s.util
2
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504156
]
Ryan McKinley commented on SOLR-135:
> do we want to rework the packages too?
I think now is as good of a time as
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504068
]
Hoss Man commented on SOLR-135:
---
>> yes, I like separate package names better but i'm worried about the
>> impact on
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504039
]
Ryan McKinley commented on SOLR-135:
As a note to anyone not looking at the patch... this would not break API
com
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504038
]
Ryan McKinley commented on SOLR-135:
>
>it would be easy to move this package to live in src/common if people thin
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-135:
--
Attachment: SOLR-135-RestructureForCommonJar.patch
as far as i can tell the manifest merging that the ant docs de
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-135:
--
Attachment: SOLR-135-RestructureForCommonJar.patch
here's what i've got so far ...it occured to me that if we use
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504009
]
Hoss Man commented on SOLR-135:
---
one the topic of adding a src/common directory ... i think in the long run
we'll be hap
: I have been unable to make a patch that successfully moves XML.java from
: /src/java to /src/common, when you test this, just copy the file over --
: no changes.
"svn move" will correctly move the file from point A to point B
(preserving history) but a deficiency of the svn/patch interaction is
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan McKinley updated SOLR-135:
---
Attachment: SOLR-135-RestructureForCommonJar.patch
This patch moves a single file (XML.java) into a new
: It would also be nice to move:
: AbstractSolrTestCase.java, TestHarness.java, and o.a.s.util.test to:
: \solr\src\test\org\apache\solr\util
FYI: AbstractSolrTestCase and TestHarness are in the src/java tree instead
of the src/test tree so that they get included in the solr.jar and people
usin
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469900
]
Yonik Seeley commented on SOLR-135:
---
Sounds good in general, I think.
The test request handler (in tst), was for lev
[
https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469711
]
Ryan McKinley commented on SOLR-135:
A first start for this would be to move:
/solr/src/java/org/apache/solr/util
Restructure / Refactor codebase for shared libraries
Key: SOLR-135
URL: https://issues.apache.org/jira/browse/SOLR-135
Project: Solr
Issue Type: Wish
Reporter: Ryan McKinley
21 matches
Mail list logo
